Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2254765 by damiankloip: No confirmation messages when Views UI settings forms are saved.

8.0.x
webchick 2014-05-03 23:15:17 -07:00
parent b01ecedff2
commit e88f22a232
3 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/modules/views_ui/lib/Drupal/views_ui/Form/AdvancedSettingsForm.php
View File

@ -97,6 +97,8 @@ class AdvancedSettingsForm extends ConfigFormBase {
->set('no_javascript', $form_state['values']['no_javascript'])
->set('display_extenders', isset($form_state['values']['display_extenders']) ? $form_state['values']['display_extenders'] : array())
->save();
parent::submitForm($form, $form_state);
}
/**

2
core/modules/views_ui/lib/Drupal/views_ui/Form/BasicSettingsForm.php
View File

@ -139,6 +139,8 @@ class BasicSettingsForm extends ConfigFormBase {
->set('ui.show.performance_statistics', $form_state['values']['ui_show_performance_statistics'])
->set('ui.show.additional_queries', $form_state['values']['ui_show_additional_queries'])
->save();
parent::submitForm($form, $form_state);
}
}

25
core/modules/views_ui/lib/Drupal/views_ui/Tests/SettingsTest.php
View File

@ -37,6 +37,10 @@ class SettingsTest extends UITestBase {
$this->drupalGet('admin/structure/views');
$this->assertLinkByHref('admin/structure/views/settings');
// Test the confirmation message.
$this->drupalPostForm('admin/structure/views/settings', array(), t('Save configuration'));
$this->assertText(t('The configuration options have been saved.'));
// Configure to always show the master display.
$edit = array(
'ui_show_master_display' => TRUE,
@ -117,6 +121,27 @@ class SettingsTest extends UITestBase {
$this->assertEqual(count($xpath), 1, 'The views sql is shown.');
$this->assertFalse(strpos($xpath[0], 'db_condition_placeholder') !== FALSE, 'No placeholders are shown in the views sql.');
$this->assertTrue(strpos($xpath[0], "node_field_data.status = '1'") !== FALSE, 'The placeholders in the views sql is replace by the actual value.');
// Test the advanced settings form.
// Test the confirmation message.
$this->drupalPostForm('admin/structure/views/settings/advanced', array(), t('Save configuration'));
$this->assertText(t('The configuration options have been saved.'));
$edit = array(
'skip_cache' => TRUE,
'sql_signature' => TRUE,
'no_javascript' => TRUE,
);
$this->drupalPostForm('admin/structure/views/settings/advanced', $edit, t('Save configuration'));
$this->assertFieldChecked('edit-skip-cache', 'The skip_cache option is checked.');
$this->assertFieldChecked('edit-sql-signature', 'The sql_signature option is checked.');
$this->assertFieldChecked('edit-no-javascript', 'The no_javascript option is checked.');
// Test the "Clear Views' cache" button.
$this->drupalPostForm('admin/structure/views/settings/advanced', array(), t("Clear Views' cache"));
$this->assertText(t('The cache has been cleared.'));
}
}