Issue #2572601 by attiks, alexpott, tatarbj: Fix 'Drupal.Classes.ClassCreateInstance' coding standard

core/includes/theme.inc

@@ -1528,7 +1528,7 @@ function template_preprocess_field(&$variables, $hook) {
 
   static $default_attributes;
   if (!isset($default_attributes)) {
-    $default_attributes = new Attribute;
+    $default_attributes = new Attribute();
   }
 
   // Merge attributes when a single-value field has a hidden label.

core/lib/Drupal/Component/Gettext/PoStreamReader.php

@@ -219,7 +219,7 @@ class PoStreamReader implements PoStreamInterface, PoReaderInterface {
     if (!$item) {
       return;
     }
-    $header = new PoHeader;
+    $header = new PoHeader();
     $header->setFromString(trim($item->getTranslation()));
     $this->_header = $header;
   }

core/lib/Drupal/Core/Controller/ControllerResolver.php

@@ -68,7 +68,7 @@ class ControllerResolver extends BaseControllerResolver implements ControllerRes
         return $controller;
       }
       elseif (method_exists($controller, '__invoke')) {
-        return new $controller;
+        return new $controller();
       }
     }
 

core/lib/Drupal/Core/DrupalKernel.php

@@ -1208,7 +1208,7 @@ class DrupalKernel implements DrupalKernelInterface, TerminableInterface {
     foreach ($this->serviceProviderClasses as $origin => $classes) {
       foreach ($classes as $name => $class) {
         if (!is_object($class)) {
-          $this->serviceProviders[$origin][$name] = new $class;
+          $this->serviceProviders[$origin][$name] = new $class();
         }
         else {
           $this->serviceProviders[$origin][$name] = $class;

core/modules/migrate/src/Plugin/Migration.php

@@ -416,7 +416,7 @@ class Migration extends PluginBase implements MigrationInterface, RequirementsIn
    */
   public function getDestinationPlugin($stub_being_requested = FALSE) {
     if ($stub_being_requested && !empty($this->destination['no_stub'])) {
-      throw new MigrateSkipRowException;
+      throw new MigrateSkipRowException();
     }
     if (!isset($this->destinationPlugin)) {
       $this->destinationPlugin = $this->destinationPluginManager->createInstance($this->destination['plugin'], $this->destination, $this);

core/modules/migrate/src/Plugin/migrate/process/MenuLinkParent.php

@@ -97,7 +97,7 @@ class MenuLinkParent extends ProcessPluginBase implements ContainerFactoryPlugin
         }
       }
     }
-    throw new MigrateSkipRowException;
+    throw new MigrateSkipRowException();
   }
 
 }

core/modules/simpletest/tests/src/Unit/SimpletestPhpunitRunCommandTest.php

@@ -19,7 +19,7 @@ class SimpletestPhpunitRunCommandTest extends UnitTestCase {
     include_once __DIR__ .'/../../fixtures/simpletest_phpunit_run_command_test.php';
     $app_root = __DIR__ . '/../../../../../..';
     include_once "$app_root/core/modules/simpletest/simpletest.module";
-    $container = new ContainerBuilder;
+    $container = new ContainerBuilder();
     $container->set('app.root', $app_root);
     $file_system = $this->prophesize('Drupal\Core\File\FileSystemInterface');
     $file_system->realpath('public://simpletest')->willReturn(sys_get_temp_dir());

core/modules/system/tests/modules/system_test/src/MockFileTransfer.php

@@ -14,7 +14,7 @@ class MockFileTransfer {
    *   A new Drupal\system_test\MockFileTransfer object.
    */
   public static function factory() {
-    return new MockFileTransfer;
+    return new MockFileTransfer();
   }
 
   /**

core/modules/update/tests/modules/update_test/src/MockFileTransfer.php

@@ -14,7 +14,7 @@ class MockFileTransfer {
    *   A new Drupal\update_test\MockFileTransfer object.
    */
   public static function factory() {
-    return new FileTransfer;
+    return new FileTransfer();
   }
 
   /**

core/phpcs.xml.dist

@@ -12,6 +12,7 @@
 
   <!-- Only include specific sniffs that pass. This ensures that, if new sniffs are added, HEAD does not fail.-->
   <!-- Drupal sniffs -->
+  <rule ref="Drupal.Classes.ClassCreateInstance"/>
   <rule ref="Drupal.Classes.UnusedUseStatement"/>
   <rule ref="Drupal.CSS.ClassDefinitionNameSpacing"/>
   <rule ref="Drupal.CSS.ColourDefinition"/>

core/tests/Drupal/Tests/Core/Template/AttributeTest.php

@@ -435,7 +435,7 @@ class AttributeTest extends UnitTestCase {
    *   The number of results that are found.
    */
   protected function getXPathResultCount($query, $html) {
-    $document = new \DOMDocument;
+    $document = new \DOMDocument();
     $document->loadHTML($html);
     $xpath = new \DOMXPath($document);
 

core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php

@@ -519,7 +519,7 @@ class LinkGeneratorTest extends UnitTestCase {
     }
 
     // Execute the query.
-    $document = new \DOMDocument;
+    $document = new \DOMDocument();
     $document->loadHTML($html);
     $xpath = new \DOMXPath($document);
 
@@ -538,7 +538,7 @@ class LinkGeneratorTest extends UnitTestCase {
    *   The number of results that are found.
    */
   protected function assertNoXPathResults($query, $html) {
-    $document = new \DOMDocument;
+    $document = new \DOMDocument();
     $document->loadHTML($html);
     $xpath = new \DOMXPath($document);