Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3306820 by matthieuscarset, kulmjens, smustgrave, bernardm28, xjm, quietone, dww, SKAUGHT, BlackBamboo, benjifisher, rkoller, simohell, worldlinemine: Show machine name in "Manage form display" and "Manage display" table row

merge-requests/11150/head
xjm 2024-06-17 16:45:58 -05:00
parent f355d928bf
commit e091a2fdd6
No known key found for this signature in database
GPG Key ID: 206B0B8743BDF4C2
5 changed files with 44 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/modules/field_ui/src/Form/EntityDisplayFormBase.php
View File

@ -319,6 +319,10 @@ abstract class EntityDisplayFormBase extends EntityForm {
'human_name' => [
'#plain_text' => $label,
],
'machine_name' => [
'#markup' => $field_name,
'#attributes' => ['class' => ['machine-name']],
],
'weight' => [
'#type' => 'textfield',
'#title' => $this->t('Weight for @title', ['@title' => $label]),
@ -492,6 +496,10 @@ abstract class EntityDisplayFormBase extends EntityForm {
'human_name' => [
'#markup' => $extra_field['label'],
],
'machine_name' => [
'#markup' => $field_id,
'#attributes' => ['class' => ['machine-name']],
],
'weight' => [
'#type' => 'textfield',
'#title' => $this->t('Weight for @title', ['@title' => $extra_field['label']]),

4
core/modules/field_ui/src/Form/EntityFormDisplayEditForm.php
View File

@ -96,6 +96,10 @@ class EntityFormDisplayEditForm extends EntityDisplayFormBase {
protected function getTableHeader() {
return [
$this->t('Field'),
[
'data' => $this->t('Machine name'),
'class' => [RESPONSIVE_PRIORITY_MEDIUM, 'machine-name'],
],
$this->t('Weight'),
$this->t('Parent'),
$this->t('Region'),

4
core/modules/field_ui/src/Form/EntityViewDisplayEditForm.php
View File

@ -130,6 +130,10 @@ class EntityViewDisplayEditForm extends EntityDisplayFormBase {
protected function getTableHeader() {
return [
$this->t('Field'),
[
'data' => $this->t('Machine name'),
'class' => [RESPONSIVE_PRIORITY_MEDIUM, 'machine-name'],
],
$this->t('Weight'),
$this->t('Parent'),
$this->t('Region'),

12
core/modules/field_ui/tests/src/Functional/ManageDisplayTest.php
View File

@ -73,6 +73,7 @@ class ManageDisplayTest extends BrowserTestBase {
'administer node display',
'administer taxonomy',
'administer taxonomy_term fields',
'administer taxonomy_term form display',
'administer taxonomy_term display',
'administer users',
'administer account settings',
@ -205,9 +206,16 @@ class ManageDisplayTest extends BrowserTestBase {
}
/**
* Tests hiding the view modes fieldset when there's only one available.
* Tests view mode management screens.
*/
public function testSingleViewMode() {
public function testViewModeUi(): void {
// Tests table headers on "Manage form" and "Manage display" screens.
$this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary . '/overview/form-display');
$this->assertTableHeaderExistsByLabel('field-display-overview', 'Machine name');
$this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary . '/overview/display');
$this->assertTableHeaderExistsByLabel('field-display-overview', 'Machine name');
// Tests hiding the view modes fieldset when there's only one available.
$this->drupalGet('admin/structure/taxonomy/manage/' . $this->vocabulary . '/display');
$this->assertSession()->pageTextNotContains('Use custom display settings for the following view modes');

18
core/modules/field_ui/tests/src/Traits/FieldUiTestTrait.php
View File

@ -266,4 +266,22 @@ trait FieldUiTestTrait {
$this->assertSession()->assert($element === NULL, sprintf('A field "%s" appears on this page, but it should not.', $label));
}
/**
* Asserts that a header cell appears on a table.
*
* @param string $table_id
* The HTML attribute value to target a given table.
* @param string $label
* The cell label.
*/
protected function assertTableHeaderExistsByLabel(string $table_id, string $label): void {
$expression = '//table[@id=:id]//tr//th[1 and text() = :label]';
$xpath = $this->assertSession()->buildXPathQuery($expression, [
':id' => $table_id,
':label' => $label,
]);
$element = $this->getSession()->getPage()->find('xpath', $xpath);
$this->assertSession()->assert($element !== NULL, sprintf('Table header not found by label: "%s".', $label));
}
}