- Patch #904994 by douggreen, chx: watchdog should always use replaceable argument.

merge-requests/26/head
Dries Buytaert 2010-09-11 01:47:14 +00:00
parent 8ed9f604c9
commit dde1858249
2 changed files with 4 additions and 4 deletions

View File

@ -2398,7 +2398,7 @@ function drupal_deliver_page($page_callback_result, $default_delivery_callback =
// If a delivery callback is specified, but doesn't exist as a function, // If a delivery callback is specified, but doesn't exist as a function,
// something is wrong, but don't print anything, since it's not known // something is wrong, but don't print anything, since it's not known
// what format the response needs to be in. // what format the response needs to be in.
watchdog('delivery callback not found', check_plain($delivery_callback) . ': ' . check_plain($_GET['q']), NULL, WATCHDOG_ERROR); watchdog('delivery callback not found', 'callback %callback not found: %q.', array('%callback' => $delivery_callback, '%q' => $_GET['q']), WATCHDOG_ERROR);
} }
} }
@ -2431,7 +2431,7 @@ function drupal_deliver_html_page($page_callback_result) {
// Print a 404 page. // Print a 404 page.
drupal_add_http_header('Status', '404 Not Found'); drupal_add_http_header('Status', '404 Not Found');
watchdog('page not found', check_plain($_GET['q']), NULL, WATCHDOG_WARNING); watchdog('page not found', 'page not found: %q.', array('%q' => $_GET['q']), WATCHDOG_WARNING);
// Keep old path for reference, and to allow forms to redirect to it. // Keep old path for reference, and to allow forms to redirect to it.
if (!isset($_GET['destination'])) { if (!isset($_GET['destination'])) {
@ -2460,7 +2460,7 @@ function drupal_deliver_html_page($page_callback_result) {
case MENU_ACCESS_DENIED: case MENU_ACCESS_DENIED:
// Print a 403 page. // Print a 403 page.
drupal_add_http_header('Status', '403 Forbidden'); drupal_add_http_header('Status', '403 Forbidden');
watchdog('access denied', check_plain($_GET['q']), NULL, WATCHDOG_WARNING); watchdog('access denied', 'access denied: %q', array('%q' => $_GET['q']), WATCHDOG_WARNING);
// Keep old path for reference, and to allow forms to redirect to it. // Keep old path for reference, and to allow forms to redirect to it.
if (!isset($_GET['destination'])) { if (!isset($_GET['destination'])) {

View File

@ -273,7 +273,7 @@ function comment_confirm_delete_submit($form, &$form_state) {
// Delete the comment and its replies. // Delete the comment and its replies.
comment_delete($comment->cid); comment_delete($comment->cid);
drupal_set_message(t('The comment and all its replies have been deleted.')); drupal_set_message(t('The comment and all its replies have been deleted.'));
watchdog('content', t('Deleted comment @cid and its replies.', array('@cid' => $comment->cid))); watchdog('content', 'Deleted comment @cid and its replies.', array('@cid' => $comment->cid));
// Clear the cache so an anonymous user sees that his comment was deleted. // Clear the cache so an anonymous user sees that his comment was deleted.
cache_clear_all(); cache_clear_all();