Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2473953 by mortendk, rteijeiro, rachel_norfolk, Cottser, aburrows, LewisNyman: Prefix form-submit classes with js-

8.0.x
Alex Pott 2015-05-20 13:56:15 +01:00
parent 241def3549
commit d8442c8e7c
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/lib/Drupal/Core/Render/Element/Button.php
View File

@ -76,7 +76,7 @@ class Button extends FormElement {
if (!empty($element['#button_type'])) {
$element['#attributes']['class'][] = 'button--' . $element['#button_type'];
}
// @todo Various JavaScript depends on this button class.
$element['#attributes']['class'][] = 'js-form-submit';
$element['#attributes']['class'][] = 'form-submit';
if (!empty($element['#attributes']['disabled'])) {

2
core/lib/Drupal/Core/Render/Element/ImageButton.php
View File

@ -85,7 +85,7 @@ class ImageButton extends Submit {
if (!empty($element['#button_type'])) {
$element['#attributes']['class'][] = 'image-button--' . $element['#button_type'];
}
// @todo Various JavaScript depends on this button class.
$element['#attributes']['class'][] = 'js-form-submit';
$element['#attributes']['class'][] = 'form-submit';
if (!empty($element['#attributes']['disabled'])) {

4
core/misc/states.js
View File

@ -513,7 +513,7 @@
if (e.trigger) {
$(e.target)
.prop('disabled', e.value)
.closest('.form-item, .form-submit, .form-wrapper').toggleClass('form-disabled', e.value)
.closest('.form-item, .js-form-submit, .form-wrapper').toggleClass('form-disabled', e.value)
.find('select, input, textarea').prop('disabled', e.value);
// Note: WebKit nightlies don't reflect that change correctly.
@ -538,7 +538,7 @@
$(document).on('state:visible', function (e) {
if (e.trigger) {
$(e.target).closest('.form-item, .form-submit, .form-wrapper').toggle(e.value);
$(e.target).closest('.form-item, .js-form-submit, .form-wrapper').toggle(e.value);
}
});

10
core/modules/file/file.js
View File

@ -67,13 +67,13 @@
Drupal.behaviors.fileButtons = {
attach: function (context) {
var $context = $(context);
$context.find('.form-submit').on('mousedown', Drupal.file.disableFields);
$context.find('.form-managed-file .form-submit').on('mousedown', Drupal.file.progressBar);
$context.find('.js-form-submit').on('mousedown', Drupal.file.disableFields);
$context.find('.form-managed-file .js-form-submit').on('mousedown', Drupal.file.progressBar);
},
detach: function (context) {
var $context = $(context);
$context.find('.form-submit').off('mousedown', Drupal.file.disableFields);
$context.find('.form-managed-file .form-submit').off('mousedown', Drupal.file.progressBar);
$context.find('.js-form-submit').off('mousedown', Drupal.file.disableFields);
$context.find('.form-managed-file .js-form-submit').off('mousedown', Drupal.file.progressBar);
}
};
@ -128,7 +128,7 @@
* Trigger the upload_button mouse event to auto-upload as a managed file.
*/
triggerUploadButton: function (event) {
$(event.target).closest('.form-managed-file').find('.form-submit').trigger('mousedown');
$(event.target).closest('.form-managed-file').find('.js-form-submit').trigger('mousedown');
},
/**
* Prevent file uploads when using buttons not intended to upload.