From d805ed7b09ed2508ad98ee77459a67c93daeb01c Mon Sep 17 00:00:00 2001 From: Alex Pott Date: Wed, 1 Oct 2014 17:50:23 +0200 Subject: [PATCH] Issue #2268467 by fago: Document foreseeable changes to conditions and action APIs. --- .../Context/ContextDefinitionInterface.php | 3 +++ core/lib/Drupal/Core/Action/ActionInterface.php | 16 ++++++++++++++++ .../Drupal/Core/Condition/ConditionInterface.php | 11 +++++++++++ 3 files changed, 30 insertions(+) diff --git a/core/lib/Drupal/Component/Plugin/Context/ContextDefinitionInterface.php b/core/lib/Drupal/Component/Plugin/Context/ContextDefinitionInterface.php index 3d2337bcd458..316be6f46049 100644 --- a/core/lib/Drupal/Component/Plugin/Context/ContextDefinitionInterface.php +++ b/core/lib/Drupal/Component/Plugin/Context/ContextDefinitionInterface.php @@ -9,6 +9,9 @@ namespace Drupal\Component\Plugin\Context; /** * Interface for context definitions. + * + * WARNING: This interface is going to receive some additions as part of + * https://www.drupal.org/node/2346999. */ interface ContextDefinitionInterface { diff --git a/core/lib/Drupal/Core/Action/ActionInterface.php b/core/lib/Drupal/Core/Action/ActionInterface.php index 4147cea8d5ca..a500f102d4ed 100644 --- a/core/lib/Drupal/Core/Action/ActionInterface.php +++ b/core/lib/Drupal/Core/Action/ActionInterface.php @@ -13,6 +13,22 @@ use Drupal\Core\Executable\ExecutableInterface; /** * Provides an interface for an Action plugin. * + * WARNING: The action API is going to receive some additions before release. + * The following additions are likely to happen: + * - The way configuration is handled and configuration forms are built is + * likely to change in order for the plugin to be of use for Rules. + * - Actions are going to become context-aware in + * https://drupal.org/node/2011038, what will deprecated the 'type' + * annotation. + * - Instead of action implementations saving entities, support for marking + * required context as to be saved by the execution manager will be added as + * part of https://www.drupal.org/node/2347017. + * - Actions will receive a data processing API that allows for token + * replacements to happen outside of the action plugin implementations, + * see https://www.drupal.org/node/2347023. + * - Actions will have to implement access control for checking who is allowed + * to configure or perform the action at https://www.drupal.org/node/2172017. + * * @see \Drupal\Core\Annotation\Action * @see \Drupal\Core\Action\ActionManager * @see \Drupal\Core\Action\ActionBase diff --git a/core/lib/Drupal/Core/Condition/ConditionInterface.php b/core/lib/Drupal/Core/Condition/ConditionInterface.php index fb23fe27e200..40c36d3cd722 100644 --- a/core/lib/Drupal/Core/Condition/ConditionInterface.php +++ b/core/lib/Drupal/Core/Condition/ConditionInterface.php @@ -28,6 +28,17 @@ use Drupal\Core\Plugin\PluginFormInterface; * @todo Replace the dependency on \Drupal\Core\Form\FormInterface with a new * interface from https://drupal.org/node/2006248. * + * WARNING: The condition API is going to receive some additions before release. + * The following additions are likely to happen: + * - The way configuration is handled and configuration forms are built is + * likely to change in order for the plugin to be of use for Rules. + * - Condition will receive a data processing API that allows for token + * replacements to happen outside of the plugin implementations, + * see https://www.drupal.org/node/2347023. + * - Conditions will have to implement access control for checking who is + * allowed to configure or perform the action at + * https://www.drupal.org/node/2172017. + * * @see \Drupal\Core\TypedData\TypedDataManager::create() * @see \Drupal\Core\Executable\ExecutableInterface * @see \Drupal\Core\Condition\ConditionManager