From d678245f37b307b2915ff84152e5e4cfd5bf220f Mon Sep 17 00:00:00 2001 From: xjm Date: Mon, 26 Oct 2020 12:54:47 -0500 Subject: [PATCH] Issue #3177557 by alexpott, andypost, dawehner: \Drupal\error_test\Controller\ErrorTestController::generateWarnings() notice is not a notice in PHP 8 --- .../modules/error_test/src/Controller/ErrorTestController.php | 4 ++-- .../system/tests/src/Functional/System/ErrorHandlerTest.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php b/core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php index e8adb63c5b74..908535c1c7c8 100644 --- a/core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php +++ b/core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php @@ -44,8 +44,8 @@ class ErrorTestController extends ControllerBase { // Tell Drupal error reporter to send errors to Simpletest or not. define('SIMPLETEST_COLLECT_ERRORS', $collect_errors); // This will generate a notice. - $bananas = []; - $monkey_love = $bananas[1]; + $notice = new \stdClass(); + $notice == 1 ? 1 : 0; // This will generate a warning. $obj = new \stdClass(); $obj->p =& $obj; diff --git a/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php b/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php index 74ec38cd62a8..ac76bfe53860 100644 --- a/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php +++ b/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php @@ -31,7 +31,7 @@ class ErrorHandlerTest extends BrowserTestBase { $config = $this->config('system.logging'); $error_notice = [ '%type' => 'Notice', - '@message' => 'Undefined offset: 1', + '@message' => 'Object of class stdClass could not be converted to int', '%function' => 'Drupal\error_test\Controller\ErrorTestController->generateWarnings()', '%file' => drupal_get_path('module', 'error_test') . '/error_test.module', ];