Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3441844 by catch, nod_: Set budgets rather than exact numbers of asset size assertions

merge-requests/7600/head
Alex Pott 2024-04-18 20:42:29 +01:00
parent 438245fc56
commit d250958497
No known key found for this signature in database
GPG Key ID: BDA67E7EE836E5CE
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/profiles/demo_umami/tests/src/FunctionalJavascript/AssetAggregationAcrossPagesTest.php
View File

@ -25,9 +25,9 @@ class AssetAggregationAcrossPagesTest extends PerformanceTestBase {
public function testFrontAndRecipesPages() { public function testFrontAndRecipesPages() {
$performance_data = $this->doRequests(); $performance_data = $this->doRequests();
$this->assertSame(4, $performance_data->getStylesheetCount()); $this->assertSame(4, $performance_data->getStylesheetCount());
$this->assertSame(82347, $performance_data->getStylesheetBytes()); $this->assertLessThan(82500, $performance_data->getStylesheetBytes());
$this->assertSame(2, $performance_data->getScriptCount()); $this->assertSame(2, $performance_data->getScriptCount());
$this->assertSame(14134, $performance_data->getScriptBytes()); $this->assertLessThan(14500, $performance_data->getScriptBytes());
} }
/** /**
@ -39,9 +39,9 @@ class AssetAggregationAcrossPagesTest extends PerformanceTestBase {
$this->rebuildAll(); $this->rebuildAll();
$performance_data = $this->doRequests(); $performance_data = $this->doRequests();
$this->assertSame(4, $performance_data->getStylesheetCount()); $this->assertSame(4, $performance_data->getStylesheetCount());
$this->assertSame(89167, $performance_data->getStylesheetBytes()); $this->assertLessThan(89500, $performance_data->getStylesheetBytes());
$this->assertSame(2, $performance_data->getScriptCount()); $this->assertSame(2, $performance_data->getScriptCount());
$this->assertSame(264696, $performance_data->getScriptBytes()); $this->assertLessThan(265000, $performance_data->getScriptBytes());
} }
/** /**

4
core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryFrontPagePerformanceTest.php
View File

@ -65,9 +65,9 @@ class OpenTelemetryFrontPagePerformanceTest extends PerformanceTestBase {
$this->assertSame(1, $performance_data->getCacheTagIsValidCount()); $this->assertSame(1, $performance_data->getCacheTagIsValidCount());
$this->assertSame(0, $performance_data->getCacheTagInvalidationCount()); $this->assertSame(0, $performance_data->getCacheTagInvalidationCount());
$this->assertSame(1, $performance_data->getScriptCount()); $this->assertSame(1, $performance_data->getScriptCount());
$this->assertSame(7067, $performance_data->getScriptBytes()); $this->assertLessThan(7500, $performance_data->getScriptBytes());
$this->assertSame(2, $performance_data->getStylesheetCount()); $this->assertSame(2, $performance_data->getStylesheetCount());
$this->assertSame(41548, $performance_data->getStylesheetBytes()); $this->assertLessThan(42000, $performance_data->getStylesheetBytes());
} }
/** /**

2
core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php
View File

@ -69,7 +69,7 @@ class StandardPerformanceTest extends PerformanceTestBase {
}, 'standardFrontPage'); }, 'standardFrontPage');
$this->assertNoJavaScript($performance_data); $this->assertNoJavaScript($performance_data);
$this->assertSame(1, $performance_data->getStylesheetCount()); $this->assertSame(1, $performance_data->getStylesheetCount());
$this->assertSame(3491, $performance_data->getStylesheetBytes()); $this->assertLessThan(3500, $performance_data->getStylesheetBytes());
$expected_queries = [ $expected_queries = [
'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/node" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC', 'SELECT "base_table"."id" AS "id", "base_table"."path" AS "path", "base_table"."alias" AS "alias", "base_table"."langcode" AS "langcode" FROM "path_alias" "base_table" WHERE ("base_table"."status" = 1) AND ("base_table"."alias" LIKE "/node" ESCAPE ' . "'\\\\'" . ') AND ("base_table"."langcode" IN ("en", "und")) ORDER BY "base_table"."langcode" ASC, "base_table"."id" DESC',