Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2321515 by dawehner: Fixed Updating links loses fragments.

8.0.x
webchick 2014-08-25 23:03:43 -07:00
parent 0d86fa90bf
commit cdebbfb7bf
2 changed files with 24 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/modules/menu_link_content/src/Form/MenuLinkContentForm.php
View File

@ -260,6 +260,8 @@ class MenuLinkContentForm extends ContentEntityForm implements MenuLinkFormInter
// which need a replacement since it is deprecated. // which need a replacement since it is deprecated.
// https://www.drupal.org/node/2307061 // https://www.drupal.org/node/2307061
$default_value = $url->getInternalPath(); $default_value = $url->getInternalPath();
}
// @todo Add a helper method to Url to render just the query string and // @todo Add a helper method to Url to render just the query string and
// fragment. https://www.drupal.org/node/2305013 // fragment. https://www.drupal.org/node/2305013
$options = $url->getOptions(); $options = $url->getOptions();
@ -269,7 +271,7 @@ class MenuLinkContentForm extends ContentEntityForm implements MenuLinkFormInter
if (isset($options['fragment']) && $options['fragment'] !== '') { if (isset($options['fragment']) && $options['fragment'] !== '') {
$default_value .= '#' . $options['fragment']; $default_value .= '#' . $options['fragment'];
} }
}
$form['url'] = array( $form['url'] = array(
'#title' => $this->t('Link path'), '#title' => $this->t('Link path'),
'#type' => 'textfield', '#type' => 'textfield',

13
core/modules/menu_ui/src/Tests/MenuTest.php
View File

@ -458,6 +458,19 @@ class MenuTest extends MenuWebTestBase {
$this->drupalPostForm('admin/structure/menu/item/' . $item->id() . '/edit', array('url' => $path), t('Save')); $this->drupalPostForm('admin/structure/menu/item/' . $item->id() . '/edit', array('url' => $path), t('Save'));
$this->drupalGet('admin/structure/menu/item/' . $item->id() . '/edit'); $this->drupalGet('admin/structure/menu/item/' . $item->id() . '/edit');
$this->assertFieldByName('url', $path, 'Path no longer has query or fragment.'); $this->assertFieldByName('url', $path, 'Path no longer has query or fragment.');
// Use <front>#fragment and ensure that saving it does not loose its
// content.
$path = '<front>?arg1=value#fragment';
$item = $this->addMenuLink('', $path);
$this->drupalGet('admin/structure/menu/item/' . $item->id() . '/edit');
$this->assertFieldByName('url', $path, 'Path is found with both query and fragment.');
$this->drupalPostForm('admin/structure/menu/item/' . $item->id() . '/edit', array(), t('Save'));
$this->drupalGet('admin/structure/menu/item/' . $item->id() . '/edit');
$this->assertFieldByName('url', $path, 'Path is found with both query and fragment.');
} }
/** /**