From cc80cdf21539d401a8cd0474aef94684ae76a92e Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Mon, 15 Dec 2003 19:41:24 +0000 Subject: [PATCH] - Replaced the tables used to structure the threaded comment view by div's. Patch by Goba. --- modules/comment.module | 16 ++++------------ modules/comment/comment.module | 16 ++++------------ 2 files changed, 8 insertions(+), 24 deletions(-) diff --git a/modules/comment.module b/modules/comment.module index b11ae3a8619..de4073b889b 100644 --- a/modules/comment.module +++ b/modules/comment.module @@ -1397,31 +1397,23 @@ function theme_comment_flat_expanded($comment, $threshold) { function theme_comment_thread_min($comment, $threshold, $pid = 0) { if (comment_visible($comment, $threshold)) { - $output = "
depth * 25) ."\">
\n"; + $output = "
depth * 25) ."px;\">\n"; $output .= theme("comment_view", $comment, "", 0); - $output .= "
\n"; + $output .= "\n"; } return $output; } function theme_comment_thread_max($comment, $threshold, $level = 0) { - /* - ** We had quite a few browser specific issues: expanded comments below - ** the top level got truncated on the right hand side. A range of - ** solutions have been proposed and tried but either the right margins of - ** the comments didn't line up well, or the heavily nested tables made - ** for slow rendering and cluttered HTML. This is the best work-around - ** in terms of speed and size. - */ $output = ""; if ($comment->depth) { - $output .= "
depth * 25) ."\"> \n"; + $output .= "
depth * 25) ."px;\">\n"; } $output .= theme("comment_view", $comment, comment_links($comment, 0), comment_visible($comment, $threshold)); if ($comment->depth) { - $output .= "
\n"; + $output .= "\n"; } return $output; } diff --git a/modules/comment/comment.module b/modules/comment/comment.module index b11ae3a8619..de4073b889b 100644 --- a/modules/comment/comment.module +++ b/modules/comment/comment.module @@ -1397,31 +1397,23 @@ function theme_comment_flat_expanded($comment, $threshold) { function theme_comment_thread_min($comment, $threshold, $pid = 0) { if (comment_visible($comment, $threshold)) { - $output = "
depth * 25) ."\">
\n"; + $output = "
depth * 25) ."px;\">\n"; $output .= theme("comment_view", $comment, "", 0); - $output .= "
\n"; + $output .= "\n"; } return $output; } function theme_comment_thread_max($comment, $threshold, $level = 0) { - /* - ** We had quite a few browser specific issues: expanded comments below - ** the top level got truncated on the right hand side. A range of - ** solutions have been proposed and tried but either the right margins of - ** the comments didn't line up well, or the heavily nested tables made - ** for slow rendering and cluttered HTML. This is the best work-around - ** in terms of speed and size. - */ $output = ""; if ($comment->depth) { - $output .= "
depth * 25) ."\"> \n"; + $output .= "
depth * 25) ."px;\">\n"; } $output .= theme("comment_view", $comment, comment_links($comment, 0), comment_visible($comment, $threshold)); if ($comment->depth) { - $output .= "
\n"; + $output .= "\n"; } return $output; }