From cb0ad5b16b1500986ef91669adcda4b05fa7a429 Mon Sep 17 00:00:00 2001 From: catch Date: Tue, 1 Sep 2020 21:17:37 +0100 Subject: [PATCH] Issue #3165588 by longwave, mondrake: Add a check to ensure $modules property is always protected --- core/tests/Drupal/Tests/Listeners/DrupalListener.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/tests/Drupal/Tests/Listeners/DrupalListener.php b/core/tests/Drupal/Tests/Listeners/DrupalListener.php index ccff1d9f4170..ab02b79a2e86 100644 --- a/core/tests/Drupal/Tests/Listeners/DrupalListener.php +++ b/core/tests/Drupal/Tests/Listeners/DrupalListener.php @@ -96,6 +96,10 @@ class DrupalListener implements TestListener { } } } + // Check for incorrect visibility of the $modules property. + if ($class->hasProperty('modules') && !$class->getProperty('modules')->isProtected()) { + @trigger_error('The ' . get_class($test) . '::$modules property must be declared protected. See https://www.drupal.org/node/2909426', E_USER_DEPRECATED); + } } /**