Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2063671 by kim.pepper, ParisLiakos, LinL: Use the aggregator category storage in AggregatorCategorizeFormBase.

8.0.x
Nathaniel Catchpole 2013-10-16 12:15:13 +01:00
parent dd39df9d3f
commit c8c891c920
3 changed files with 65 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
core/modules/aggregator/lib/Drupal/aggregator/CategoryStorageController.php
View File

@ -98,4 +98,31 @@ class CategoryStorageController implements CategoryStorageControllerInterface {
return (empty($rows));
}
/**
* {@inheritdoc}
*/
public function loadByItem($item_id) {
return $this->database->query('SELECT c.cid, c.title, ci.iid FROM {aggregator_category} c LEFT JOIN {aggregator_category_item} ci ON c.cid = ci.cid AND ci.iid = :iid', array(':iid' => $item_id));
}
/**
* {@inheritdoc}
*/
public function updateItem($iid, array $cids) {
// Remove all existing category items.
$this->database->delete('aggregator_category_item')
->condition('iid', $iid)
->execute();
// Insert new category items.
if (!empty($cids)) {
$insert = $this->database->insert('aggregator_category_item')
->fields(array('iid', 'cid'));
foreach ($cids as $cid) {
$insert->values(array('iid' => $iid, 'cid' => $cid));
}
$insert->execute();
}
}
}

21
core/modules/aggregator/lib/Drupal/aggregator/CategoryStorageControllerInterface.php
View File

@ -66,5 +66,26 @@ interface CategoryStorageControllerInterface {
*/
public function isUnique($title, $cid = NULL);
/**
* Loads aggregator categories for an aggregator item.
*
* @param int $item_id
* The aggregator item ID.
*
* @return array
* An array of objects containing item ID, category ID and title.
*/
public function loadByItem($item_id);
/**
* Updates the categories for an aggregator item.
*
* @param int $iid
* The aggregator item ID.
* @param array $cids
* The category IDs.
*/
public function updateItem($iid, array $cids);
}

51
core/modules/aggregator/lib/Drupal/aggregator/Form/AggregatorCategorizeFormBase.php
View File

@ -7,10 +7,10 @@
namespace Drupal\aggregator\Form;
use Drupal\aggregator\CategoryStorageControllerInterface;
use Drupal\aggregator\FeedInterface;
use Drupal\aggregator\ItemStorageControllerInterface;
use Drupal\Component\Utility\String;
use Drupal\Core\Database\Connection;
use Drupal\Core\Entity\EntityRenderControllerInterface;
use Drupal\Core\Form\FormBase;
use Symfony\Component\DependencyInjection\ContainerInterface;
@ -34,13 +34,6 @@ abstract class AggregatorCategorizeFormBase extends FormBase {
*/
protected $config;
/**
* The database connection.
*
* @var \Drupal\Core\Database\Connection;
*/
protected $database;
/**
* The aggregator item storage controller.
*
@ -48,6 +41,13 @@ abstract class AggregatorCategorizeFormBase extends FormBase {
*/
protected $aggregatorItemStorage;
/**
* The aggregator category storage controller.
*
* @var \Drupal\aggregator\CategoryStorageControllerInterface
*/
protected $categoryStorage;
/**
* The feed to use.
*
@ -60,16 +60,16 @@ abstract class AggregatorCategorizeFormBase extends FormBase {
*
* @param \Drupal\Core\Entity\EntityRenderControllerInterface $aggregator_item_renderer
* The item render controller.
* @param \Drupal\Core\Database\Connection $database
* The database connection.
* @param \Drupal\aggregator\ItemStorageControllerInterface $aggregator_item_storage
* The aggregator item storage controller.
* @param \Drupal\aggregator\CategoryStorageControllerInterface $category_storage
* The category storage controller.
*/
public function __construct(EntityRenderControllerInterface $aggregator_item_renderer, Connection $database, ItemStorageControllerInterface $aggregator_item_storage) {
public function __construct(EntityRenderControllerInterface $aggregator_item_renderer, ItemStorageControllerInterface $aggregator_item_storage, CategoryStorageControllerInterface $category_storage) {
$this->aggregatorItemRenderer = $aggregator_item_renderer;
$this->database = $database;
$this->config = $this->config('aggregator.settings');
$this->aggregatorItemStorage = $aggregator_item_storage;
$this->categoryStorage = $category_storage;
}
/**
@ -78,8 +78,8 @@ abstract class AggregatorCategorizeFormBase extends FormBase {
public static function create(ContainerInterface $container) {
return new static(
$container->get('plugin.manager.entity')->getRenderController('aggregator_item'),
$container->get('database'),
$container->get('plugin.manager.entity')->getStorageController('aggregator_item')
$container->get('plugin.manager.entity')->getStorageController('aggregator_item'),
$container->get('aggregator.category.storage')
);
}
@ -100,7 +100,7 @@ abstract class AggregatorCategorizeFormBase extends FormBase {
);
if ($items && ($form_items = $this->aggregatorItemRenderer->viewMultiple($items, 'default'))) {
foreach (element_children($form_items) as $iid) {
$categories_result = $this->database->query('SELECT c.cid, c.title, ci.iid FROM {aggregator_category} c LEFT JOIN {aggregator_category_item} ci ON c.cid = ci.cid AND ci.iid = :iid', array(':iid' => $iid));
$categories_result = $this->categoryStorage->loadByItem($iid);
$selected = array();
foreach ($categories_result as $category) {
@ -140,25 +140,8 @@ abstract class AggregatorCategorizeFormBase extends FormBase {
*/
public function submitForm(array &$form, array &$form_state) {
if (!empty($form_state['values']['categories'])) {
foreach ($form_state['values']['categories'] as $iid => $selection) {
$this->database->delete('aggregator_category_item')
->condition('iid', $iid)
->execute();
$insert = $this->database->insert('aggregator_category_item')
->fields(array('iid', 'cid'));
$has_values = FALSE;
foreach ($selection as $cid) {
if ($cid && $iid) {
$has_values = TRUE;
$insert->values(array(
'iid' => $iid,
'cid' => $cid,
));
}
}
if ($has_values) {
$insert->execute();
}
foreach ($form_state['values']['categories'] as $iid => $cids) {
$this->categoryStorage->updateItem($iid, $cids);
}
}
drupal_set_message($this->t('The categories have been saved.'));