Issue #3369912 by andypost, quietone, Spokje: Final steps to deprecate Actions UI (action) module

core/modules/action/action.info.yml

@@ -3,4 +3,6 @@ type: module
 description: 'Allows configuration of tasks to be executed in response to events.'
 package: Core
 version: VERSION
+lifecycle: deprecated
+lifecycle_link: https://www.drupal.org/node/3223395#s-action
 configure: entity.action.collection

core/modules/action/tests/src/Functional/ActionListTest.php

@@ -10,6 +10,7 @@ use Drupal\Tests\BrowserTestBase;
  * Test behaviors when visiting the action listing page.
  *
  * @group action
+ * @group legacy
  */
 class ActionListTest extends BrowserTestBase {
 

core/modules/action/tests/src/Functional/ActionUninstallTest.php

@@ -10,6 +10,7 @@ use Drupal\Tests\BrowserTestBase;
  * Tests that uninstalling Actions UI does not remove other modules' actions.
  *
  * @group action
+ * @group legacy
  * @see \Drupal\views\Plugin\views\field\BulkForm
  * @see \Drupal\user\Plugin\Action\BlockUser
  */

core/modules/action/tests/src/Functional/ConfigurationTest.php

@@ -11,6 +11,7 @@ use Drupal\Tests\BrowserTestBase;
  * Tests complex actions configuration.
  *
  * @group action
+ * @group legacy
  */
 class ConfigurationTest extends BrowserTestBase {
 

core/modules/action/tests/src/Functional/GenericTest.php

@@ -10,5 +10,6 @@ use Drupal\Tests\system\Functional\Module\GenericModuleTestBase;
  * Generic module test for action.
  *
  * @group action
+ * @group legacy
  */
 class GenericTest extends GenericModuleTestBase {}

core/modules/action/tests/src/Functional/Jsonapi/ActionTest.php

@@ -14,6 +14,7 @@ use Drupal\user\RoleInterface;
  *
  * @group action
  * @group #slow
+ * @group legacy
  */
 class ActionTest extends ConfigEntityResourceTestBase {
 

core/modules/action/tests/src/Functional/Node/NodeActionsConfigurationTest.php

@@ -13,6 +13,7 @@ use Drupal\user\Entity\User;
  * Tests configuration of actions provided by the Node module.
  *
  * @group action
+ * @group legacy
  */
 class NodeActionsConfigurationTest extends BrowserTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionJsonAnonTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\rest\Functional\AnonResourceTestTrait;
 
 /**
  * @group action
+ * @group legacy
  */
 class ActionJsonAnonTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionJsonBasicAuthTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\rest\Functional\BasicAuthResourceTestTrait;
 
 /**
  * @group action
+ * @group legacy
  */
 class ActionJsonBasicAuthTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionJsonCookieTest.php

@@ -8,6 +8,7 @@ use Drupal\Tests\rest\Functional\CookieResourceTestTrait;
 
 /**
  * @group action
+ * @group legacy
  */
 class ActionJsonCookieTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionXmlAnonTest.php

@@ -9,6 +9,7 @@ use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrai
 
 /**
  * @group action
+ * @group legacy
  */
 class ActionXmlAnonTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionXmlBasicAuthTest.php

@@ -9,6 +9,7 @@ use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrai
 
 /**
  * @group action
+ * @group legacy
  */
 class ActionXmlBasicAuthTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/Functional/Rest/ActionXmlCookieTest.php

@@ -9,6 +9,7 @@ use Drupal\Tests\rest\Functional\EntityResource\XmlEntityNormalizationQuirksTrai
 
 /**
  * @group action
+ * @group legacy
  */
 class ActionXmlCookieTest extends ActionResourceTestBase {
 

core/modules/action/tests/src/FunctionalJavascript/ActionFormAjaxTest.php

@@ -12,6 +12,7 @@ use Drupal\system\Entity\Action;
  * Tests action plugins using JavaScript.
  *
  * @group action
+ * @group legacy
  */
 class ActionFormAjaxTest extends WebDriverTestBase {
 

core/modules/action/tests/src/Unit/Menu/ActionLocalTasksTest.php

@@ -10,6 +10,7 @@ use Drupal\Tests\Core\Menu\LocalTaskIntegrationTestBase;
  * Tests action local tasks.
  *
  * @group action
+ * @group legacy
  */
 class ActionLocalTasksTest extends LocalTaskIntegrationTestBase {
 

core/modules/system/tests/src/Functional/Form/ModulesListFormWebTest.php

@@ -79,10 +79,10 @@ class ModulesListFormWebTest extends BrowserTestBase {
     $this->assertSession()->elementNotExists('xpath', "//div[@role='contentinfo' and h2[text()='Status message']]//a");
 
     // Enable a module that defines permissions.
-    $edit = ['modules[action][enable]' => 'action'];
+    $edit = ['modules[filter][enable]' => 'filter'];
     $this->submitForm($edit, 'Install');
-    $this->assertSession()->elementTextContains('xpath', "//div[@role='contentinfo' and h2[text()='Status message']]", 'Module Actions UI has been installed.');
-    $this->assertSession()->elementExists('xpath', "//div[@role='contentinfo' and h2[text()='Status message']]//a[contains(@href, '/admin/people/permissions/module/action')]");
+    $this->assertSession()->elementTextContains('xpath', "//div[@role='contentinfo' and h2[text()='Status message']]", 'Module Filter has been installed.');
+    $this->assertSession()->elementExists('xpath', "//div[@role='contentinfo' and h2[text()='Status message']]//a[contains(@href, '/admin/people/permissions/module/filter')]");
 
     // Enable a module that has dependencies and both define permissions.
     $edit = ['modules[content_moderation][enable]' => 'content_moderation'];

core/profiles/testing_config_overrides/testing_config_overrides.info.yml

@@ -7,7 +7,6 @@ version: VERSION
 core_version_requirement: '*'
 hidden: true
 install:
-  - action
   - language
   - entity_test_install
   - testing_config_overrides_module