Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3308432 by devkinetic, BramDriesen, Shifali Baghel, cilefen, smustgrave, quietone, bnjmnm: The link on the Image tag is redirecting to an undefined page from the node preview screen

merge-requests/8933/head
nod_ 2024-07-25 21:28:35 +02:00
parent 3dc298586a
commit bd6abf7c4d
No known key found for this signature in database
GPG Key ID: 76624892606FA197
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/modules/node/node.preview.js
View File

@ -46,7 +46,7 @@
{ {
text: Drupal.t('Leave preview'), text: Drupal.t('Leave preview'),
click() { click() {
window.top.location.href = event.target.href; window.top.location.href = event.currentTarget.href;
}, },
}, },
], ],

18
core/modules/node/tests/src/FunctionalJavascript/NodePreviewLinkTest.php
View File

@ -54,15 +54,29 @@ class NodePreviewLinkTest extends WebDriverTestBase {
$assertSession = $this->assertSession(); $assertSession = $this->assertSession();
$this->drupalGet('node/add/test'); $this->drupalGet('node/add/test');
$this->submitForm([ $this->submitForm([
'title[0][value]' => 'Test node', 'title[0][value]' => 'Test anchor link',
'body[0][value]' => '<a href="#foo">Anchor link</a><a href="/foo">Normal link</a>', 'body[0][value]' => '<a href="#foo">Anchor link</a>',
], 'Preview'); ], 'Preview');
$this->clickLink('Anchor link'); $this->clickLink('Anchor link');
$assertSession->pageTextNotContains('Leave preview?'); $assertSession->pageTextNotContains('Leave preview?');
$this->drupalGet('node/add/test');
$this->submitForm([
'title[0][value]' => 'Test normal link',
'body[0][value]' => '<a href="/foo">Normal link</a>',
], 'Preview');
$this->clickLink('Normal link'); $this->clickLink('Normal link');
$assertSession->pageTextContains('Leave preview?'); $assertSession->pageTextContains('Leave preview?');
$this->click('button:contains("Leave preview")'); $this->click('button:contains("Leave preview")');
$this->assertStringEndsWith('/foo', $this->getUrl()); $this->assertStringEndsWith('/foo', $this->getUrl());
$this->drupalGet('node/add/test');
$this->submitForm([
'title[0][value]' => 'Test child element link',
'body[0][value]' => '<a href="/foo" class="preview-child-element"><span>Child element link</span></a>',
], 'Preview');
$this->getSession()->getPage()->find('css', '.preview-child-element span')->click();
$assertSession->pageTextContains('Leave preview?');
$this->click('button:contains("Leave preview")');
$this->assertStringEndsWith('/foo', $this->getUrl());
} }
} }