Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2314443 by olli, Lendude, immaculatexavier, dawehner: Changing view name does not update page title in views ui 

(cherry picked from commit fe3be7e13e)
merge-requests/2281/head
Alex Pott 2022-05-14 15:53:09 +01:00
parent 78d9626fff
commit b72a2b1194
No known key found for this signature in database
GPG Key ID: BDA67E7EE836E5CE
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/modules/views/src/Ajax/ReplaceTitleCommand.php
View File

@ -34,7 +34,8 @@ class ReplaceTitleCommand implements CommandInterface {
public function render() {
return [
'command' => 'viewsReplaceTitle',
'selector' => $this->title,
'title' => $this->title,
'siteName' => \Drupal::config('system.site')->get('name'),
];
}

22
core/modules/views_ui/tests/src/FunctionalJavascript/DisplayTest.php
View File

@ -81,6 +81,28 @@ class DisplayTest extends WebDriverTestBase {
$this->assertNotEmpty($element);
}
/**
* Tests setting the administrative title.
*/
public function testRenameDisplayAdminName() {
$titles = ['New admin title', '</title><script>alert("alert!")</script>'];
foreach ($titles as $new_title) {
$this->drupalGet('admin/structure/views/view/test_content_ajax');
$page = $this->getSession()->getPage();
$page->findLink('Edit view name/description')->click();
$this->getSession()->executeScript("document.title = 'Initial title | " . \Drupal::config('system.site')->get('name') . "'");
$admin_name_field = $this->assertSession()
->waitForField('Administrative name');
$dialog_buttons = $page->find('css', '.ui-dialog-buttonset');
$admin_name_field->setValue($new_title);
$dialog_buttons->pressButton('Apply');
$this->assertJsCondition("document.title === '" . $new_title . " (Content) | " . \Drupal::config('system.site')->get('name') . "'");
}
}
/**
* Tests contextual links on Views page displays.
*/