Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3041842 by claudiu.cristea, Lendude: Convert ArgumentValidateTest into a kernel test

merge-requests/1119/head
Alex Pott 2019-05-05 14:27:43 +01:00
parent fd194bbed5
commit b092eaa71a
No known key found for this signature in database
GPG Key ID: 31905460D4A69276
1 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
core/modules/user/tests/src/Functional/Views/ArgumentValidateTest.php → core/modules/user/tests/src/Kernel/Views/ArgumentValidateTest.php
View File

@ -1,9 +1,12 @@
<?php
namespace Drupal\Tests\user\Functional\Views;
namespace Drupal\Tests\user\Kernel\Views;
use Drupal\Core\Form\FormState;
use Drupal\Tests\user\Traits\UserCreationTrait;
use Drupal\Tests\views\Kernel\ViewsKernelTestBase;
use Drupal\views\Plugin\views\argument\ArgumentPluginBase;
use Drupal\views\Tests\ViewTestData;
use Drupal\views\Views;
/**
@ -11,12 +14,20 @@ use Drupal\views\Views;
*
* @group user
*/
class ArgumentValidateTest extends UserTestBase {
class ArgumentValidateTest extends ViewsKernelTestBase {
use UserCreationTrait;
/**
* Views used by this test.
*
* @var array
* {@inheritdoc}
*/
public static $modules = [
'node',
'user_test_views',
];
/**
* {@inheritdoc}
*/
public static $testViews = ['test_view_argument_validate_user', 'test_view_argument_validate_username'];
@ -27,22 +38,25 @@ class ArgumentValidateTest extends UserTestBase {
*/
protected $account;
/**
* {@inheritdoc}
*/
protected function setUp($import_test_views = TRUE) {
parent::setUp($import_test_views);
$this->account = $this->drupalCreateUser();
$this->installEntitySchema('user');
$this->installEntitySchema('node');
$this->account = $this->createUser();
ViewTestData::createTestViews(get_class($this), ['user_test_views']);
}
/**
* Tests the User (ID) argument validator.
*/
public function testArgumentValidateUserUid() {
$account = $this->account;
$view = Views::getView('test_view_argument_validate_user');
$this->executeView($view);
$this->assertTrue($view->argument['null']->validateArgument($account->id()));
$this->assertTrue($view->argument['null']->validateArgument($this->account->id()));
// Reset argument validation.
$view->argument['null']->argument_validated = NULL;
// Fail for a valid numeric, but for a user that doesn't exist
@ -59,12 +73,10 @@ class ArgumentValidateTest extends UserTestBase {
* Tests the UserName argument validator.
*/
public function testArgumentValidateUserName() {
$account = $this->account;
$view = Views::getView('test_view_argument_validate_username');
$this->executeView($view);
$this->assertTrue($view->argument['null']->validateArgument($account->getAccountName()));
$this->assertTrue($view->argument['null']->validateArgument($this->account->getAccountName()));
// Reset argument validation.
$view->argument['null']->argument_validated = NULL;
// Fail for a valid string, but for a user that doesn't exist