Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #1397882 by sun: Fixed system_theme_settings_submit() does not properly clean up submitted form values.

8.0.x
Nathaniel 2012-01-10 13:22:09 +09:00
parent 49d4a62cf7
commit a74ffedcd5
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/modules/system/system.admin.inc
View File

@ -666,6 +666,11 @@ function _system_theme_settings_validate_path($path) {
* Process system_theme_settings form submissions.
*/
function system_theme_settings_submit($form, &$form_state) {
// Exclude unnecessary elements before saving.
form_state_values_clean($form_state);
$key = $form_state['values']['var'];
unset($form_state['values']['var']);
$values = $form_state['values'];
// If the user uploaded a new logo or favicon, save it to a permanent location
@ -697,10 +702,7 @@ function system_theme_settings_submit($form, &$form_state) {
if (empty($values['default_favicon']) && !empty($values['favicon_path'])) {
$values['favicon_mimetype'] = file_get_mimetype($values['favicon_path']);
}
$key = $values['var'];
// Exclude unnecessary elements before saving.
unset($values['var'], $values['submit'], $values['reset'], $values['form_id'], $values['op'], $values['form_build_id'], $values['form_token']);
variable_set($key, $values);
drupal_set_message(t('The configuration options have been saved.'));