Issue #2460677 by Wim Leers: Tests testing config_test routes should use an authenticated user

core/modules/config/src/Tests/ConfigDependencyWebTest.php

@@ -35,6 +35,8 @@ class ConfigDependencyWebTest extends WebTestBase {
    * @see \Drupal\Core\Config\Entity\ConfigDependencyDeleteFormTrait
    */
   function testConfigDependencyDeleteFormTrait() {
+    $this->drupalLogin($this->drupalCreateUser(['administer site configuration']));
+
     /** @var \Drupal\Core\Config\Entity\ConfigEntityStorage $storage */
     $storage = $this->container->get('entity.manager')->getStorage('config_test');
     // Entity1 will be deleted by the test.

core/modules/config/src/Tests/ConfigEntityFormOverrideTest.php

@@ -25,6 +25,8 @@ class ConfigEntityFormOverrideTest extends WebTestBase {
    * Tests that overrides do not affect forms or listing screens.
    */
   public function testFormsWithOverrides() {
+    $this->drupalLogin($this->drupalCreateUser(['administer site configuration']));
+
     $original_label = 'Default';
     $overridden_label = 'Overridden label';
     $edited_label = 'Edited label';

core/modules/config/src/Tests/ConfigEntityListTest.php

@@ -153,7 +153,7 @@ class ConfigEntityListTest extends WebTestBase {
    */
   function testListUI() {
     // Log in as an administrative user to access the full menu trail.
-    $this->drupalLogin($this->drupalCreateUser(array('access administration pages')));
+    $this->drupalLogin($this->drupalCreateUser(array('access administration pages', 'administer site configuration')));
 
     // Get the list callback page.
     $this->drupalGet('admin/structure/config_test');
@@ -251,6 +251,8 @@ class ConfigEntityListTest extends WebTestBase {
    * Test paging.
    */
   public function testPager() {
+    $this->drupalLogin($this->drupalCreateUser(['administer site configuration']));
+
     $storage = \Drupal::entityManager()->getListBuilder('config_test')->getStorage();
 
     // Create 51 test entities.

core/modules/config/src/Tests/ConfigEntityStatusUITest.php

@@ -28,6 +28,8 @@ class ConfigEntityStatusUITest extends WebTestBase {
    * Tests status operations.
    */
   function testCRUD() {
+    $this->drupalLogin($this->drupalCreateUser(['administer site configuration']));
+
     $id = strtolower($this->randomMachineName());
     $edit = array(
       'id' => $id,

core/modules/config/src/Tests/ConfigEntityTest.php

@@ -235,6 +235,8 @@ class ConfigEntityTest extends WebTestBase {
    * Tests CRUD operations through the UI.
    */
   function testCRUDUI() {
+    $this->drupalLogin($this->drupalCreateUser(['administer site configuration']));
+
     $id = strtolower($this->randomMachineName());
     $label1 = $this->randomMachineName();
     $label2 = $this->randomMachineName();

core/modules/config/src/Tests/SchemaConfigListenerWebTest.php

@@ -28,6 +28,8 @@ class SchemaConfigListenerWebTest extends WebTestBase {
    * Tests \Drupal\Core\Config\Testing\ConfigSchemaChecker.
    */
   public function testConfigSchemaChecker() {
+    $this->drupalLogin($this->drupalCreateUser(['administer site configuration']));
+
     // Test a non-existing schema.
     $msg = 'Expected SchemaIncompleteException thrown';
     try {

core/modules/config/tests/config_test/config_test.routing.yml

@@ -4,14 +4,14 @@ entity.config_test.collection:
     _entity_list: 'config_test'
     _title: 'Test configuration'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 config_test.entity_add:
   path: '/admin/structure/config_test/add'
   defaults:
     _entity_form: 'config_test'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 entity.config_test.edit_form:
   path: '/admin/structure/config_test/manage/{config_test}'
@@ -19,7 +19,7 @@ entity.config_test.edit_form:
     _entity_form: config_test
     _title_callback: '\Drupal\config_test\ConfigTestController::editTitle'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 entity.config_test.edit_form_config_test_no_status:
   path: '/admin/structure/config_test/manage/{config_test_no_status}'
@@ -27,7 +27,7 @@ entity.config_test.edit_form_config_test_no_status:
     _entity_form: config_test_no_status
     _title_callback: '\Drupal\config_test\ConfigTestController::editTitle'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 entity.config_test.enable:
   path: '/admin/structure/config_test/manage/{config_test}/enable'
@@ -35,7 +35,7 @@ entity.config_test.enable:
     _controller: '\Drupal\config_test\ConfigTestController::enable'
     entity_type: 'config_test'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 entity.config_test.disable:
   path: '/admin/structure/config_test/manage/{config_test}/disable'
@@ -43,25 +43,25 @@ entity.config_test.disable:
     _controller: '\Drupal\config_test\ConfigTestController::disable'
     entity_type: 'config_test'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 entity.config_test.delete_form:
   path: '/admin/structure/config_test/manage/{config_test}/delete'
   defaults:
     _entity_form: 'config_test.delete'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 entity.config_test.delete_form_config_test_no_status:
   path: '/admin/structure/config_test/manage/{config_test_no_status}/delete'
   defaults:
     _entity_form: 'config_test_no_status.delete'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'
 
 config_test.schema_listener:
   path: '/config_test/schema_listener'
   defaults:
     _controller: '\Drupal\config_test\SchemaListenerController::test'
   requirements:
-    _access: 'TRUE'
+    _permission: 'administer site configuration'