From a56f9b5c9f1adb5c36e84036289f53dcf96214e5 Mon Sep 17 00:00:00 2001
From: Dries Buytaert <dries@buytaert.net>
Date: Sat, 9 Oct 2004 15:47:44 +0000
Subject: [PATCH] - Bugfix: the filter module generated an empty <ul></ul> (=
 invalid XHTML) when no filter tips are present.

---
 modules/filter.module        | 10 ++++++----
 modules/filter/filter.module | 10 ++++++----
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/modules/filter.module b/modules/filter.module
index 770911c8783..6d47ba84ea5 100644
--- a/modules/filter.module
+++ b/modules/filter.module
@@ -734,13 +734,15 @@ function theme_filter_tips($tips, $long = false, $extra = '') {
         $output .= '<strong>'. $name .'</strong>:<br />';
       }
 
-      $output .= '<ul class="tips">';
-
+      $tips = '';
       foreach ($tiplist as $tip) {
-        $output .= '<li'. ($long ? ' id="'. $tip['id'] .'">' : '>') . $tip['tip'] . '</li>';
+        $tips .= '<li'. ($long ? ' id="'. $tip['id'] .'">' : '>') . $tip['tip'] . '</li>';
       }
 
-      $output .= '</ul>';
+      if ($tips) {
+      $output .= "<ul class=\"tips\">$tips</ul>";
+      }
+      
       if ($multiple) {
         $output .= '</li>';
       }
diff --git a/modules/filter/filter.module b/modules/filter/filter.module
index 770911c8783..6d47ba84ea5 100644
--- a/modules/filter/filter.module
+++ b/modules/filter/filter.module
@@ -734,13 +734,15 @@ function theme_filter_tips($tips, $long = false, $extra = '') {
         $output .= '<strong>'. $name .'</strong>:<br />';
       }
 
-      $output .= '<ul class="tips">';
-
+      $tips = '';
       foreach ($tiplist as $tip) {
-        $output .= '<li'. ($long ? ' id="'. $tip['id'] .'">' : '>') . $tip['tip'] . '</li>';
+        $tips .= '<li'. ($long ? ' id="'. $tip['id'] .'">' : '>') . $tip['tip'] . '</li>';
       }
 
-      $output .= '</ul>';
+      if ($tips) {
+      $output .= "<ul class=\"tips\">$tips</ul>";
+      }
+      
       if ($multiple) {
         $output .= '</li>';
       }