Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

#117748 by webchick, Pancho, Rob Loach, pwolanin: required field values were not properly trim()ed on validation

5.x
Neil Drumm 2008-08-04 04:00:24 +00:00
parent fa6bc1ebbc
commit a26a01809b
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
includes/form.inc
View File

@ -530,10 +530,11 @@ function _form_validate($elements, $form_id = NULL) {
/* Validate the current input */ /* Validate the current input */
if (!isset($elements['#validated']) || !$elements['#validated']) { if (!isset($elements['#validated']) || !$elements['#validated']) {
if (isset($elements['#needs_validation'])) { if (isset($elements['#needs_validation'])) {
// An empty textfield returns '' so we use empty(). An empty checkbox // Make sure a value is passed when the field is required.
// and a textfield could return '0' and empty('0') returns TRUE so we // A simple call to empty() will not cut it here as some fields, like
// need a special check for the '0' string. // checkboxes, can return a valid value of '0'. Instead, check the
if ($elements['#required'] && empty($elements['#value']) && $elements['#value'] !== '0') { // length if it's a string, and the item count if it's an array.
if ($elements['#required'] && (!count($elements['#value']) || (is_string($elements['#value']) && strlen(trim($elements['#value'])) == 0))) {
form_error($elements, t('!name field is required.', array('!name' => $elements['#title']))); form_error($elements, t('!name field is required.', array('!name' => $elements['#title'])));
} }