Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

#554106 by dropcube, boombatower, deekayen, and sun: Let DWTC handle HTTP location header to ensure drupal_generate_test_ua() is called. Fix for testing bot.

merge-requests/26/head
Angie Byron 2009-08-20 02:40:06 +00:00
parent 45e2d8efcf
commit a10e162270
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
modules/simpletest/drupal_web_test_case.php
View File

@ -1237,8 +1237,7 @@ class DrupalWebTestCase extends DrupalTestCase {
$curl_options = $this->additionalCurlOptions + array(
CURLOPT_COOKIEJAR => $this->cookieFile,
CURLOPT_URL => $base_url,
CURLOPT_FOLLOWLOCATION => TRUE,
CURLOPT_MAXREDIRS => 5,
CURLOPT_FOLLOWLOCATION => FALSE,
CURLOPT_RETURNTRANSFER => TRUE,
CURLOPT_SSL_VERIFYPEER => FALSE, // Required to make the tests run on https.
CURLOPT_SSL_VERIFYHOST => FALSE, // Required to make the tests run on https.
@ -1389,7 +1388,7 @@ class DrupalWebTestCase extends DrupalTestCase {
$this->refreshVariables(); // Ensure that any changes to variables in the other thread are picked up.
// Replace original page output with new output from redirected page(s).
if (($new = $this->checkForMetaRefresh())) {
if (($new = $this->checkForRedirect())) {
$out = $new;
}
$this->verbose('GET request to: ' . $path .
@ -1479,7 +1478,7 @@ class DrupalWebTestCase extends DrupalTestCase {
$this->refreshVariables();
// Replace original page output with new output from redirected page(s).
if (($new = $this->checkForMetaRefresh())) {
if (($new = $this->checkForRedirect())) {
$out = $new;
}
$this->verbose('POST request to: ' . $path .
@ -1499,14 +1498,22 @@ class DrupalWebTestCase extends DrupalTestCase {
}
/**
* Check for meta refresh tag and if found call drupalGet() recursively. This
* Check for meta refresh tag or HTTP location header.
*
* If either redirect indicators are found call drupalGet() recursively. This
* function looks for the http-equiv attribute to be set to "Refresh"
* and is case-sensitive.
*
* @return
* Either the new page content or FALSE.
*/
protected function checkForMetaRefresh() {
protected function checkForRedirect() {
foreach ($this->headers as $header) {
if (strpos($header, 'Location') !== FALSE) {
return $this->drupalGet(trim(str_replace('Location:', '', $header)));
}
}
if ($this->drupalGetContent() != '' && $this->parse()) {
$refresh = $this->xpath('//meta[@http-equiv="Refresh"]');
if (!empty($refresh)) {