Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3005969 by tstoeckler, quietone, longwave, ayushmishra206, Ante890, gbirch, zaporylie: Add support for migrate d7 telephone field

merge-requests/364/head
Alex Pott 2021-02-15 14:34:05 +00:00
parent 172e4b5acb
commit 9c5da7cb4a
No known key found for this signature in database
GPG Key ID: 31905460D4A69276
11 changed files with 306 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldFormatterSettingsTest.php
View File

@ -178,6 +178,7 @@ class MigrateFieldFormatterSettingsTest extends MigrateDrupal7TestBase {
$this->assertComponent('node.test_content_type.default', 'field_node_entityreference', 'entity_reference_label', 'above', 15);
$this->assertComponent('node.test_content_type.default', 'field_user_entityreference', 'entity_reference_label', 'above', 16);
$this->assertComponent('node.test_content_type.default', 'field_term_entityreference', 'entity_reference_label', 'above', 17);
$this->assertComponent('node.test_content_type.default', 'field_telephone', 'telephone_link', 'above', 21);
$this->assertComponentNotExists('node.test_content_type.default', 'field_term_reference');
$this->assertComponentNotExists('node.test_content_type.default', 'field_text');

1
core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php
View File

@ -130,6 +130,7 @@ class MigrateFieldInstanceTest extends MigrateDrupal7TestBase {
$this->assertEntity('node.test_content_type.field_long_text', 'Long text', 'text_with_summary', FALSE, FALSE);
$this->assertEntity('node.test_content_type.field_term_reference', 'Term Reference', 'entity_reference', FALSE, FALSE);
$this->assertEntity('node.test_content_type.field_text', 'Text', 'string', FALSE, FALSE);
$this->assertEntity('node.test_content_type.field_telephone', 'Telephone', 'telephone', FALSE, FALSE);
$this->assertEntity('comment.comment_node_test_content_type.field_integer', 'Integer', 'integer', FALSE, TRUE);
$this->assertEntity('comment.comment_node_a_thirty_two_char.comment_body', 'Comment', 'text_long', TRUE, FALSE);
$this->assertEntity('user.user.field_file', 'File', 'file', FALSE, FALSE);

1
core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceWidgetSettingsTest.php
View File

@ -128,6 +128,7 @@ class MigrateFieldInstanceWidgetSettingsTest extends MigrateDrupal7TestBase {
$this->assertComponent('node.test_content_type.default', 'field_text', 'string_textfield', 15);
$this->assertComponent('node.test_content_type.default', 'field_text_list', 'options_select', 11);
$this->assertComponent('node.test_content_type.default', 'field_float_list', 'options_select', 20);
$this->assertComponent('node.test_content_type.default', 'field_telephone', 'telephone_default', 21);
$this->assertEntity('user.user.default', 'user', 'user');
$this->assertComponent('user.user.default', 'field_file', 'file_generic', 8);

4
core/modules/migrate/tests/src/Kernel/Plugin/MigrationProvidersExistTest.php
View File

@ -100,6 +100,10 @@ class MigrationProvidersExistTest extends MigrateDrupalTestBase {
'source_module' => 'phone',
'destination_module' => 'telephone',
],
'telephone' => [
'source_module' => 'telephone',
'destination_module' => 'telephone',
],
'link' => [
'source_module' => 'link',
'destination_module' => 'link',

251
core/modules/migrate_drupal/tests/fixtures/drupal7.php vendored
View File

@ -4572,6 +4572,21 @@ $connection->insert('field_config')
'translatable' => '0',
'deleted' => '0',
))
->values(array(
'id' => '58',
'field_name' => 'field_telephone',
'type' => 'telephone',
'module' => 'telephone',
'active' => '1',
'storage_type' => 'field_sql_storage',
'storage_module' => 'field_sql_storage',
'storage_active' => '1',
'locked' => '0',
'data' => 'a:7:{s:12:"translatable";i:0;s:12:"entity_types";a:0:{}s:8:"settings";a:1:{s:23:"entity_translation_sync";b:0;}s:7:"storage";a:5:{s:4:"type";s:17:"field_sql_storage";s:8:"settings";a:0:{}s:6:"module";s:17:"field_sql_storage";s:6:"active";s:1:"1";s:7:"details";a:1:{s:3:"sql";a:2:{s:18:"FIELD_LOAD_CURRENT";a:1:{s:26:"field_data_field_telephone";a:1:{s:5:"value";s:21:"field_telephone_value";}}s:19:"FIELD_LOAD_REVISION";a:1:{s:30:"field_revision_field_telephone";a:1:{s:5:"value";s:21:"field_telephone_value";}}}}}s:12:"foreign keys";a:0:{}s:7:"indexes";a:0:{}s:2:"id";s:2:"58";}',
'cardinality' => '1',
'translatable' => '0',
'deleted' => '0',
))
->execute();
$connection->schema()->createTable('field_config_instance', array(
'fields' => array(
@ -5405,6 +5420,15 @@ $connection->insert('field_config_instance')
'data' => 'a:7:{s:5:"label";s:14:"User Reference";s:6:"widget";a:5:{s:6:"weight";s:2:"26";s:4:"type";s:27:"user_reference_autocomplete";s:6:"module";s:14:"user_reference";s:6:"active";i:1;s:8:"settings";a:3:{s:18:"autocomplete_match";s:8:"contains";s:4:"size";s:2:"60";s:17:"autocomplete_path";s:27:"user_reference/autocomplete";}}s:8:"settings";a:2:{s:18:"user_register_form";b:0;s:23:"entity_translation_sync";b:0;}s:7:"display";a:1:{s:7:"default";a:5:{s:5:"label";s:5:"above";s:4:"type";s:22:"user_reference_default";s:8:"settings";a:0:{}s:6:"module";s:14:"user_reference";s:6:"weight";i:26;}}s:8:"required";i:0;s:11:"description";s:0:"";s:13:"default_value";N;}',
'deleted' => '0',
))
->values(array(
'id' => '90',
'field_id' => '58',
'field_name' => 'field_telephone',
'entity_type' => 'node',
'bundle' => 'test_content_type',
'data' => 'a:7:{s:5:"label";s:9:"Telephone";s:6:"widget";a:5:{s:6:"weight";s:2:"21";s:4:"type";s:17:"telephone_default";s:6:"module";s:9:"telephone";s:6:"active";i:1;s:8:"settings";a:1:{s:11:"placeholder";s:0:"";}}s:8:"settings";a:2:{s:18:"user_register_form";b:0;s:23:"entity_translation_sync";b:0;}s:7:"display";a:2:{s:7:"default";a:5:{s:5:"label";s:5:"above";s:4:"type";s:14:"telephone_link";s:6:"weight";s:2:"21";s:8:"settings";a:1:{s:5:"title";s:0:"";}s:6:"module";s:9:"telephone";}s:6:"teaser";a:5:{s:5:"label";s:5:"above";s:4:"type";s:10:"text_plain";s:6:"weight";s:1:"0";s:8:"settings";a:0:{}s:6:"module";s:4:"text";}}s:8:"required";i:0;s:11:"description";s:0:"";s:13:"default_value";N;}',
'deleted' => '0',
))
->execute();
$connection->schema()->createTable('field_data_body', array(
'fields' => array(
@ -8657,6 +8681,108 @@ $connection->insert('field_data_field_tags')
'field_tags_tid' => '17',
))
->execute();
$connection->schema()->createTable('field_data_field_telephone', array(
'fields' => array(
'entity_type' => array(
'type' => 'varchar',
'not null' => TRUE,
'length' => '128',
'default' => '',
),
'bundle' => array(
'type' => 'varchar',
'not null' => TRUE,
'length' => '128',
'default' => '',
),
'deleted' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'tiny',
'default' => '0',
),
'entity_id' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'normal',
'unsigned' => TRUE,
),
'revision_id' => array(
'type' => 'int',
'not null' => FALSE,
'size' => 'normal',
'unsigned' => TRUE,
),
'language' => array(
'type' => 'varchar',
'not null' => TRUE,
'length' => '32',
'default' => '',
),
'delta' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'normal',
'unsigned' => TRUE,
),
'field_telephone_value' => array(
'type' => 'varchar',
'not null' => FALSE,
'length' => '256',
),
),
'primary key' => array(
'entity_type',
'entity_id',
'deleted',
'delta',
'language',
),
'indexes' => array(
'entity_type' => array(
'entity_type',
),
'bundle' => array(
'bundle',
),
'deleted' => array(
'deleted',
),
'entity_id' => array(
'entity_id',
),
'revision_id' => array(
'revision_id',
),
'language' => array(
'language',
),
),
'mysql_character_set' => 'utf8',
));
$connection->insert('field_data_field_telephone')
->fields(array(
'entity_type',
'bundle',
'deleted',
'entity_id',
'revision_id',
'language',
'delta',
'field_telephone_value',
))
->values(array(
'entity_type' => 'node',
'bundle' => 'test_content_type',
'deleted' => '0',
'entity_id' => '1',
'revision_id' => '1',
'language' => 'und',
'delta' => '0',
'field_telephone_value' => '99-99-99-99',
))
->execute();
$connection->schema()->createTable('field_data_field_termplain', array(
'fields' => array(
'entity_type' => array(
@ -14959,6 +15085,109 @@ $connection->insert('field_revision_field_tags')
'field_tags_tid' => '17',
))
->execute();
$connection->schema()->createTable('field_revision_field_telephone', array(
'fields' => array(
'entity_type' => array(
'type' => 'varchar',
'not null' => TRUE,
'length' => '128',
'default' => '',
),
'bundle' => array(
'type' => 'varchar',
'not null' => TRUE,
'length' => '128',
'default' => '',
),
'deleted' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'tiny',
'default' => '0',
),
'entity_id' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'normal',
'unsigned' => TRUE,
),
'revision_id' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'normal',
'unsigned' => TRUE,
),
'language' => array(
'type' => 'varchar',
'not null' => TRUE,
'length' => '32',
'default' => '',
),
'delta' => array(
'type' => 'int',
'not null' => TRUE,
'size' => 'normal',
'unsigned' => TRUE,
),
'field_telephone_value' => array(
'type' => 'varchar',
'not null' => FALSE,
'length' => '256',
),
),
'primary key' => array(
'entity_type',
'entity_id',
'revision_id',
'deleted',
'delta',
'language',
),
'indexes' => array(
'entity_type' => array(
'entity_type',
),
'bundle' => array(
'bundle',
),
'deleted' => array(
'deleted',
),
'entity_id' => array(
'entity_id',
),
'revision_id' => array(
'revision_id',
),
'language' => array(
'language',
),
),
'mysql_character_set' => 'utf8',
));
$connection->insert('field_revision_field_telephone')
->fields(array(
'entity_type',
'bundle',
'deleted',
'entity_id',
'revision_id',
'language',
'delta',
'field_telephone_value',
))
->values(array(
'entity_type' => 'node',
'bundle' => 'test_content_type',
'deleted' => '0',
'entity_id' => '1',
'revision_id' => '1',
'language' => 'und',
'delta' => '0',
'field_telephone_value' => '99-99-99-99',
))
->execute();
$connection->schema()->createTable('field_revision_field_term_entityreference', array(
'fields' => array(
'entity_type' => array(
@ -49347,6 +49576,13 @@ $connection->insert('registry')
'module' => 'phone',
'weight' => '0',
))
->values(array(
'name' => 'MigrateTelephoneFieldHandler',
'type' => 'class',
'filename' => 'sites/all/modules/telephone/telephone.migrate.inc',
'module' => 'telephone',
'weight' => '0',
))
->values(array(
'name' => 'MigrateTranslationEntityHandler',
'type' => 'class',
@ -53232,6 +53468,10 @@ $connection->insert('registry_file')
'filename' => 'sites/all/modules/phone/tests/phone.za.test',
'hash' => 'c5491ab663972aa23ae2f917a0fc605a6136f02e1b207d3fc650ed1f251359ee',
))
->values(array(
'filename' => 'sites/all/modules/telephone/telephone.migrate.inc',
'hash' => '14561d51028bcf5b9e2f18654c3ba76eda444feb12ea6ac4e88fdbf4c1a35650',
))
->values(array(
'filename' => 'sites/all/modules/views/tests/comment/views_handler_argument_comment_user_uid.test',
'hash' => 'b8b417ef0e05806a88bd7d5e2f7dcb41339fbf5b66f39311defc9fb65476d561',
@ -56874,6 +57114,17 @@ $connection->insert('system')
'weight' => '0',
'info' => 'a:12:{s:4:"name";s:7:"Picture";s:11:"description";s:15:"Picture element";s:4:"core";s:3:"7.x";s:12:"dependencies";a:3:{i:0;s:6:"ctools";i:1;s:5:"image";i:2;s:11:"breakpoints";}s:5:"files";a:1:{i:0;s:27:"includes/PictureMapping.php";}s:9:"configure";s:26:"admin/config/media/picture";s:7:"package";s:7:"Picture";s:11:"stylesheets";a:1:{s:3:"all";a:1:{s:19:"picture_wysiwyg.css";s:45:"sites/all/modules/picture/picture_wysiwyg.css";}}s:5:"mtime";i:1544936288;s:7:"version";N;s:3:"php";s:5:"5.2.4";s:9:"bootstrap";i:0;}',
))
->values(array(
'filename' => 'sites/all/modules/telephone/telephone.module',
'name' => 'telephone',
'type' => 'module',
'owner' => '',
'status' => '1',
'bootstrap' => '0',
'schema_version' => '0',
'weight' => '0',
'info' => 'a:12:{s:4:"name";s:9:"Telephone";s:11:"description";s:43:"Defines a field type for telephone numbers.";s:7:"package";s:6:"Fields";s:4:"core";s:3:"7.x";s:12:"dependencies";a:1:{i:0;s:5:"field";}s:5:"files";a:1:{i:0;s:21:"telephone.migrate.inc";}s:7:"version";s:14:"7.x-1.0-alpha1";s:7:"project";s:9:"telephone";s:9:"datestamp";s:10:"1389736105";s:5:"mtime";i:1389736105;s:3:"php";s:5:"5.2.4";s:9:"bootstrap";i:0;}',
))
->values(array(
'filename' => 'sites/all/modules/title/tests/title_test.module',
'name' => 'title_test',

6
core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php
View File

@ -257,6 +257,10 @@ class FieldDiscoveryTest extends MigrateDrupal7TestBase {
'image_nodelink' => 'image',
'image_imagelink' => 'image',
],
'telephone' => [
'text_plain' => 'string',
'telephone_link' => 'telephone_link',
],
],
],
],
@ -309,7 +313,7 @@ class FieldDiscoveryTest extends MigrateDrupal7TestBase {
$this->assertArrayHasKey('test_content_type', $actual_fields['node']);
$this->assertCount(8, $actual_fields['node']);
$this->assertCount(8, $actual_fields['comment']);
$this->assertCount(22, $actual_fields['node']['test_content_type']);
$this->assertCount(23, $actual_fields['node']['test_content_type']);
foreach ($actual_fields as $entity_type_id => $bundles) {
foreach ($bundles as $bundle => $fields) {
foreach ($fields as $field_name => $field_info) {

1
core/modules/migrate_drupal_ui/tests/src/Functional/d7/MultilingualReviewPageTest.php
View File

@ -122,6 +122,7 @@ class MultilingualReviewPageTest extends MultilingualReviewPageTestBase {
'System',
'Taxonomy translation',
'Taxonomy',
'Telephone',
'Term Depth access',
'Test search node tags',
'Test search type',

1
core/modules/migrate_drupal_ui/tests/src/Functional/d7/NoMultilingualReviewPageTest.php
View File

@ -112,6 +112,7 @@ class NoMultilingualReviewPageTest extends NoMultilingualReviewPageTestBase {
'System',
'Taxonomy translation',
'Taxonomy',
'Telephone',
'Term Depth access',
'Test search node tags',
'Test search type',

7
core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php
View File

@ -85,8 +85,8 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
'contact_form' => 3,
'contact_message' => 0,
'editor' => 2,
'field_config' => 86,
'field_storage_config' => 65,
'field_config' => 87,
'field_storage_config' => 66,
'file' => 3,
'filter_format' => 7,
'image_style' => 7,
@ -110,7 +110,7 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
'date_format' => 11,
'entity_form_display' => 24,
'entity_form_mode' => 1,
'entity_view_display' => 36,
'entity_view_display' => 37,
'entity_view_mode' => 14,
'base_field_override' => 4,
];
@ -178,6 +178,7 @@ class Upgrade7Test extends MigrateUpgradeExecuteTestBase {
'System',
'Taxonomy translation',
'Taxonomy',
'Telephone',
'Text',
'Title',
'User',

1
core/modules/telephone/migrations/state/telephone.migrate_drupal.yml
View File

@ -1,3 +1,4 @@
finished:
7:
phone: telephone
telephone: telephone

36
core/modules/telephone/src/Plugin/migrate/field/d7/TelephoneField.php Normal file
View File

@ -0,0 +1,36 @@
<?php
namespace Drupal\telephone\Plugin\migrate\field\d7;
use Drupal\migrate_drupal\Plugin\migrate\field\FieldPluginBase;
/**
* @MigrateField(
* id = "telephone",
* core = {7},
* source_module = "telephone",
* destination_module = "telephone"
* )
*/
class TelephoneField extends FieldPluginBase {
/**
* {@inheritdoc}
*/
public function getFieldWidgetMap() {
// The widget IDs are identical in Drupal 7 and 8, so we do not need any
// mapping.
return [];
}
/**
* {@inheritdoc}
*/
public function getFieldFormatterMap() {
return [
'text_plain' => 'string',
'telephone_link' => 'telephone_link',
];
}
}