Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2247281 by sun, pwolanin: Installer checks wrong config storage to verify installation state.

8.0.x
Nathaniel Catchpole 2014-04-25 14:41:12 +01:00
parent 2e739f1855
commit 9aeaf29f0f
3 changed files with 109 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/includes/install.core.inc
View File

@ -3,6 +3,7 @@
use Drupal\Component\Utility\UrlHelper;
use Drupal\Component\Utility\Settings;
use Drupal\Core\DrupalKernel;
use Drupal\Core\Config\BootstrapConfigStorageFactory;
use Drupal\Core\Database\Database;
use Drupal\Core\Database\DatabaseExceptionWrapper;
use Drupal\Core\Database\Install\TaskException;
@ -433,10 +434,9 @@ function install_begin_request(&$install_state) {
}
}
// Ensure that the active configuration directory is empty before installation
// starts.
// Ensure that the active configuration is empty before installation starts.
if ($install_state['config_verified'] && empty($task)) {
$config = \Drupal::service('config.storage')->listAll();
$config = BootstrapConfigStorageFactory::get()->listAll();
if (!empty($config)) {
$task = NULL;
throw new AlreadyInstalledException($container->get('string_translation'));

75
core/modules/system/lib/Drupal/system/Tests/Installer/InstallerExistingDatabaseSettingsTest.php Normal file
View File

@ -0,0 +1,75 @@
<?php
/**
* @file
* Contains \Drupal\system\Tests\Installer\InstallerExistingDatabaseSettingsTest.
*/
namespace Drupal\system\Tests\Installer;
use Drupal\simpletest\InstallerTestBase;
use Drupal\Core\Database\Database;
/**
* Tests the installer to make sure existing values in settings.php appear.
*/
class InstallerExistingDatabaseSettingsTest extends InstallerTestBase {
/**
* {@inheritdoc}
*/
public static function getInfo() {
return array(
'name' => 'Installer existing database settings',
'description' => 'Tests the installer with an existing settings file with database connection info.',
'group' => 'Installer',
);
}
/**
* {@inheritdoc}
*/
protected function setUp() {
// Pre-configure database credentials in settings.php.
$connection_info = Database::getConnectionInfo();
unset($connection_info['default']['pdo']);
unset($connection_info['default']['init_commands']);
$this->settings['databases']['default'] = (object) array(
'value' => $connection_info,
'required' => TRUE,
);
parent::setUp();
}
/**
* {@inheritdoc}
*
* @todo The database settings form is not supposed to appear if settings.php
* contains a valid database connection already (but e.g. no config
* directories yet).
*/
protected function setUpSettings() {
// All database settings should be pre-configured, except password.
$values = $this->parameters['forms']['install_settings_form'];
$driver = $values['driver'];
$edit = array();
if (isset($values[$driver]['password']) && $values[$driver]['password'] !== '') {
$edit = $this->translatePostValues(array(
$driver => array(
'password' => $values[$driver]['password'],
),
));
}
$this->drupalPostForm(NULL, $edit, $this->translations['Save and continue']);
}
/**
* Verifies that installation succeeded.
*/
public function testInstaller() {
$this->assertUrl('user/1');
$this->assertResponse(200);
}
}

51
core/modules/system/lib/Drupal/system/Tests/Installer/InstallerExistingSettingsTest.php
View File

@ -2,7 +2,7 @@
/**
* @file
* Contains \Drupal\system\Tests\Installer\InstallerEmptySettingsTest.
* Contains \Drupal\system\Tests\Installer\InstallerExistingSettingsTest.
*/
namespace Drupal\system\Tests\Installer;
@ -20,17 +20,27 @@ class InstallerExistingSettingsTest extends InstallerTestBase {
*/
public static function getInfo() {
return array(
'name' => 'Installer Existing Settings Test',
'description' => 'Tests the installer with an existing settings file with database connection info.',
'name' => 'Installer existing settings',
'description' => 'Tests the installer with an existing settings file.',
'group' => 'Installer',
);
}
/**
* {@inheritdoc}
*
* Fully configures a preexisting settings.php file before invoking the
* interactive installer.
*/
protected function setUp() {
// Pre-configure database credentials in settings.php.
// Pre-configure hash salt.
// Any string is valid, so simply use the class name of this test.
$this->settings['settings']['hash_salt'] = (object) array(
'value' => __CLASS__,
'required' => TRUE,
);
// Pre-configure database credentials.
$connection_info = Database::getConnectionInfo();
unset($connection_info['default']['pdo']);
unset($connection_info['default']['init_commands']);
@ -39,29 +49,30 @@ class InstallerExistingSettingsTest extends InstallerTestBase {
'value' => $connection_info,
'required' => TRUE,
);
// Pre-configure config directories.
$this->settings['config_directories'] = array(
CONFIG_ACTIVE_DIRECTORY => (object) array(
'value' => conf_path() . '/files/config_active',
'required' => TRUE,
),
CONFIG_STAGING_DIRECTORY => (object) array(
'value' => conf_path() . '/files/config_staging',
'required' => TRUE,
),
);
mkdir($this->settings['config_directories'][CONFIG_ACTIVE_DIRECTORY]->value, 0777, TRUE);
mkdir($this->settings['config_directories'][CONFIG_STAGING_DIRECTORY]->value, 0777, TRUE);
parent::setUp();
}
/**
* {@inheritdoc}
*
* @todo The database settings form is not supposed to appear if settings.php
* contains a valid database connection already (but e.g. no config
* directories yet).
*/
protected function setUpSettings() {
// All database settings should be pre-configured, except password.
$values = $this->parameters['forms']['install_settings_form'];
$driver = $values['driver'];
$edit = array();
if (isset($values[$driver]['password']) && $values[$driver]['password'] !== '') {
$edit = $this->translatePostValues(array(
$driver => array(
'password' => $values[$driver]['password'],
),
));
}
$this->drupalPostForm(NULL, $edit, $this->translations['Save and continue']);
// This step should not appear, since settings.php is fully configured
// already.
}
/**