Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2154005 by olli: Views UI does not render preview for feeds.

8.0.x
Nathaniel Catchpole 2014-01-03 17:44:11 +00:00
parent ae12caf9ea
commit 982ca4b590
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/modules/views/lib/Drupal/views/Plugin/views/display/Feed.php
View File

@ -7,6 +7,7 @@
namespace Drupal\views\Plugin\views\display; namespace Drupal\views\Plugin\views\display;
use Drupal\Component\Utility\String;
use Drupal\views\ViewExecutable; use Drupal\views\ViewExecutable;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
@ -86,11 +87,17 @@ class Feed extends PathPluginBase {
* Overrides \Drupal\views\Plugin\views\display\PathPluginBase::preview(). * Overrides \Drupal\views\Plugin\views\display\PathPluginBase::preview().
*/ */
public function preview() { public function preview() {
$output = $this->view->render();
if (!empty($this->view->live_preview)) { if (!empty($this->view->live_preview)) {
return '<pre>' . check_plain($this->view->render()) . '</pre>'; $output = array(
'#prefix' => '<pre>',
'#markup' => String::checkPlain($output),
'#suffix' => '</pre>',
);
} }
return $this->view->render(); return $output;
} }
/** /**

15
core/modules/views_ui/lib/Drupal/views_ui/Tests/PreviewTest.php
View File

@ -77,6 +77,21 @@ class PreviewTest extends UITestBase {
$this->assertText('Test header text', 'Rendered header text found'); $this->assertText('Test header text', 'Rendered header text found');
$this->assertText('Test footer text', 'Rendered footer text found.'); $this->assertText('Test footer text', 'Rendered footer text found.');
$this->assertText('Test empty text', 'Rendered empty text found.'); $this->assertText('Test empty text', 'Rendered empty text found.');
// Test feed preview.
$view = array();
$view['label'] = $this->randomName(16);
$view['id'] = strtolower($this->randomName(16));
$view['page[create]'] = 1;
$view['page[title]'] = $this->randomName(16);
$view['page[path]'] = $this->randomName(16);
$view['page[feed]'] = 1;
$view['page[feed_properties][path]'] = $this->randomName(16);
$this->drupalPostForm('admin/structure/views/add', $view, t('Save and edit'));
$this->clickLink(t('Feed'));
$this->drupalPostForm(NULL, array(), t('Update preview'));
$result = $this->xpath('//div[@id="views-live-preview"]/pre');
$this->assertTrue(strpos($result[0], '<title>' . $view['page[title]'] . '</title>'), 'The Feed RSS preview was rendered.');
} }
/** /**