From 97ae6568e672cd4a914355e0c41b3ccce9c73b89 Mon Sep 17 00:00:00 2001
From: Dries Buytaert <dries@buytaert.net>
Date: Wed, 16 Mar 2005 19:41:12 +0000
Subject: [PATCH] - Patch #13738 by TDobes: theme system fixes:

* Fix a bug which would cause the "configure" link for styles to be broken.
* Fix a bug with using drupal_get_filename for theme engines. Although this is not called anywhere in core, we should still fix it for contrib. (i.e. themes that may want to manually invoke a theme engine to create a hybrid theme)
* Correct an inaccurate comment in theme.inc
* Populate the default primary links with an "edit primary links" link for consistency with the secondary links
* remove some unnecessary variables in the theme administration which had misleading and confusing names
* replace time-consuming foreach when rendering theme admin page with a more efficient array_key_exists
* usability: rather than completely removing the search box checkbox when search.module is disabled, simply disable it. (UI elements shouldn't appear/disappear.)
---
 includes/bootstrap.inc       |  2 +-
 includes/theme.inc           |  4 +--
 modules/system.module        | 55 +++++++++++++++---------------------
 modules/system/system.module | 55 +++++++++++++++---------------------
 4 files changed, 49 insertions(+), 67 deletions(-)

diff --git a/includes/bootstrap.inc b/includes/bootstrap.inc
index 9c878133152..b60ae23c9b3 100644
--- a/includes/bootstrap.inc
+++ b/includes/bootstrap.inc
@@ -99,7 +99,7 @@ function drupal_get_filename($type, $name, $filename = NULL) {
   else {
     $config = conf_init();
     $dir = (($type == 'theme_engine') ? 'themes/engines' : "${type}s");
-    $file = "$name.$type";
+    $file = (($type == 'theme_engine') ? "$name.engine" : "$name.$type");
 
     foreach (array("$config/$dir/$file", "$config/$dir/$name/$file", "$dir/$file", "$dir/$name/$file") as $file) {
       if (file_exists($file)) {
diff --git a/includes/theme.inc b/includes/theme.inc
index 775ed941a14..11004306ba0 100644
--- a/includes/theme.inc
+++ b/includes/theme.inc
@@ -55,7 +55,7 @@ function init_theme() {
   $theme = $user->theme && $themes[$user->theme]->status ? $user->theme : variable_get('theme_default', 'bluemarine');
 
   // Allow modules to override the present theme... only select custom theme
-  // if it is available in the list of enabled themes.
+  // if it is available in the list of installed themes.
   $theme = $custom_theme && $themes[$custom_theme] ? $custom_theme : $theme;
 
   // Store the identifier for retrieving theme settings with.
@@ -221,7 +221,7 @@ function path_to_theme() {
  */
 function theme_get_settings($key = NULL) {
   $defaults = array(
-    'primary_links'                 =>  '',
+    'primary_links'                 =>  l('edit primary links', 'admin/themes/settings'),
     'secondary_links'               =>  l('edit secondary links', 'admin/themes/settings'),
     'mission'                       =>  '',
     'default_logo'                  =>  1,
diff --git a/modules/system.module b/modules/system.module
index 3583100fe29..de0f7ea33d1 100644
--- a/modules/system.module
+++ b/modules/system.module
@@ -93,8 +93,7 @@ function system_menu($may_cache) {
       'type' => MENU_DEFAULT_LOCAL_TASK, 'weight' => -1);
 
     foreach (list_themes() as $theme) {
-       $theme_path = str_replace('/', '.', $theme->name);
-       $items[] = array('path' => 'admin/themes/settings/'. $theme_path, 'title' => basename($theme->name),
+       $items[] = array('path' => 'admin/themes/settings/'. $theme->name, 'title' => $theme->name,
        'callback' => 'system_theme_settings', 'access' => $access,
        'type' => MENU_LOCAL_TASK);
     }
@@ -153,7 +152,7 @@ function system_user($type, $edit, &$user, $category = NULL) {
         $row[] = file_exists($screenshot) ? theme('image', $screenshot, t('Screenshot for %theme theme', array('%theme' => $value->name)), '', 'class="screenshot"', false) : t('no screenshot');
 
         // Information field.
-        $field = '<strong>'. basename($value->name) .'</strong>';
+        $field = '<strong>'. $value->name .'</strong>';
         $row[] = $field;
 
         // Reset to follow site default theme if user selects the site default
@@ -318,7 +317,6 @@ function system_theme_data() {
   foreach (array_keys($themes) as $key) {
     drupal_get_filename('theme', $themes[$key]->name, $themes[$key]->filename);
     drupal_load('theme', $themes[$key]->name);
-    $themes[$key]->description = dirname($themes[$key]->filename);
     $themes[$key]->owner = $themes[$key]->filename;
     $themes[$key]->prefix = $key;
   }
@@ -336,15 +334,11 @@ function system_theme_data() {
     foreach (call_user_func($engine->name . '_templates') as $template) {
       $template->template = TRUE;
       $template->name = basename(dirname($template->filename));
-      $template->basename = $template->name;
-      $template->description = dirname($template->filename);
       $template->owner = $engine->filename;
       $template->prefix = $engine->name;
       // do not double-insert templates with theme files in their directory
-      foreach ($themes as $theme) {
-        if (dirname($template->filename) == dirname($theme->filename)) {
-          continue 2;
-        }
+      if (array_key_exists($template->name, $themes)) {
+        continue;
       }
       $themes[$template->name] = $template;
     }
@@ -353,16 +347,16 @@ function system_theme_data() {
   // Find styles in each theme's directory.
   foreach ($themes as $theme) {
     foreach (file_scan_directory(dirname($theme->filename), 'style.css$') as $style) {
-      // do not double-insert themes with css files in their directory
-      if (dirname($style->filename) != dirname($theme->filename)) {
-        $style->style = TRUE;
-        $style->template = $theme->template;
-        $style->name = basename(dirname($style->filename));
-        $style->description = dirname($style->filename);
-        $style->owner = $theme->filename;
-        $style->prefix = $theme->template ? $theme->prefix : $theme->name;
-        $themes[$style->name] = $style;
+      $style->style = TRUE;
+      $style->template = $theme->template;
+      $style->name = basename(dirname($style->filename));
+      $style->owner = $theme->filename;
+      $style->prefix = $theme->template ? $theme->prefix : $theme->name;
+      // do not double-insert styles with theme files in their directory
+      if (array_key_exists($style->name, $themes)) {
+        continue;
       }
+      $themes[$style->name] = $style;
     }
   }
 
@@ -425,7 +419,7 @@ function system_theme_listing() {
   $themes = system_theme_data();
   ksort($themes);
 
-  foreach ($themes as $name => $info) {
+  foreach ($themes as $info) {
     $info->screenshot = dirname($info->filename) . '/screenshot.png';
     $row = array();
 
@@ -433,13 +427,13 @@ function system_theme_listing() {
     $row[] = file_exists($info->screenshot) ? theme('image', $info->screenshot, t('Screenshot for %theme theme', array('%theme' => $info->name)), '', 'class="screenshot"', false) : t('no screenshot');
 
     // Information field.
-    $row[] = "<strong>$info->name</strong><br /><em>$info->description</em>";
+    $row[] = "<strong>$info->name</strong><br /><em>" . dirname($info->filename) . '</em>';
 
     // enabled, default, and operations columns
     $row[] = array('data' => form_checkbox('', 'status]['. $info->name, 1, $info->status), 'align' => 'center');
-    $row[] = array('data' => form_radio('', 'theme_default', $info->name, (variable_get('theme_default', 'bluemarine') == $name) ? 1 : 0), 'align' => 'center');
+    $row[] = array('data' => form_radio('', 'theme_default', $info->name, (variable_get('theme_default', 'bluemarine') == $info->name) ? 1 : 0), 'align' => 'center');
     if (function_exists($info->prefix . '_settings') || function_exists($info->prefix . '_features')) {
-      $row[] = array('data' => l(t('configure'), 'admin/themes/settings/' . str_replace('/', '.', preg_replace('<^.*themes/(.*)$>', '$1', $info->description))), 'align' => 'center');
+      $row[] = array('data' => l(t('configure'), 'admin/themes/settings/' . $info->name), 'align' => 'center');
     }
     else {
       $row[] = '';
@@ -606,11 +600,10 @@ function system_site_settings($module = NULL) {
 /**
  * Menu callback; display theme configuration for entire site and individual themes.
  */
-function system_theme_settings() {
+function system_theme_settings($key = '') {
   system_settings_save();
 
-  // Default settings are defined in _theme_settings() in includes/theme.inc
-  $key = str_replace('.', '/', arg(3));
+  // Default settings are defined in theme_get_settings() in includes/theme.inc
   if ($key) {
     $settings = theme_get_settings($key);
     $var = str_replace('/', '_', 'theme_'. $key .'_settings');
@@ -681,15 +674,13 @@ function system_theme_settings() {
         'toggle_primary_links' => t('Primary links'),
         'toggle_secondary_links' => t('Secondary links'),
         'toggle_node_user_picture' => t('User pictures in posts'),
-        'toggle_comment_user_picture' => t('User pictures in comments'));
-  // Only offer search box if search;module is enabled.
-  if (module_exist('search')) {
-    $toggles['toggle_search'] = t('Search box');
-  }
+        'toggle_comment_user_picture' => t('User pictures in comments'),
+        'toggle_search' => t('Search box'));
 
   foreach ($toggles as $name => $title) {
     if ((!$key) || in_array($name, $features)) {
-      $group .= form_checkbox($title, "$var][$name", 1, $settings[$name]);
+      // disable search box if search.module is disabled
+      $group .= form_checkbox($title, "$var][$name", 1, $settings[$name], NULL, (!module_exist('search') && $name == 'toggle_search') ? array('disabled' => 'disabled') : NULL);
     }
   }
   if ($group) {
diff --git a/modules/system/system.module b/modules/system/system.module
index 3583100fe29..de0f7ea33d1 100644
--- a/modules/system/system.module
+++ b/modules/system/system.module
@@ -93,8 +93,7 @@ function system_menu($may_cache) {
       'type' => MENU_DEFAULT_LOCAL_TASK, 'weight' => -1);
 
     foreach (list_themes() as $theme) {
-       $theme_path = str_replace('/', '.', $theme->name);
-       $items[] = array('path' => 'admin/themes/settings/'. $theme_path, 'title' => basename($theme->name),
+       $items[] = array('path' => 'admin/themes/settings/'. $theme->name, 'title' => $theme->name,
        'callback' => 'system_theme_settings', 'access' => $access,
        'type' => MENU_LOCAL_TASK);
     }
@@ -153,7 +152,7 @@ function system_user($type, $edit, &$user, $category = NULL) {
         $row[] = file_exists($screenshot) ? theme('image', $screenshot, t('Screenshot for %theme theme', array('%theme' => $value->name)), '', 'class="screenshot"', false) : t('no screenshot');
 
         // Information field.
-        $field = '<strong>'. basename($value->name) .'</strong>';
+        $field = '<strong>'. $value->name .'</strong>';
         $row[] = $field;
 
         // Reset to follow site default theme if user selects the site default
@@ -318,7 +317,6 @@ function system_theme_data() {
   foreach (array_keys($themes) as $key) {
     drupal_get_filename('theme', $themes[$key]->name, $themes[$key]->filename);
     drupal_load('theme', $themes[$key]->name);
-    $themes[$key]->description = dirname($themes[$key]->filename);
     $themes[$key]->owner = $themes[$key]->filename;
     $themes[$key]->prefix = $key;
   }
@@ -336,15 +334,11 @@ function system_theme_data() {
     foreach (call_user_func($engine->name . '_templates') as $template) {
       $template->template = TRUE;
       $template->name = basename(dirname($template->filename));
-      $template->basename = $template->name;
-      $template->description = dirname($template->filename);
       $template->owner = $engine->filename;
       $template->prefix = $engine->name;
       // do not double-insert templates with theme files in their directory
-      foreach ($themes as $theme) {
-        if (dirname($template->filename) == dirname($theme->filename)) {
-          continue 2;
-        }
+      if (array_key_exists($template->name, $themes)) {
+        continue;
       }
       $themes[$template->name] = $template;
     }
@@ -353,16 +347,16 @@ function system_theme_data() {
   // Find styles in each theme's directory.
   foreach ($themes as $theme) {
     foreach (file_scan_directory(dirname($theme->filename), 'style.css$') as $style) {
-      // do not double-insert themes with css files in their directory
-      if (dirname($style->filename) != dirname($theme->filename)) {
-        $style->style = TRUE;
-        $style->template = $theme->template;
-        $style->name = basename(dirname($style->filename));
-        $style->description = dirname($style->filename);
-        $style->owner = $theme->filename;
-        $style->prefix = $theme->template ? $theme->prefix : $theme->name;
-        $themes[$style->name] = $style;
+      $style->style = TRUE;
+      $style->template = $theme->template;
+      $style->name = basename(dirname($style->filename));
+      $style->owner = $theme->filename;
+      $style->prefix = $theme->template ? $theme->prefix : $theme->name;
+      // do not double-insert styles with theme files in their directory
+      if (array_key_exists($style->name, $themes)) {
+        continue;
       }
+      $themes[$style->name] = $style;
     }
   }
 
@@ -425,7 +419,7 @@ function system_theme_listing() {
   $themes = system_theme_data();
   ksort($themes);
 
-  foreach ($themes as $name => $info) {
+  foreach ($themes as $info) {
     $info->screenshot = dirname($info->filename) . '/screenshot.png';
     $row = array();
 
@@ -433,13 +427,13 @@ function system_theme_listing() {
     $row[] = file_exists($info->screenshot) ? theme('image', $info->screenshot, t('Screenshot for %theme theme', array('%theme' => $info->name)), '', 'class="screenshot"', false) : t('no screenshot');
 
     // Information field.
-    $row[] = "<strong>$info->name</strong><br /><em>$info->description</em>";
+    $row[] = "<strong>$info->name</strong><br /><em>" . dirname($info->filename) . '</em>';
 
     // enabled, default, and operations columns
     $row[] = array('data' => form_checkbox('', 'status]['. $info->name, 1, $info->status), 'align' => 'center');
-    $row[] = array('data' => form_radio('', 'theme_default', $info->name, (variable_get('theme_default', 'bluemarine') == $name) ? 1 : 0), 'align' => 'center');
+    $row[] = array('data' => form_radio('', 'theme_default', $info->name, (variable_get('theme_default', 'bluemarine') == $info->name) ? 1 : 0), 'align' => 'center');
     if (function_exists($info->prefix . '_settings') || function_exists($info->prefix . '_features')) {
-      $row[] = array('data' => l(t('configure'), 'admin/themes/settings/' . str_replace('/', '.', preg_replace('<^.*themes/(.*)$>', '$1', $info->description))), 'align' => 'center');
+      $row[] = array('data' => l(t('configure'), 'admin/themes/settings/' . $info->name), 'align' => 'center');
     }
     else {
       $row[] = '';
@@ -606,11 +600,10 @@ function system_site_settings($module = NULL) {
 /**
  * Menu callback; display theme configuration for entire site and individual themes.
  */
-function system_theme_settings() {
+function system_theme_settings($key = '') {
   system_settings_save();
 
-  // Default settings are defined in _theme_settings() in includes/theme.inc
-  $key = str_replace('.', '/', arg(3));
+  // Default settings are defined in theme_get_settings() in includes/theme.inc
   if ($key) {
     $settings = theme_get_settings($key);
     $var = str_replace('/', '_', 'theme_'. $key .'_settings');
@@ -681,15 +674,13 @@ function system_theme_settings() {
         'toggle_primary_links' => t('Primary links'),
         'toggle_secondary_links' => t('Secondary links'),
         'toggle_node_user_picture' => t('User pictures in posts'),
-        'toggle_comment_user_picture' => t('User pictures in comments'));
-  // Only offer search box if search;module is enabled.
-  if (module_exist('search')) {
-    $toggles['toggle_search'] = t('Search box');
-  }
+        'toggle_comment_user_picture' => t('User pictures in comments'),
+        'toggle_search' => t('Search box'));
 
   foreach ($toggles as $name => $title) {
     if ((!$key) || in_array($name, $features)) {
-      $group .= form_checkbox($title, "$var][$name", 1, $settings[$name]);
+      // disable search box if search.module is disabled
+      $group .= form_checkbox($title, "$var][$name", 1, $settings[$name], NULL, (!module_exist('search') && $name == 'toggle_search') ? array('disabled' => 'disabled') : NULL);
     }
   }
   if ($group) {