Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #1741386 by lazysoundsystem, rasmusluckow, andypost, Lars Toomre, dcam: Removing t() from asserts in simpletests in book module.

merge-requests/26/head
David Rothstein 2012-12-27 11:17:22 -05:00
parent dfed194c63
commit 9569999cd0
1 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
modules/book/book.test
View File

@ -129,23 +129,23 @@ class BookTestCase extends DrupalWebTestCase {
// Check outline structure. // Check outline structure.
if ($nodes !== NULL) { if ($nodes !== NULL) {
$this->assertPattern($this->generateOutlinePattern($nodes), t('Node ' . $number . ' outline confirmed.')); $this->assertPattern($this->generateOutlinePattern($nodes), format_string('Node %number outline confirmed.', array('%number' => $number)));
} }
else { else {
$this->pass(t('Node ' . $number . ' doesn\'t have outline.')); $this->pass(format_string('Node %number does not have outline.', array('%number' => $number)));
} }
// Check previous, up, and next links. // Check previous, up, and next links.
if ($previous) { if ($previous) {
$this->assertRaw(l('‹ ' . $previous->title, 'node/' . $previous->nid, array('attributes' => array('class' => array('page-previous'), 'title' => t('Go to previous page')))), t('Previous page link found.')); $this->assertRaw(l('‹ ' . $previous->title, 'node/' . $previous->nid, array('attributes' => array('class' => array('page-previous'), 'title' => t('Go to previous page')))), 'Previous page link found.');
} }
if ($up) { if ($up) {
$this->assertRaw(l('up', 'node/' . $up->nid, array('attributes' => array('class' => array('page-up'), 'title' => t('Go to parent page')))), t('Up page link found.')); $this->assertRaw(l('up', 'node/' . $up->nid, array('attributes' => array('class' => array('page-up'), 'title' => t('Go to parent page')))), 'Up page link found.');
} }
if ($next) { if ($next) {
$this->assertRaw(l($next->title . ' ›', 'node/' . $next->nid, array('attributes' => array('class' => array('page-next'), 'title' => t('Go to next page')))), t('Next page link found.')); $this->assertRaw(l($next->title . ' ›', 'node/' . $next->nid, array('attributes' => array('class' => array('page-next'), 'title' => t('Go to next page')))), 'Next page link found.');
} }
// Compute the expected breadcrumb. // Compute the expected breadcrumb.
@ -163,12 +163,12 @@ class BookTestCase extends DrupalWebTestCase {
} }
// Compare expected and got breadcrumbs. // Compare expected and got breadcrumbs.
$this->assertIdentical($expected_breadcrumb, $got_breadcrumb, t('The breadcrumb is correctly displayed on the page.')); $this->assertIdentical($expected_breadcrumb, $got_breadcrumb, 'The breadcrumb is correctly displayed on the page.');
// Check printer friendly version. // Check printer friendly version.
$this->drupalGet('book/export/html/' . $node->nid); $this->drupalGet('book/export/html/' . $node->nid);
$this->assertText($node->title, t('Printer friendly title found.')); $this->assertText($node->title, 'Printer friendly title found.');
$this->assertRaw(check_markup($node->body[LANGUAGE_NONE][0]['value'], $node->body[LANGUAGE_NONE][0]['format']), t('Printer friendly body found.')); $this->assertRaw(check_markup($node->body[LANGUAGE_NONE][0]['value'], $node->body[LANGUAGE_NONE][0]['format']), 'Printer friendly body found.');
$number++; $number++;
} }
@ -216,7 +216,7 @@ class BookTestCase extends DrupalWebTestCase {
// Check to make sure the book node was created. // Check to make sure the book node was created.
$node = $this->drupalGetNodeByTitle($edit['title']); $node = $this->drupalGetNodeByTitle($edit['title']);
$this->assertNotNull(($node === FALSE ? NULL : $node), t('Book node found in database.')); $this->assertNotNull(($node === FALSE ? NULL : $node), 'Book node found in database.');
$number++; $number++;
return $node; return $node;
@ -236,28 +236,28 @@ class BookTestCase extends DrupalWebTestCase {
// Make sure each part of the book is there. // Make sure each part of the book is there.
foreach ($nodes as $node) { foreach ($nodes as $node) {
$this->assertText($node->title, t('Node title found in printer friendly version.')); $this->assertText($node->title, 'Node title found in printer friendly version.');
$this->assertRaw(check_markup($node->body[LANGUAGE_NONE][0]['value'], $node->body[LANGUAGE_NONE][0]['format']), t('Node body found in printer friendly version.')); $this->assertRaw(check_markup($node->body[LANGUAGE_NONE][0]['value'], $node->body[LANGUAGE_NONE][0]['format']), 'Node body found in printer friendly version.');
} }
// Make sure we can't export an unsupported format. // Make sure we can't export an unsupported format.
$this->drupalGet('book/export/foobar/' . $this->book->nid); $this->drupalGet('book/export/foobar/' . $this->book->nid);
$this->assertResponse('404', t('Unsupported export format returned "not found".')); $this->assertResponse('404', 'Unsupported export format returned "not found".');
// Make sure we get a 404 on a not existing book node. // Make sure we get a 404 on a not existing book node.
$this->drupalGet('book/export/html/123'); $this->drupalGet('book/export/html/123');
$this->assertResponse('404', t('Not existing book node returned "not found".')); $this->assertResponse('404', 'Not existing book node returned "not found".');
// Make sure an anonymous user cannot view printer-friendly version. // Make sure an anonymous user cannot view printer-friendly version.
$this->drupalLogout(); $this->drupalLogout();
// Load the book and verify there is no printer-friendly version link. // Load the book and verify there is no printer-friendly version link.
$this->drupalGet('node/' . $this->book->nid); $this->drupalGet('node/' . $this->book->nid);
$this->assertNoLink(t('Printer-friendly version'), t('Anonymous user is not shown link to printer-friendly version.')); $this->assertNoLink(t('Printer-friendly version'), 'Anonymous user is not shown link to printer-friendly version.');
// Try getting the URL directly, and verify it fails. // Try getting the URL directly, and verify it fails.
$this->drupalGet('book/export/html/' . $this->book->nid); $this->drupalGet('book/export/html/' . $this->book->nid);
$this->assertResponse('403', t('Anonymous user properly forbidden.')); $this->assertResponse('403', 'Anonymous user properly forbidden.');
} }
/** /**
@ -269,26 +269,26 @@ class BookTestCase extends DrupalWebTestCase {
// Set block title to confirm that the interface is available. // Set block title to confirm that the interface is available.
$block_title = $this->randomName(16); $block_title = $this->randomName(16);
$this->drupalPost('admin/structure/block/manage/book/navigation/configure', array('title' => $block_title), t('Save block')); $this->drupalPost('admin/structure/block/manage/book/navigation/configure', array('title' => $block_title), t('Save block'));
$this->assertText(t('The block configuration has been saved.'), t('Block configuration set.')); $this->assertText(t('The block configuration has been saved.'), 'Block configuration set.');
// Set the block to a region to confirm block is available. // Set the block to a region to confirm block is available.
$edit = array(); $edit = array();
$edit['blocks[book_navigation][region]'] = 'footer'; $edit['blocks[book_navigation][region]'] = 'footer';
$this->drupalPost('admin/structure/block', $edit, t('Save blocks')); $this->drupalPost('admin/structure/block', $edit, t('Save blocks'));
$this->assertText(t('The block settings have been updated.'), t('Block successfully move to footer region.')); $this->assertText(t('The block settings have been updated.'), 'Block successfully move to footer region.');
// Give anonymous users the permission 'node test view'. // Give anonymous users the permission 'node test view'.
$edit = array(); $edit = array();
$edit[DRUPAL_ANONYMOUS_RID . '[node test view]'] = TRUE; $edit[DRUPAL_ANONYMOUS_RID . '[node test view]'] = TRUE;
$this->drupalPost('admin/people/permissions/' . DRUPAL_ANONYMOUS_RID, $edit, t('Save permissions')); $this->drupalPost('admin/people/permissions/' . DRUPAL_ANONYMOUS_RID, $edit, t('Save permissions'));
$this->assertText(t('The changes have been saved.'), t("Permission 'node test view' successfully assigned to anonymous users.")); $this->assertText(t('The changes have been saved.'), "Permission 'node test view' successfully assigned to anonymous users.");
// Test correct display of the block. // Test correct display of the block.
$nodes = $this->createBook(); $nodes = $this->createBook();
$this->drupalGet('<front>'); $this->drupalGet('<front>');
$this->assertText($block_title, t('Book navigation block is displayed.')); $this->assertText($block_title, 'Book navigation block is displayed.');
$this->assertText($this->book->title, t('Link to book root (@title) is displayed.', array('@title' => $nodes[0]->title))); $this->assertText($this->book->title, format_string('Link to book root (@title) is displayed.', array('@title' => $nodes[0]->title)));
$this->assertNoText($nodes[0]->title, t('No links to individual book pages are displayed.')); $this->assertNoText($nodes[0]->title, 'No links to individual book pages are displayed.');
} }
/** /**
@ -305,19 +305,19 @@ class BookTestCase extends DrupalWebTestCase {
// Set block display to 'Show block only on book pages'. // Set block display to 'Show block only on book pages'.
$edit['book_block_mode'] = 'book pages'; $edit['book_block_mode'] = 'book pages';
$this->drupalPost('admin/structure/block/manage/book/navigation/configure', $edit, t('Save block')); $this->drupalPost('admin/structure/block/manage/book/navigation/configure', $edit, t('Save block'));
$this->assertText(t('The block configuration has been saved.'), t('Block configuration set.')); $this->assertText(t('The block configuration has been saved.'), 'Block configuration set.');
// Set the block to a region to confirm block is available. // Set the block to a region to confirm block is available.
$edit = array(); $edit = array();
$edit['blocks[book_navigation][region]'] = 'footer'; $edit['blocks[book_navigation][region]'] = 'footer';
$this->drupalPost('admin/structure/block', $edit, t('Save blocks')); $this->drupalPost('admin/structure/block', $edit, t('Save blocks'));
$this->assertText(t('The block settings have been updated.'), t('Block successfully move to footer region.')); $this->assertText(t('The block settings have been updated.'), 'Block successfully move to footer region.');
// Give anonymous users the permission 'node test view'. // Give anonymous users the permission 'node test view'.
$edit = array(); $edit = array();
$edit[DRUPAL_ANONYMOUS_RID . '[node test view]'] = TRUE; $edit[DRUPAL_ANONYMOUS_RID . '[node test view]'] = TRUE;
$this->drupalPost('admin/people/permissions/' . DRUPAL_ANONYMOUS_RID, $edit, t('Save permissions')); $this->drupalPost('admin/people/permissions/' . DRUPAL_ANONYMOUS_RID, $edit, t('Save permissions'));
$this->assertText(t('The changes have been saved.'), t('Permission \'node test view\' successfully assigned to anonymous users.')); $this->assertText(t('The changes have been saved.'), "Permission 'node test view' successfully assigned to anonymous users.");
// Create a book. // Create a book.
$this->createBook(); $this->createBook();
@ -325,12 +325,12 @@ class BookTestCase extends DrupalWebTestCase {
// Test correct display of the block to registered users. // Test correct display of the block to registered users.
$this->drupalLogin($this->web_user); $this->drupalLogin($this->web_user);
$this->drupalGet('node/' . $this->book->nid); $this->drupalGet('node/' . $this->book->nid);
$this->assertText($block_title, t('Book navigation block is displayed to registered users.')); $this->assertText($block_title, 'Book navigation block is displayed to registered users.');
$this->drupalLogout(); $this->drupalLogout();
// Test correct display of the block to anonymous users. // Test correct display of the block to anonymous users.
$this->drupalGet('node/' . $this->book->nid); $this->drupalGet('node/' . $this->book->nid);
$this->assertText($block_title, t('Book navigation block is displayed to anonymous users.')); $this->assertText($block_title, 'Book navigation block is displayed to anonymous users.');
} }
/** /**
@ -343,10 +343,10 @@ class BookTestCase extends DrupalWebTestCase {
// Test access to delete top-level and child book nodes. // Test access to delete top-level and child book nodes.
$this->drupalGet('node/' . $this->book->nid . '/outline/remove'); $this->drupalGet('node/' . $this->book->nid . '/outline/remove');
$this->assertResponse('403', t('Deleting top-level book node properly forbidden.')); $this->assertResponse('403', 'Deleting top-level book node properly forbidden.');
$this->drupalPost('node/' . $nodes[4]->nid . '/outline/remove', $edit, t('Remove')); $this->drupalPost('node/' . $nodes[4]->nid . '/outline/remove', $edit, t('Remove'));
$node4 = node_load($nodes[4]->nid, NULL, TRUE); $node4 = node_load($nodes[4]->nid, NULL, TRUE);
$this->assertTrue(empty($node4->book), t('Deleting child book node properly allowed.')); $this->assertTrue(empty($node4->book), 'Deleting child book node properly allowed.');
// Delete all child book nodes and retest top-level node deletion. // Delete all child book nodes and retest top-level node deletion.
foreach ($nodes as $node) { foreach ($nodes as $node) {
@ -355,6 +355,6 @@ class BookTestCase extends DrupalWebTestCase {
node_delete_multiple($nids); node_delete_multiple($nids);
$this->drupalPost('node/' . $this->book->nid . '/outline/remove', $edit, t('Remove')); $this->drupalPost('node/' . $this->book->nid . '/outline/remove', $edit, t('Remove'));
$node = node_load($this->book->nid, NULL, TRUE); $node = node_load($this->book->nid, NULL, TRUE);
$this->assertTrue(empty($node->book), t('Deleting childless top-level book node properly allowed.')); $this->assertTrue(empty($node->book), 'Deleting childless top-level book node properly allowed.');
} }
} }