Issue #1806916 by dawehner: Fixed editing details does not save any property.

lib/Drupal/views/Tests/UI/StorageTest.php

@@ -0,0 +1,47 @@
+<?php
+
+/**
+ * @file
+ * Definition of Drupal\views\tests\UI\StorageTest.
+ */
+
+namespace Drupal\views\Tests\UI;
+
+/**
+ * Tests the UI of storage properties of views.
+ */
+class StorageTest extends UITestBase {
+
+  public static function getInfo() {
+    return array(
+      'name' => 'Storage properties',
+      'description' => 'Tests the UI of storage properties of views.',
+      'group' => 'Views UI',
+    );
+  }
+
+  /**
+   * Tests changing human_name, description and tag.
+   *
+   * @see views_ui_edit_details_form
+   */
+  public function testDetails() {
+    $view = $this->getBasicView();
+
+    $path = "admin/structure/views/nojs/edit-details/{$view->storage->name}";
+    $edit = array(
+      'human_name' => $this->randomName(),
+      'tag' => $this->randomName(),
+      'description' => $this->randomName(30),
+    );
+
+    $this->drupalPost($path, $edit, t('Apply'));
+    $this->drupalPost(NULL, array(), t('Save'));
+    $view = views_get_view($view->storage->name);
+
+    foreach (array('human_name', 'tag', 'description') as $property) {
+      $this->assertEqual($view->storage->{$property}, $edit[$property], format_string('Make sure the property @property got probably saved.', array('@property' => $property)));
+    }
+  }
+
+}

views_ui/admin.inc

@@ -973,7 +973,7 @@ function views_ui_edit_details_form_submit($form, &$form_state) {
     // Only save values onto the view if they're actual view properties
     // (as opposed to 'op' or 'form_build_id').
     if (isset($form['details'][$key])) {
-      $view->$key = $value;
+      $view->storage->$key = $value;
     }
   }
   $form_state['#page_title'] = views_ui_edit_page_title($view);