Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #1806916 by dawehner: Fixed editing details does not save any property.

8.0.x
dereine 2012-10-10 15:12:40 -04:00 committed by Tim Plunkett
parent 3be8115033
commit 79f5da4e9f
2 changed files with 48 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
lib/Drupal/views/Tests/UI/StorageTest.php Normal file
View File

@ -0,0 +1,47 @@
<?php
/**
* @file
* Definition of Drupal\views\tests\UI\StorageTest.
*/
namespace Drupal\views\Tests\UI;
/**
* Tests the UI of storage properties of views.
*/
class StorageTest extends UITestBase {
public static function getInfo() {
return array(
'name' => 'Storage properties',
'description' => 'Tests the UI of storage properties of views.',
'group' => 'Views UI',
);
}
/**
* Tests changing human_name, description and tag.
*
* @see views_ui_edit_details_form
*/
public function testDetails() {
$view = $this->getBasicView();
$path = "admin/structure/views/nojs/edit-details/{$view->storage->name}";
$edit = array(
'human_name' => $this->randomName(),
'tag' => $this->randomName(),
'description' => $this->randomName(30),
);
$this->drupalPost($path, $edit, t('Apply'));
$this->drupalPost(NULL, array(), t('Save'));
$view = views_get_view($view->storage->name);
foreach (array('human_name', 'tag', 'description') as $property) {
$this->assertEqual($view->storage->{$property}, $edit[$property], format_string('Make sure the property @property got probably saved.', array('@property' => $property)));
}
}
}

2
views_ui/admin.inc
View File

@ -973,7 +973,7 @@ function views_ui_edit_details_form_submit($form, &$form_state) {
// Only save values onto the view if they're actual view properties
// (as opposed to 'op' or 'form_build_id').
if (isset($form['details'][$key])) {
$view->$key = $value;
$view->storage->$key = $value;
}
}
$form_state['#page_title'] = views_ui_edit_page_title($view);