Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3513317 by annmarysruthy, larowlan, wim leers: ImageItem::defaultStorageSettings() should override display_default 

(cherry picked from commit 7265831241)
merge-requests/11286/merge
Dave Long 2025-03-21 09:38:13 +00:00
parent 5e30c2592a
commit 7365716bb3
No known key found for this signature in database
GPG Key ID: ED52AE211E142771
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
core/modules/image/src/Plugin/Field/FieldType/ImageItem.php
View File

@ -72,6 +72,7 @@ class ImageItem extends FileItem {
'width' => NULL,
'height' => NULL,
],
'display_default' => TRUE,
] + parent::defaultStorageSettings();
}

29
core/modules/image/tests/src/Kernel/ImageItemTest.php
View File

@ -5,14 +5,20 @@ declare(strict_types=1);
namespace Drupal\Tests\image\Kernel;
use Drupal\Core\Database\Database;
use Drupal\Core\Entity\ContentEntityForm;
use Drupal\Core\Entity\Entity\EntityFormDisplay;
use Drupal\Core\Entity\EntityDisplayRepositoryInterface;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\Core\Field\FieldItemInterface;
use Drupal\Core\Field\FieldItemListInterface;
use Drupal\Core\Field\FieldStorageDefinitionInterface;
use Drupal\Core\Form\FormBuilderInterface;
use Drupal\Core\Form\FormState;
use Drupal\entity_test\Entity\EntityTest;
use Drupal\field\Entity\FieldConfig;
use Drupal\Tests\field\Kernel\FieldKernelTestBase;
use Drupal\field\Entity\FieldStorageConfig;
use Drupal\file\Entity\File;
use Drupal\Tests\field\Kernel\FieldKernelTestBase;
use Drupal\user\Entity\Role;
/**
@ -92,6 +98,9 @@ class ImageItemTest extends FieldKernelTestBase {
]);
$this->image->save();
$this->imageFactory = $this->container->get('image.factory');
$this->container->get(EntityDisplayRepositoryInterface::class)
->getFormDisplay('entity_test', 'entity_test')
->setComponent('image_test', ['type' => 'image_image'])->save();
}
/**
@ -198,4 +207,22 @@ class ImageItemTest extends FieldKernelTestBase {
$this->assertEmpty($entity->image_test->height);
}
/**
* Tests display_default.
*/
public function testDisplayDefaultValue(): void {
$entity = EntityTest::create([
'name' => $this->randomMachineName(),
]);
$form_object = $this->container->get(EntityTypeManagerInterface::class)->getFormObject('entity_test', 'default');
\assert($form_object instanceof ContentEntityForm);
$form_object->setEntity($entity);
$form_display = EntityFormDisplay::collectRenderDisplay($entity, 'default');
\assert($form_display instanceof EntityFormDisplay);
$form_state = new FormState();
$form_object->setFormDisplay($form_display, $form_state);
$this->container->get(FormBuilderInterface::class)->buildForm($form_object, $form_state);
self::assertEquals(1, $form_state->getValue(['image_test', 0, 'display']));
}
}