Issue #2857822 by alexpott, klausi: Fix coding standards issues introduced mostly by array syntax conversion

core/modules/book/tests/src/Unit/BookManagerTest.php

@@ -102,7 +102,7 @@ class BookManagerTest extends UnitTestCase {
       // Provides a book with an existing parent.
       [
         ['pid' => 11, 'nid' => 12],
-        ['nid' => 11, 'depth' => 1, 'p1' => 11,],
+        ['nid' => 11, 'depth' => 1, 'p1' => 11],
         ['depth' => 2, 'p1' => 11, 'p2' => 12] + $empty,
       ],
       // Provides a book with two existing parents.

core/modules/book/tests/src/Unit/Menu/BookLocalTasksTest.php

@@ -48,7 +48,7 @@ class BookLocalTasksTest extends LocalTaskIntegrationTestBase {
    */
   public function testBookNodeLocalTasks($route) {
     $this->assertLocalTasks($route, [
-      0 => ['entity.node.book_outline_form', 'entity.node.canonical', 'entity.node.edit_form', 'entity.node.delete_form', 'entity.node.version_history',],
+      0 => ['entity.node.book_outline_form', 'entity.node.canonical', 'entity.node.edit_form', 'entity.node.delete_form', 'entity.node.version_history'],
     ]);
   }
 

core/modules/ckeditor/src/Plugin/Editor/CKEditor.php

@@ -109,23 +109,23 @@ class CKEditor extends EditorBase implements ContainerFactoryPluginInterface {
           [
             [
               'name' => $this->t('Formatting'),
-              'items' => ['Bold', 'Italic',],
+              'items' => ['Bold', 'Italic'],
             ],
             [
               'name' => $this->t('Links'),
-              'items' => ['DrupalLink', 'DrupalUnlink',],
+              'items' => ['DrupalLink', 'DrupalUnlink'],
             ],
             [
               'name' => $this->t('Lists'),
-              'items' => ['BulletedList', 'NumberedList',],
+              'items' => ['BulletedList', 'NumberedList'],
             ],
             [
               'name' => $this->t('Media'),
-              'items' => ['Blockquote', 'DrupalImage',],
+              'items' => ['Blockquote', 'DrupalImage'],
             ],
             [
               'name' => $this->t('Tools'),
-              'items' => ['Source',],
+              'items' => ['Source'],
             ],
           ],
         ],

core/modules/ckeditor/src/Tests/CKEditorAdminTest.php

@@ -84,23 +84,23 @@ class CKEditorAdminTest extends WebTestBase {
           [
             [
               'name' => 'Formatting',
-              'items' => ['Bold', 'Italic',],
+              'items' => ['Bold', 'Italic'],
             ],
             [
               'name' => 'Links',
-              'items' => ['DrupalLink', 'DrupalUnlink',],
+              'items' => ['DrupalLink', 'DrupalUnlink'],
             ],
             [
               'name' => 'Lists',
-              'items' => ['BulletedList', 'NumberedList',],
+              'items' => ['BulletedList', 'NumberedList'],
             ],
             [
               'name' => 'Media',
-              'items' => ['Blockquote', 'DrupalImage',],
+              'items' => ['Blockquote', 'DrupalImage'],
             ],
             [
               'name' => 'Tools',
-              'items' => ['Source',],
+              'items' => ['Source'],
             ],
           ],
         ],

core/modules/ckeditor/tests/modules/src/Kernel/CKEditorTest.php

@@ -463,23 +463,23 @@ class CKEditorTest extends KernelTestBase {
     return [
       [
         'name' => 'Formatting',
-        'items' => ['Bold', 'Italic',],
+        'items' => ['Bold', 'Italic'],
       ],
       [
         'name' => 'Links',
-        'items' => ['DrupalLink', 'DrupalUnlink',],
+        'items' => ['DrupalLink', 'DrupalUnlink'],
       ],
       [
         'name' => 'Lists',
-        'items' => ['BulletedList', 'NumberedList',],
+        'items' => ['BulletedList', 'NumberedList'],
       ],
       [
         'name' => 'Media',
-        'items' => ['Blockquote', 'DrupalImage',],
+        'items' => ['Blockquote', 'DrupalImage'],
       ],
       [
         'name' => 'Tools',
-        'items' => ['Source',],
+        'items' => ['Source', ],
       ],
       '/',
     ];

core/modules/field/tests/src/Kernel/FieldDataCountTest.php

@@ -112,7 +112,7 @@ class FieldDataCountTest extends FieldKernelTestBase {
 
     $entity_init = $this->container->get('entity_type.manager')
       ->getStorage($entity_type)
-      ->create(['type' => $entity_type,]);
+      ->create(['type' => $entity_type]);
     $cardinality = $this->fieldTestData->field_storage_2->getCardinality();
 
     $this->assertIdentical($this->fieldTestData->field_storage_2->hasData(), FALSE, 'There are no entities with field data.');

core/modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldFormatterSettingsTest.php

@@ -138,7 +138,7 @@ class MigrateFieldFormatterSettingsTest extends MigrateDrupal6TestBase {
     $this->assertIdentical($expected, $component);
 
     // Test date field.
-    $defaults = ['format_type' => 'fallback', 'timezone_override' => '',];
+    $defaults = ['format_type' => 'fallback', 'timezone_override' => ''];
     $expected['weight'] = 10;
     $expected['type'] = 'datetime_default';
     $expected['settings'] = ['format_type' => 'fallback'] + $defaults;

core/modules/shortcut/tests/src/Unit/Menu/ShortcutLocalTasksTest.php

@@ -26,7 +26,7 @@ class ShortcutLocalTasksTest extends LocalTaskIntegrationTestBase {
    */
   public function testShortcutPageLocalTasks($route) {
     $tasks = [
-      0 => ['shortcut.set_switch', 'entity.user.canonical', 'entity.user.edit_form',],
+      0 => ['shortcut.set_switch', 'entity.user.canonical', 'entity.user.edit_form'],
     ];
     $this->assertLocalTasks($route, $tasks);
   }

core/modules/toolbar/src/Tests/ToolbarAdminMenuTest.php

@@ -179,7 +179,7 @@ class ToolbarAdminMenuTest extends WebTestBase {
 
     $this->hash = $this->getSubtreesHash();
 
-    $rid = $this->drupalCreateRole(['administer content types',]);
+    $rid = $this->drupalCreateRole(['administer content types']);
 
     // Assign the role to the user.
     $this->drupalPostForm('user/' . $this->adminUser->id() . '/edit', ["roles[$rid]" => $rid], t('Save'));
@@ -214,7 +214,7 @@ class ToolbarAdminMenuTest extends WebTestBase {
 
     // adminUser2 will add a role to adminUser.
     $this->drupalLogin($this->adminUser2);
-    $rid = $this->drupalCreateRole(['administer content types',]);
+    $rid = $this->drupalCreateRole(['administer content types']);
 
     // Get the subtree hash for adminUser2 to check later that it has not
     // changed. Request a new page to refresh the drupalSettings object.

core/modules/user/tests/src/Unit/Menu/UserLocalTasksTest.php

@@ -44,7 +44,7 @@ class UserLocalTasksTest extends LocalTaskIntegrationTestBase {
    */
   public function testUserLoginLocalTasks($route) {
     $tasks = [
-      0 => ['user.register', 'user.pass', 'user.login',],
+      0 => ['user.register', 'user.pass', 'user.login'],
     ];
     $this->assertLocalTasks($route, $tasks);
   }
@@ -67,7 +67,7 @@ class UserLocalTasksTest extends LocalTaskIntegrationTestBase {
    */
   public function testUserPageLocalTasks($route, $subtask = []) {
     $tasks = [
-      0 => ['entity.user.canonical', 'entity.user.edit_form',],
+      0 => ['entity.user.canonical', 'entity.user.edit_form'],
     ];
     if ($subtask) $tasks[] = $subtask;
     $this->assertLocalTasks($route, $tasks);

core/tests/Drupal/Tests/Component/Gettext/PoHeaderTest.php

@@ -279,7 +279,7 @@ class PoHeaderTest extends UnitTestCase {
           193 => 1,
           194 => 1,
           'default' => 2,
-        ],],
+        ], ],
       [
         'nplurals=4; plural=(((n==1)||(n==11))?(0):(((n==2)||(n==12))?(1):(((n>2)&&(n<20))?(2):3)));',
         [