Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3088595 by quietone, phenaproxima, arunkumark, heddn: Remove Migration::get()

merge-requests/2419/head
catch 2019-12-09 12:35:59 +00:00
parent a061318733
commit 6ffa1bdf13
2 changed files with 0 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
core/modules/migrate/src/Plugin/Migration.php
View File

@ -313,25 +313,6 @@ class Migration extends PluginBase implements MigrationInterface, RequirementsIn
return $this->label;
}
/**
* Gets any arbitrary property's value.
*
* @param string $property
* The property to retrieve.
*
* @return mixed
* The value for that property, or NULL if the property does not exist.
*
* @deprecated in drupal:8.1.0 and is removed from drupal:9.0.0. Use
* more specific getters instead.
*
* @see https://www.drupal.org/node/2873795
*/
public function get($property) {
@trigger_error('\Drupal\migrate\Plugin\Migration::get() is deprecated in Drupal 8.1.x, will be removed before Drupal 9.0.x. Use more specific getters instead. See https://www.drupal.org/node/2873795', E_USER_DEPRECATED);
return isset($this->$property) ? $this->$property : NULL;
}
/**
* Retrieves the ID map plugin.
*

46
core/modules/migrate_drupal/tests/src/Kernel/dependencies/MigrateDependenciesTest.php
View File

@ -21,52 +21,6 @@ class MigrateDependenciesTest extends MigrateDrupal6TestBase {
/**
* Tests that the order is correct when loading several migrations.
*
* @group legacy
* @expectedDeprecation \Drupal\migrate\Plugin\Migration::get() is deprecated in Drupal 8.1.x, will be removed before Drupal 9.0.x. Use more specific getters instead. See https://www.drupal.org/node/2873795
*/
public function testMigrateDependenciesOrder() {
$migration_items = ['d6_comment', 'd6_filter_format', 'd6_node:page'];
$migrations = $this->container->get('plugin.manager.migration')->createInstances($migration_items);
$expected_order = ['d6_filter_format', 'd6_node:page', 'd6_comment'];
$this->assertIdentical(array_keys($migrations), $expected_order);
$expected_requirements = [
// d6_comment depends on d6_node:*, which the deriver expands into every
// variant of d6_node.
'd6_node:article',
'd6_node:company',
'd6_node:employee',
'd6_node:event',
'd6_node:forum',
'd6_node:page',
'd6_user',
'd6_node_type',
'd6_node_settings',
'd6_filter_format',
'd6_node:sponsor',
'd6_node:story',
'd6_node:test_event',
'd6_node:test_page',
'd6_node:test_planet',
'd6_node:test_story',
'd6_comment_type',
'd6_comment_entity_display',
'd6_comment_entity_form_display',
];
// Migration dependencies for comment include dependencies for node
// migration as well.
$actual_requirements = $migrations['d6_comment']->get('requirements');
$this->assertIdentical(count($actual_requirements), count($expected_requirements));
foreach ($expected_requirements as $requirement) {
$this->assertIdentical($actual_requirements[$requirement], $requirement);
}
}
/**
* Tests that the order is correct when loading several migrations.
*
* Replacement test for testMigrateDependenciesOrder that doesn't use
* the deprecated MigrationInterface::get().
*/
public function testMigrationDependenciesOrder() {
$migration_items = ['d6_comment', 'd6_filter_format', 'd6_node:page'];