Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3259355 by mallezie, mondrake, catch, longwave, mglaman, alexpott, xjm, daffie, Mixologic: Always do a full phpstan analysis on DrupalCI

merge-requests/2291/head
Alex Pott 2022-05-18 09:02:22 +01:00
parent 1e9845607a
commit 6a27d76215
No known key found for this signature in database
GPG Key ID: BDA67E7EE836E5CE
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/phpstan-partial.neon
View File

@ -1,5 +1,5 @@
# Configuration file for PHPStan static code checking, see https://phpstan.org . # Configuration file for PHPStan static code checking, see https://phpstan.org .
# PHPStan is triggered on Drupal CI in commit-code-check.sh. # PHPStan with partial analysis is triggered in commit-code-check.sh.
includes: includes:
- phpstan.neon.dist - phpstan.neon.dist

8
core/scripts/dev/commit-code-check.sh
View File

@ -216,15 +216,17 @@ printf "\n"
printf -- '-%.0s' {1..100} printf -- '-%.0s' {1..100}
printf "\n" printf "\n"
# Run PHPStan on all files in one go for better performance. APCu is disabled to # Run PHPStan on all files on DrupalCI or when phpstan files are changed.
# ensure that the composer classmap is not corrupted. # APCu is disabled to ensure that the composer classmap is not corrupted.
if [[ $PHPSTAN_DIST_FILE_CHANGED == "1" ]]; then if [[ $PHPSTAN_DIST_FILE_CHANGED == "1" ]] || [[ "$DRUPALCI" == "1" ]]; then
printf "\nRunning PHPStan on *all* files.\n" printf "\nRunning PHPStan on *all* files.\n"
php -d apc.enabled=0 -d apc.enable_cli=0 vendor/bin/phpstan analyze --no-progress --configuration="$TOP_LEVEL/core/phpstan.neon.dist" php -d apc.enabled=0 -d apc.enable_cli=0 vendor/bin/phpstan analyze --no-progress --configuration="$TOP_LEVEL/core/phpstan.neon.dist"
else else
# Only run PHPStan on changed files locally.
printf "\nRunning PHPStan on changed files.\n" printf "\nRunning PHPStan on changed files.\n"
php -d apc.enabled=0 -d apc.enable_cli=0 vendor/bin/phpstan analyze --no-progress --configuration="$TOP_LEVEL/core/phpstan-partial.neon" $ABS_FILES php -d apc.enabled=0 -d apc.enable_cli=0 vendor/bin/phpstan analyze --no-progress --configuration="$TOP_LEVEL/core/phpstan-partial.neon" $ABS_FILES
fi fi
if [ "$?" -ne "0" ]; then if [ "$?" -ne "0" ]; then
# If there are failures set the status to a number other than 0. # If there are failures set the status to a number other than 0.
FINAL_STATUS=1 FINAL_STATUS=1