Issue #2226933 by cs_shadow, tim.plunkett, mandar.harkare, mortendk: Remove odd, even, first & last classes from views-view-unformatted.html.twig.

core/modules/action/tests/action_bulk_test/config/install/views.view.test_bulk_form.yml

@@ -29,7 +29,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: false
           summary: ''

core/modules/comment/config/install/views.view.comments_recent.yml

@@ -36,7 +36,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           type: ul
           wrapper_class: item-list
           class: ''

core/modules/file/config/install/views.view.files.yml

@@ -64,7 +64,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: false
           caption: ''
@@ -989,7 +988,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: false
           caption: ''

core/modules/node/config/install/views.view.archive.yml

@@ -110,7 +110,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
         provider: views
       row:

core/modules/node/config/install/views.view.content.yml

@@ -39,7 +39,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: true
           caption: ''

core/modules/node/config/install/views.view.content_recent.yml

@@ -51,7 +51,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: false
           caption: ''

core/modules/node/config/install/views.view.frontpage.yml

@@ -183,7 +183,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
       title: ''
       header: {  }

core/modules/node/config/install/views.view.glossary.yml

@@ -284,7 +284,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
           order: asc
           summary: ''

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_contextual_links.yml

@@ -55,7 +55,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
       title: ''
       header: {  }

core/modules/taxonomy/config/install/views.view.taxonomy_term.yml

@@ -165,7 +165,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
         provider: views
       row:

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_filter_taxonomy_index_tid.yml

@@ -62,7 +62,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
       row:
         type: fields

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_parent.yml

@@ -68,7 +68,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           uses_fields: false
         provider: views
       row:

core/modules/tracker/tests/modules/tracker_test_views/test_views/views.view.test_tracker_user_uid.yml

@@ -26,7 +26,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: false
           summary: ''

core/modules/user/config/install/views.view.user_admin_people.yml

@@ -66,7 +66,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           override: true
           sticky: false
           summary: ''

core/modules/user/config/install/views.view.who_s_online.yml

@@ -51,7 +51,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
           type: ul
           wrapper_class: item-list
           class: ''

core/modules/views/config/schema/views.data_types.schema.yml

@@ -665,9 +665,6 @@ views_style:
     default_row_class:
       type: boolean
       label: 'Add views row classes'
-    row_class_special:
-      type: boolean
-      label: 'Add striping (odd/even), first/last row classes'
     uses_fields:
       type: boolean
       label: 'Force using fields'

core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.php

@@ -227,7 +227,6 @@ abstract class StylePluginBase extends PluginBase {
     if ($this->usesRowClass()) {
       $options['row_class'] = array('default' => '');
       $options['default_row_class'] = array('default' => TRUE, 'bool' => TRUE);
-      $options['row_class_special'] = array('default' => TRUE, 'bool' => TRUE);
     }
     $options['uses_fields'] = array('default' => FALSE, 'bool' => TRUE);
 
@@ -313,12 +312,6 @@ abstract class StylePluginBase extends PluginBase {
         '#type' => 'checkbox',
         '#default_value' => $this->options['default_row_class'],
       );
-      $form['row_class_special'] = array(
-        '#title' => t('Add striping (odd/even), first/last row classes'),
-        '#description' => t('Add css classes to the first and last line, as well as odd/even classes for striping.'),
-        '#type' => 'checkbox',
-        '#default_value' => $this->options['row_class_special'],
-      );
     }
 
     if (!$this->usesFields() || !empty($this->options['uses_fields'])) {

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_search.yml

@@ -111,7 +111,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: true
-          row_class_special: true
       row:
         type: fields
       fields:

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_table.yml

@@ -52,7 +52,6 @@ display:
           grouping: {  }
           row_class: ''
           default_row_class: '1'
-          row_class_special: '1'
           override: '1'
           sticky: '0'
           summary: summary-text

core/modules/views/views.theme.inc

@@ -499,8 +499,6 @@ function template_preprocess_views_view_table(&$variables) {
   $options = $view->style_plugin->options;
   $handler = $view->style_plugin;
 
-  $row_class_special = isset($options['row_class_special']) ? $options['row_class_special'] : TRUE;
-
   $fields = &$view->field;
   $columns = $handler->sanitizeColumns($options['columns'], $fields);
 
@@ -676,7 +674,6 @@ function template_preprocess_views_view_table(&$variables) {
     $variables['header'] = array();
   }
 
-  $count = 0;
   foreach ($variables['rows'] as $num => $row) {
     $variables['rows'][$num]['attributes'] = array();
     if ($row_class = $handler->getRowClass($num)) {
@@ -869,15 +866,10 @@ function template_preprocess_views_view_unformatted(&$variables) {
   $options = $style->options;
 
   $default_row_class = isset($options['default_row_class']) ? $options['default_row_class'] : FALSE;
-  $row_class_special = isset($options['row_class_special']) ? $options['row_class_special'] : FALSE;
-  // Set up striping values.
-  $count = 0;
-  $max = count($rows);
   foreach ($rows as $id => $row) {
     $variables['rows'][$id] = array();
     $variables['rows'][$id]['content'] = $row;
     $variables['rows'][$id]['attributes'] = array();
-    $count++;
     if ($default_row_class) {
       $variables['rows'][$id]['attributes']['class'][] = 'views-row';
     }