From 69f148f64eab17a1cfa530a5ebab30a8759abfdd Mon Sep 17 00:00:00 2001 From: catch Date: Sat, 9 Jul 2022 21:18:54 +0900 Subject: [PATCH] Issue #3294883 by marcoscano: Fix inaccurate code comment in Media.php --- core/modules/media/src/Entity/Media.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/modules/media/src/Entity/Media.php b/core/modules/media/src/Entity/Media.php index 6649cccfd06..76739dbe48d 100644 --- a/core/modules/media/src/Entity/Media.php +++ b/core/modules/media/src/Entity/Media.php @@ -375,8 +375,8 @@ class Media extends EditorialContentEntityBase implements MediaInterface { // Try to set fields provided by the media source and mapped in // media type config. foreach ($translation->bundle->entity->getFieldMap() as $metadata_attribute_name => $entity_field_name) { - // Only save value in entity field if empty. Do not overwrite existing - // data. + // Only save value in the entity if the field is empty or if the + // source field changed. if ($translation->hasField($entity_field_name) && ($translation->get($entity_field_name)->isEmpty() || $translation->hasSourceFieldChanged())) { $translation->set($entity_field_name, $media_source->getMetadata($translation, $metadata_attribute_name)); }