Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2609504 by Lendude, mohit_aghera, ibustos: Default People display shows date since unix timestamp 0 as 'Last access'

8.1.x
Nathaniel Catchpole 2016-02-15 21:36:17 +09:00
parent 2a1c93a2bb
commit 68e9f22667
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/modules/user/src/Tests/UserAdminListingTest.php
View File

@ -80,6 +80,7 @@ class UserAdminListingTest extends WebTestBase {
'status' => (string) $account->td[1],
'roles' => $roles,
'member_for' => (string) $account->td[3],
'last_access' => (string) $account->td[4],
);
}
@ -92,6 +93,8 @@ class UserAdminListingTest extends WebTestBase {
$this->assertEqual($result_accounts[$role_account_name]['roles'], $expected_roles, 'Ensure roles are listed properly.');
$this->assertEqual($result_accounts[$timestamp_user]['member_for'], \Drupal::service('date.formatter')->formatTimeDiffSince($accounts[$timestamp_user]->created->value), 'Ensure the right member time is displayed.');
$this->assertEqual($result_accounts[$timestamp_user]['last_access'], 'never', 'Ensure the last access time is "never".');
}
}

2
core/modules/user/src/UserListBuilder.php
View File

@ -158,7 +158,7 @@ class UserListBuilder extends EntityListBuilder {
$row['member_for']['data'] = $this->dateFormatter->formatTimeDiffSince($entity->getCreatedTime(), $options)->toRenderable();
$last_access = $this->dateFormatter->formatTimeDiffSince($entity->getLastAccessedTime(), $options);
if ($entity->access) {
if ($entity->getLastAccessedTime()) {
$row['access']['data']['#markup'] = $last_access->getString();
CacheableMetadata::createFromObject($last_access)->applyTo($row['access']['data']);
}