Issue #3307698 by andypost, _shY, Amber Himes Matz: Update breadcrumbs in statistics and system help topics to use help_route_link function

core/modules/help_topics/help_topics/system.cache.html.twig

@@ -3,14 +3,15 @@ label: 'Clearing the site cache'
 related:
   - core.maintenance
 ---
-{% set performance_url = render_var(url('system.performance_settings')) %}
+{% set performance_link_text %}{% trans %}Performance{% endtrans %}{% endset %}
+{% set performance_link = render_var(help_route_link(performance_link_text, 'system.performance_settings')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Clear the data in the site cache.{% endtrans %}</p>
 <h2>{% trans %}What is the cache?{% endtrans %}</h2>
 <p>{% trans %}Some of the calculations that are done when your site loads a page take a long time to run. To save time when these calculations would need to be done again, their results can be <em>cached</em> in your site's database. There are internal mechanisms to <em>clear</em> cached data when the conditions or assumptions that went into the calculation have changed, but you can also clear cached data manually. When your site is misbehaving, a good first step is to clear the cache and see if the problem goes away.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em><a href="{{ performance_url }}"><em>Performance</em></a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em>{{ performance_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Click <em>Clear all caches</em>. Your site's cached data will be cleared.{% endtrans %}</li>
 </ol>
 <h2>{% trans %}Additional resources{% endtrans %}</h2>

core/modules/help_topics/help_topics/system.config_basic.html.twig

@@ -4,20 +4,23 @@ top_level: true
 related:
   - user.security_account_settings
 ---
-{% set regional_url = render_var(url('system.regional_settings')) %}
+{% set regional_link_text %}{% trans %}Regional settings{% endtrans %}{% endset %}
-{% set information_url = render_var(url('system.site_information_settings')) %}
+{% set regional_link = render_var(help_route_link(regional_link_text, 'system.regional_settings')) %}
-{% set datetime_url = render_var(url('entity.date_format.collection')) %}
+{% set information_link_text %}{% trans %}Basic site settings{% endtrans %}{% endset %}
+{% set information_link = render_var(help_route_link(information_link_text, 'system.site_information_settings')) %}
+{% set datetime_link_text %}{% trans %}Date and time formats{% endtrans %}{% endset %}
+{% set datetime_link = render_var(help_route_link(datetime_link_text, 'entity.date_format.collection')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Configure the basic settings of your site, including the site name, slogan, main email address, default time zone, default country, and the date formats to use.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>System</em> &gt; <em><a href="{{ information_url }}">Basic site settings</a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>System</em> &gt; <em>{{ information_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Enter the site name, slogan, and main email address for your site. {% endtrans %}</li>
   <li>{% trans %}Click <em>Save configuration</em>. You should see a message indicating that the settings were saved.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Region and language</em> &gt; <em><a href="{{ regional_url }}">Regional settings</a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Region and language</em> &gt; <em>{{ regional_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Select the default country and default time zone for your site.{% endtrans %}</li>
   <li>{% trans %}Click <em>Save configuration</em>. You should see a message indicating that the settings were saved.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Region and language</em> &gt; <em><a href="{{ datetime_url }}">Date and time formats</a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Region and language</em> &gt; <em>{{ datetime_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Look at the <em>Patterns</em> for the Default long, medium, and short date formats. If any of them does not match the date format you want to use on your site, click <em>Edit</em> in that row to edit the format.{% endtrans %}</li>
   <li>{% trans %}Adjust the <em>Format string</em> until the <em>Displayed</em> format matches what you want. (Date format strings are composed of PHP date format codes.){% endtrans %}</li>
   <li>{% trans %}Click <em>Save format</em>. You should see a message indicating that the format was saved.{% endtrans %}</li>

core/modules/help_topics/help_topics/system.config_error.html.twig

@@ -4,8 +4,10 @@ related:
   - system.config_basic
   - core.maintenance
 ---
-{% set log_settings_url = render_var(url('system.logging_settings')) %}
+{% set log_settings_link_text %}{% trans %}Logging and errors{% endtrans %}{% endset %}
-{% set information_url = render_var(url('system.site_information_settings')) %}
+{% set log_settings_link = render_var(help_route_link(log_settings_link_text, 'system.logging_settings')) %}
+{% set information_link_text %}{% trans %}Basic site settings{% endtrans %}{% endset %}
+{% set information_link = render_var(help_route_link(information_link_text, 'system.site_information_settings')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Set up your site to respond appropriately to site errors, including 403 and 404 page responses.{% endtrans %}</p>
 <h2>{% trans %}What are 403 and 404 responses?{% endtrans %}</h2>
@@ -15,10 +17,10 @@ related:
 <h2>{% trans %}Steps {% endtrans %}</h2>
 <ol>
   <li>{% trans %}If desired, create pages to use for 403 and 404 responses. Note the URLs for these pages.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>System</em> &gt; <em><a href="{{ information_url }}">Basic site settings</a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>System</em> &gt; <em>{{ information_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}In the <em>Error pages</em> section, enter the URL for your 403/403 pages, starting after the site home page URL. For example, if your site URL is <em>https://example.com</em> and your 404 page is <em>https://example.com/not-found</em>, you would enter <em>/not-found</em>.{% endtrans %}</li>
   <li>{% trans %}Click <em>Save configuration</em>. You should see a message indicating that the settings were saved.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em><a href="{{ log_settings_url }}">Logging and errors</a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em>{{ log_settings_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}For a production site, select <em>None</em> under <em>Error messages to display</em>. For a site that is in development, select one of the other options, so that you are more aware of the errors the site is generating.{% endtrans %}</li>
   <li>{% trans %}Click <em>Save configuration</em>. You should see a message indicating that the settings were saved.{% endtrans %}</li>
 </ol>

core/modules/help_topics/help_topics/system.maintenance_mode.html.twig

@@ -4,18 +4,19 @@ related:
   - core.maintenance
   - system.cache
 ---
-{% set maintenance_url = render_var(url('system.site_maintenance_mode')) %}
 {% set cache_topic = render_var(help_topic_link('system.cache')) %}
+{% set maintenance_link_text %}{% trans %}Maintenance mode{% endtrans %}{% endset %}
+{% set maintenance_link = render_var(help_route_link(maintenance_link_text, 'system.site_maintenance_mode')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Put your site in maintenance mode to perform maintenance operations, and then return to normal mode when finished.{% endtrans %}</p>
 <h2>{% trans %}What is maintenance mode?{% endtrans %}</h2>
 <p>{% trans %}When your site is in maintenance mode, most site visitors will see a simple maintenance mode message page, rather than being able to use the full functionality of the site. Users with <em>Use the site in maintenance mode</em> permission who are already logged in will be able to use the full site, and the log in page at <em>/user</em> will also be accessible to anyone.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <a href="{{ maintenance_url }}"><em>Maintenance mode</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em>{{ maintenance_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Check <em>Put site into maintenance mode</em>, optionally change the <em>Message to display when in maintenance mode</em>, and click <em>Save configuration</em>. Your site will be in maintenance mode.{% endtrans %}</li>
   <li>{% trans %}Perform your maintenance operations.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em><a href="{{ maintenance_url }}">Maintenance mode</a></em>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Development</em> &gt; <em>{{ maintenance_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Uncheck <em>Put site into maintenance mode</em> and click <em>Save configuration</em>. Your site will be back in normal operation mode.{% endtrans %}</li>
   <li>{% trans %}Clear the site cache. See {{ cache_topic }} for instructions.{% endtrans %}</li>
 </ol>

core/modules/help_topics/help_topics/system.module_install.html.twig

@@ -4,12 +4,13 @@ related:
   - core.extending
   - system.module_uninstall
 ---
-{% set extend_url = render_var(url('system.modules_list')) %}
+{% set extend_link_text %}{% trans %}Extend{% endtrans %}{% endset %}
+{% set extend_link = render_var(help_route_link(extend_link_text, 'system.modules_list')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Install a core module, or a contributed module that has already been downloaded.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <a href="{{ extend_url }}"><em>Extend</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>{{ extend_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Enter a word from the module name or description into the filter box, to make the list of modules smaller. Locate the module you want to install.{% endtrans %}</li>
   <li>{% trans %}Check the box next to the name of the module you want to install; you can also check more than one box to install multiple modules at the same time. If the checkbox is disabled for the module you are trying to install, expand the information to see why -- you may need to download an additional module that your module requires.{% endtrans %}</li>
   <li>{% trans %}Click <em>Install</em> at the bottom of the page. If you chose to install a module with dependencies that were not already installed, or if you chose an Experimental module, confirm your choice on the next page.{% endtrans %}</li>

core/modules/help_topics/help_topics/system.module_uninstall.html.twig

@@ -5,13 +5,14 @@ related:
   - system.module_install
   - system.maintenance_mode
 ---
-{% set uninstall_url = render_var(url('system.modules_uninstall')) %}
+{% set uninstall_link_text %}{% trans %}Uninstall{% endtrans %}{% endset %}
+{% set uninstall_link = render_var(help_route_link(uninstall_link_text, 'system.modules_uninstall')) %}
 {% set maintenance_topic = render_var(help_topic_link('system.maintenance_mode')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Uninstall a module. Your site should be in <em>maintenance mode</em> when you uninstall modules. See {{ maintenance_topic }} for details.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Extend</em> &gt; <a href="{{ uninstall_url }}"><em>Uninstall</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Extend</em> &gt; <em>{{ uninstall_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Enter a word from the module name or description into the filter box, to make the list of modules smaller. Locate the module you want to uninstall.{% endtrans %}</li>
   <li>{% trans %}In the <em>Description</em> column, see if there are reasons that this module cannot be uninstalled. For example, you may have created content using this module (which you would need to delete first), or there may be another module installed that requires this module to be installed (you would need to uninstall the other module first).{% endtrans %}</li>
   <li>{% trans %}If there are no reasons listed, the module can be uninstalled. Check the box in the <em>Uninstall</em> column, next to the module's name.{% endtrans %}</li>

core/modules/help_topics/help_topics/system.reports.html.twig

@@ -5,12 +5,13 @@ related:
   - core.security
   - system.config_error
 ---
-{% set status_url = render_var(url('system.status')) %}
+{% set status_link_text %}{% trans %}Status report{% endtrans %}{% endset %}
+{% set status_link = render_var(help_route_link(status_link_text, 'system.status')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Run reports to learn about the status and health of your site.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Reports</em> &gt; <a href="{{ status_url }}"><em>Status report</em></a> to see a report that summarizes the health and status of your site. If there are any warnings or errors, you will need to fix them. Take note of any upcoming highly critical security releases that may impact your site.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Reports</em> &gt; <em>{{ status_link }}</em> to see a report that summarizes the health and status of your site. If there are any warnings or errors, you will need to fix them. Take note of any upcoming highly critical security releases that may impact your site.{% endtrans %}</li>
   <li>{% trans %}If you have the core Database Logging module installed, in the <em>Manage</em> administrative menu, navigate to <em>Reports</em> &gt; <em>Recent log messages</em> to see a report of the error and informational messages your site has generated. You can filter the report by <em>Severity</em> to see only the most critical messages, if desired.{% endtrans %}</li>
   <li>{% trans %}If you have the core Update Manager module installed, in the <em>Manage</em> administrative menu, navigate to <em>Reports</em> &gt; <em>Available updates</em> to see a report of the updates that are available for your site software. If <em>Last checked</em> is far in the past, click <em>Check manually</em> to update the report. Scan the report; if Drupal core or any modules or themes have security updates available, you should update them as soon as possible.{% endtrans %}</li>
 </ol>

core/modules/help_topics/help_topics/system.theme_install.html.twig

@@ -4,12 +4,13 @@ related:
   - core.appearance
   - system.theme_uninstall
 ---
-{% set themes_url = render_var(url('system.themes_page')) %}
+{% set themes_link_text %}{% trans %}Appearance{% endtrans %}{% endset %}
+{% set themes_link = render_var(help_route_link(themes_link_text, 'system.themes_page')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Install a core theme, or a contributed theme that has already been downloaded. Choose the default themes to use for the site and for administrative pages.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <a href="{{ themes_url }}"><em>Appearance</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>{{ themes_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Locate the themes that you want to use as the site default theme and for administrative pages.{% endtrans %}</li>
   <li>{% trans %}For each of these themes, if the theme is in the <em>Uninstalled themes</em> section, click the <em>Install</em> link to install the theme. Wait for the theme to be installed (translations might be downloaded). You should be returned to the <em>Appearance</em> page.{% endtrans %}</li>
   <li>{% trans %}Locate the theme that you want to be your default theme, which should now be in the <em>Installed themes</em> section. If it is not already labeled as the <em>default theme</em>, click the <em>Set as default</em> link.{% endtrans %}</li>

core/modules/help_topics/help_topics/system.theme_uninstall.html.twig

@@ -4,12 +4,13 @@ related:
   - core.appearance
   - system.theme_install
 ---
-{% set themes_url = render_var(url('system.themes_page')) %}
+{% set themes_link_text %}{% trans %}Appearance{% endtrans %}{% endset %}
+{% set themes_link = render_var(help_route_link(themes_link_text, 'system.themes_page')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Uninstall a theme that was previously installed, but is no longer being used on the site.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <a href="{{ themes_url }}"><em>Appearance</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>{{ themes_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Locate the theme that you want to uninstall, in the <em>Installed themes</em> section.{% endtrans %}</li>
   <li>{% trans %}Click the <em>Uninstall</em> link to uninstall the theme. If there is not an <em>Uninstall</em> link, the theme cannot be uninstalled because it is either being used as the site default theme, being used as the <em>Administration theme</em>, or is the base theme for another installed theme.{% endtrans %}</li>
 </ol>

core/modules/statistics/help_topics/statistics.tracking_popular_content.html.twig

@@ -5,17 +5,19 @@ related:
   - history.tracking_user_content
   - block.place
 ---
-{% set statistics_settings = render_var(url('statistics.settings')) %}
+{% set statistics_settings_link_text %}{% trans %}Statistics{% endtrans %}{% endset %}
-{% set permissions = render_var(url('user.admin_permissions')) %}
+{% set permissions_link_text %}{% trans %}Permissions{% endtrans %}{% endset %}
+{% set statistics_settings_link = render_var(help_route_link(statistics_settings_link_text, 'statistics.settings')) %}
+{% set permissions_link = render_var(help_route_link(permissions_link_text, 'user.admin_permissions')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Configure and display tracking of how many times content has been viewed on your site, assuming that the core Statistics module is currently installed.{% endtrans %}</p>
 <h2>{% trans %}What are the options for displaying popularity tracking?{% endtrans %}</h2>
 <p>{% trans %}You can display a <em>content hits</em> counter of how many times a content item has been viewed, at the bottom of content item pages. You can also place a <em>Popular content</em> block in a region of your theme, which shows a list of the most popular and most recently-viewed content.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>System</em> &gt; <a href="{{ statistics_settings }}"><em>Statistics</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>System</em> &gt; <em>{{ statistics_settings_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Check <em>Count content views</em> and click <em>Save configuration</em>.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>People</em> &gt; <a href="{{ permissions }}"><em>Permissions</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>People</em> &gt; <em>{{ permissions_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}In the <em>Statistics</em> section, check or uncheck the <em>View content hits</em> permission for each role. Click <em>Save permissions</em>.{% endtrans %}</li>
   <li>{% trans %}Optionally, in the <em>Manage</em> administrative menu, navigate to <em>Structure</em> &gt; <em>Block layout</em>. Place the <em>Popular content</em> block in a region in your theme (you will need to have the core Block module installed; see related topic for more details on block placement).{% endtrans %}</li>
 </ol>