Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #1953444 by amateescu, xjm: Make 'target bundles' required on the Entity reference instance settings form to help increase their visibility/sanity.

8.0.x
webchick 2013-03-26 22:39:04 -07:00
parent 3a91a52862
commit 63e7c7641f
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/entity_reference/selection/SelectionBase.php
View File

@ -97,7 +97,8 @@ class SelectionBase implements SelectionInterface {
'#type' => 'checkboxes',
'#title' => $target_bundles_title,
'#options' => $bundle_options,
'#default_value' => (!empty($instance['settings']['handler_settings']['target_bundles'])) ? $instance['settings']['handler_settings']['target_bundles'] : array_keys($bundle_options),
'#default_value' => (!empty($instance['settings']['handler_settings']['target_bundles'])) ? $instance['settings']['handler_settings']['target_bundles'] : array(),
'#required' => TRUE,
'#size' => 6,
'#multiple' => TRUE,
'#element_validate' => array('_entity_reference_element_validate_filter'),

4
core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceAdminTest.php
View File

@ -100,7 +100,9 @@ class EntityReferenceAdminTest extends WebTestBase {
$this->drupalPostAJAX(NULL, array('instance[settings][handler_settings][sort][field]' => '_none'), 'instance[settings][handler_settings][sort][field]');
// Third step: confirm.
$this->drupalPost(NULL, array(), t('Save settings'));
$this->drupalPost(NULL, array(
'instance[settings][handler_settings][target_bundles][' . key($bundles) . ']' => key($bundles),
), t('Save settings'));
// Check that the field appears in the overview form.
$this->assertFieldByXPath('//table[@id="field-overview"]//td[1]', 'Test label', t('Field was created and appears in the overview page.'));