Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2616724 follow-up by alexpott: Warn when trying to create a database table with a NOT NULL => FALSE primary key

merge-requests/1654/head
Alex Pott 2018-07-11 15:11:41 +01:00
parent ca1574e36e
commit 5a7dc82fe6
No known key found for this signature in database
GPG Key ID: 31905460D4A69276
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/tests/Drupal/KernelTests/Core/Database/SchemaTest.php
View File

@ -828,8 +828,7 @@ class SchemaTest extends KernelTestBase {
],
'primary key' => ['test_field'],
];
$this->expectException(SchemaException::class);
$this->expectExceptionMessage("The 'test_field' field specification does not define 'not null' as TRUE.");
$this->setExpectedException(SchemaException::class, "The 'test_field' field specification does not define 'not null' as TRUE.");
$schema->createTable($table_name, $table_spec);
}
@ -850,8 +849,7 @@ class SchemaTest extends KernelTestBase {
];
$schema->createTable($table_name, $table_spec);
$this->expectException(SchemaException::class);
$this->expectExceptionMessage("The 'new_test_field' field specification does not define 'not null' as TRUE.");
$this->setExpectedException(SchemaException::class, "The 'new_test_field' field specification does not define 'not null' as TRUE.");
$schema->addField($table_name, 'new_test_field', ['type' => 'int'], ['primary key' => ['test_field', 'new_test_field']]);
}
@ -872,8 +870,7 @@ class SchemaTest extends KernelTestBase {
];
$schema->createTable($table_name, $table_spec);
$this->expectException(SchemaException::class);
$this->expectExceptionMessage("The 'changed_test_field' field specification does not define 'not null' as TRUE.");
$this->setExpectedException(SchemaException::class, "The 'changed_test_field' field specification does not define 'not null' as TRUE.");
$schema->dropPrimaryKey($table_name);
$schema->changeField($table_name, 'test_field', 'changed_test_field', ['type' => 'int'], ['primary key' => ['changed_test_field']]);
}