Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3439835 by pooja_sharma, thebumik, FeyP, smustgrave, vensires: Fix Field UI tests that rely on UID1's super user behavior 

(cherry picked from commit 139bf72968)
merge-requests/9004/head
nod_ 2024-07-28 03:02:17 +02:00
parent 34e0302e57
commit 554f305ce5
No known key found for this signature in database
GPG Key ID: 76624892606FA197
3 changed files with 14 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/modules/field/tests/src/Functional/EntityReference/EntityReferenceXSSTest.php
View File

@ -25,14 +25,6 @@ class EntityReferenceXSSTest extends BrowserTestBase {
*/
protected static $modules = ['node'];
/**
* {@inheritdoc}
*
* @todo Remove and fix test to not rely on super user.
* @see https://www.drupal.org/project/drupal/issues/3437620
*/
protected bool $usesSuperUserAccessPolicy = TRUE;
/**
* {@inheritdoc}
*/
@ -68,7 +60,9 @@ class EntityReferenceXSSTest extends BrowserTestBase {
->save();
// Create a node and reference the node with markup in the title.
$this->drupalLogin($this->rootUser);
$this->drupalLogin($this->drupalCreateUser([
'create article content',
]));
$this->drupalGet('node/add/article');
$this->assertSession()->assertEscaped($referenced_node->getTitle());
$this->assertSession()->assertEscaped($node_type_two->label());

14
core/modules/field/tests/src/Functional/FieldDefaultValueCallbackTest.php
View File

@ -22,14 +22,6 @@ class FieldDefaultValueCallbackTest extends BrowserTestBase {
*/
protected static $modules = ['node', 'field_test', 'field_ui'];
/**
* {@inheritdoc}
*
* @todo Remove and fix test to not rely on super user.
* @see https://www.drupal.org/project/drupal/issues/3437620
*/
protected bool $usesSuperUserAccessPolicy = TRUE;
/**
* {@inheritdoc}
*/
@ -58,6 +50,10 @@ class FieldDefaultValueCallbackTest extends BrowserTestBase {
]);
}
$this->drupalLogin($this->drupalCreateUser([
'administer node fields',
]));
}
public function testDefaultValueCallbackForm(): void {
@ -76,8 +72,6 @@ class FieldDefaultValueCallbackTest extends BrowserTestBase {
]);
$field_config->save();
$this->drupalLogin($this->rootUser);
// Check that the default field form is visible when no callback is set.
$this->drupalGet('/admin/structure/types/manage/article/fields/node.article.field_test');
$this->assertSession()->fieldValueEquals('default_value_input[field_test][0][value]', '');

16
core/modules/field_ui/tests/src/Functional/FieldUIRouteTest.php
View File

@ -22,14 +22,6 @@ class FieldUIRouteTest extends BrowserTestBase {
*/
protected static $modules = ['block', 'entity_test', 'field_ui'];
/**
* {@inheritdoc}
*
* @todo Remove and fix test to not rely on super user.
* @see https://www.drupal.org/project/drupal/issues/3437620
*/
protected bool $usesSuperUserAccessPolicy = TRUE;
/**
* {@inheritdoc}
*/
@ -41,7 +33,6 @@ class FieldUIRouteTest extends BrowserTestBase {
protected function setUp(): void {
parent::setUp();
$this->drupalLogin($this->rootUser);
$this->drupalPlaceBlock('local_tasks_block');
}
@ -49,6 +40,13 @@ class FieldUIRouteTest extends BrowserTestBase {
* Ensures that entity types with bundles do not break following entity types.
*/
public function testFieldUIRoutes(): void {
$this->drupalLogin($this->drupalCreateUser([
'administer account settings',
'administer entity_test_no_id fields',
'administer user fields',
'administer user form display',
'administer user display',
]));
$this->drupalGet('entity_test_no_id/structure/entity_test/fields');
$this->assertSession()->pageTextContains('No fields are present yet.');