From 4fb5cf2558bda4677cd965866e1c68d81bc4a179 Mon Sep 17 00:00:00 2001 From: catch Date: Tue, 29 Mar 2022 10:25:03 +0100 Subject: [PATCH] Issue #3269267 by danflanagan8, dww: dblog tests should not rely on Classy (cherry picked from commit f67f0cb2d8a00b0a160b1de71e3be2685f3ba160) --- .../dblog/tests/src/Functional/DbLogTest.php | 14 ++++++++++---- .../dblog/tests/src/Functional/DbLogViewsTest.php | 4 ++-- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/core/modules/dblog/tests/src/Functional/DbLogTest.php b/core/modules/dblog/tests/src/Functional/DbLogTest.php index f83931cf4de..535a550e62e 100644 --- a/core/modules/dblog/tests/src/Functional/DbLogTest.php +++ b/core/modules/dblog/tests/src/Functional/DbLogTest.php @@ -11,6 +11,7 @@ use Drupal\Core\Url; use Drupal\dblog\Controller\DbLogController; use Drupal\error_test\Controller\ErrorTestController; use Drupal\Tests\BrowserTestBase; +use Drupal\Tests\system\Functional\Menu\AssertBreadcrumbTrait; /** * Generate events and verify dblog entries; verify user access to log reports @@ -20,6 +21,7 @@ use Drupal\Tests\BrowserTestBase; */ class DbLogTest extends BrowserTestBase { use FakeLogEntries; + use AssertBreadcrumbTrait; /** * Modules to enable. @@ -38,7 +40,7 @@ class DbLogTest extends BrowserTestBase { /** * {@inheritdoc} */ - protected $defaultTheme = 'classy'; + protected $defaultTheme = 'stark'; /** * A user with some relevant administrative permissions. @@ -366,9 +368,13 @@ class DbLogTest extends BrowserTestBase { $query = Database::getConnection()->select('watchdog'); $query->addExpression('MIN([wid])'); $wid = $query->execute()->fetchField(); - $this->drupalGet('admin/reports/dblog/event/' . $wid); - $xpath = '//nav[@class="breadcrumb"]/ol/li[last()]/a'; - $this->assertEquals('Recent log messages', current($this->xpath($xpath))->getText(), 'DBLogs link displayed at breadcrumb in event page.'); + $trail = [ + '' => 'Home', + 'admin' => 'Administration', + 'admin/reports' => 'Reports', + 'admin/reports/dblog' => 'Recent log messages', + ]; + $this->assertBreadcrumb('admin/reports/dblog/event/' . $wid, $trail); } /** diff --git a/core/modules/dblog/tests/src/Functional/DbLogViewsTest.php b/core/modules/dblog/tests/src/Functional/DbLogViewsTest.php index 2101bb92525..65f97621ac2 100644 --- a/core/modules/dblog/tests/src/Functional/DbLogViewsTest.php +++ b/core/modules/dblog/tests/src/Functional/DbLogViewsTest.php @@ -31,13 +31,13 @@ class DbLogViewsTest extends DbLogTest { /** * {@inheritdoc} */ - protected $defaultTheme = 'classy'; + protected $defaultTheme = 'stark'; /** * {@inheritdoc} */ protected function getLogsEntriesTable() { - return $this->xpath('.//table[contains(@class, "views-view-table")]/tbody/tr'); + return $this->xpath('.//div[contains(@class, "views-element-container")]//table/tbody/tr'); } /**