Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2885441 by phenaproxima, acbramley, dwkitchen, jibran, hchonov: EntityReferenceAutocompleteWidget should define its size setting as an integer

merge-requests/55/head
Lee Rowlands 2019-09-12 13:25:46 +10:00
parent 914d47f168
commit 49fae2a100
No known key found for this signature in database
GPG Key ID: 2B829A3DF9204DC4
2 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/lib/Drupal/Core/Field/Plugin/Field/FieldWidget/EntityReferenceAutocompleteWidget.php
View File

@ -28,7 +28,7 @@ class EntityReferenceAutocompleteWidget extends WidgetBase {
public static function defaultSettings() { public static function defaultSettings() {
return [ return [
'match_operator' => 'CONTAINS', 'match_operator' => 'CONTAINS',
'size' => '60', 'size' => 60,
'placeholder' => '', 'placeholder' => '',
] + parent::defaultSettings(); ] + parent::defaultSettings();
} }

20
core/tests/Drupal/FunctionalJavascriptTests/EntityReference/EntityReferenceAutocompleteWidgetTest.php
View File

@ -52,14 +52,18 @@ class EntityReferenceAutocompleteWidgetTest extends WebDriverTestBase {
// operator. // operator.
$field_name = 'field_test'; $field_name = 'field_test';
$this->createEntityReferenceField('node', 'page', $field_name, $field_name, 'node', 'default', ['target_bundles' => ['page']]); $this->createEntityReferenceField('node', 'page', $field_name, $field_name, 'node', 'default', ['target_bundles' => ['page']]);
$display_repository->getFormDisplay('node', 'page') $form_display = $display_repository->getFormDisplay('node', 'page');
->setComponent($field_name, [ $form_display->setComponent($field_name, [
'type' => 'entity_reference_autocomplete', 'type' => 'entity_reference_autocomplete',
'settings' => [ 'settings' => [
'match_operator' => 'CONTAINS', 'match_operator' => 'CONTAINS',
], ],
]) ]);
->save(); // To satisfy config schema, the size setting must be an integer, not just
// a numeric value. See https://www.drupal.org/node/2885441.
$this->assertInternalType('integer', $form_display->getComponent($field_name)['settings']['size']);
$form_display->save();
$this->assertInternalType('integer', $form_display->getComponent($field_name)['settings']['size']);
// Visit the node add page. // Visit the node add page.
$this->drupalGet('node/add/page'); $this->drupalGet('node/add/page');