Issue #2885441 by phenaproxima, acbramley, dwkitchen, jibran, hchonov: EntityReferenceAutocompleteWidget should define its size setting as an integer
							parent
							
								
									914d47f168
								
							
						
					
					
						commit
						49fae2a100
					
				| 
						 | 
				
			
			@ -28,7 +28,7 @@ class EntityReferenceAutocompleteWidget extends WidgetBase {
 | 
			
		|||
  public static function defaultSettings() {
 | 
			
		||||
    return [
 | 
			
		||||
      'match_operator' => 'CONTAINS',
 | 
			
		||||
      'size' => '60',
 | 
			
		||||
      'size' => 60,
 | 
			
		||||
      'placeholder' => '',
 | 
			
		||||
    ] + parent::defaultSettings();
 | 
			
		||||
  }
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -52,14 +52,18 @@ class EntityReferenceAutocompleteWidgetTest extends WebDriverTestBase {
 | 
			
		|||
    // operator.
 | 
			
		||||
    $field_name = 'field_test';
 | 
			
		||||
    $this->createEntityReferenceField('node', 'page', $field_name, $field_name, 'node', 'default', ['target_bundles' => ['page']]);
 | 
			
		||||
    $display_repository->getFormDisplay('node', 'page')
 | 
			
		||||
      ->setComponent($field_name, [
 | 
			
		||||
        'type' => 'entity_reference_autocomplete',
 | 
			
		||||
        'settings' => [
 | 
			
		||||
          'match_operator' => 'CONTAINS',
 | 
			
		||||
        ],
 | 
			
		||||
      ])
 | 
			
		||||
      ->save();
 | 
			
		||||
    $form_display = $display_repository->getFormDisplay('node', 'page');
 | 
			
		||||
    $form_display->setComponent($field_name, [
 | 
			
		||||
      'type' => 'entity_reference_autocomplete',
 | 
			
		||||
      'settings' => [
 | 
			
		||||
        'match_operator' => 'CONTAINS',
 | 
			
		||||
      ],
 | 
			
		||||
    ]);
 | 
			
		||||
    // To satisfy config schema, the size setting must be an integer, not just
 | 
			
		||||
    // a numeric value. See https://www.drupal.org/node/2885441.
 | 
			
		||||
    $this->assertInternalType('integer', $form_display->getComponent($field_name)['settings']['size']);
 | 
			
		||||
    $form_display->save();
 | 
			
		||||
    $this->assertInternalType('integer', $form_display->getComponent($field_name)['settings']['size']);
 | 
			
		||||
 | 
			
		||||
    // Visit the node add page.
 | 
			
		||||
    $this->drupalGet('node/add/page');
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue