Issue #2473949 by mortendk, rteijeiro, rachel_norfolk, Cottser, LewisNyman: Prefix form-type-* classes with js-

core/misc/vertical-tabs.js

@@ -149,7 +149,7 @@
       // Display the tab.
       this.item.show();
       // Show the vertical tabs.
-      this.item.closest('.form-type-vertical-tabs').show();
+      this.item.closest('.js-form-type-vertical-tabs').show();
       // Update .first marker for items. We need recurse from parent to retain the
       // actual DOM element order as jQuery implements sortOrder, but not as public
       // method.
@@ -182,7 +182,7 @@
       }
       // Hide the vertical tabs (if no tabs remain).
       else {
-        this.item.closest('.form-type-vertical-tabs').hide();
+        this.item.closest('.js-form-type-vertical-tabs').hide();
       }
       return this;
     }

core/modules/locale/config/optional/tour.tour.locale.yml

@@ -55,7 +55,7 @@ tips:
     body: 'You can write your own translation in the text fields of the right column. Try to figure out in which context the text will be used in order to translate it in the appropriate way.'
     weight: 6
     attributes:
-      data-class: form-type-textarea
+      data-class: js-form-type-textarea
 
   locale-validate:
     id: locale-validate

core/modules/system/src/Tests/Common/RenderWebTest.php

@@ -91,7 +91,7 @@ class RenderWebTest extends WebTestBase {
       '#markup' => $this->randomMachineName(),
     );
     $this->assertRenderedElement($element, '//div[contains(@class, :class) and contains(., :markup)]/label[contains(., :label)]', array(
-      ':class' => 'form-type-item',
+      ':class' => 'js-form-type-item',
       ':markup' => $element['#markup'],
       ':label' => $element['#title'],
     ));
@@ -138,7 +138,7 @@ class RenderWebTest extends WebTestBase {
       '#markup' => $this->randomMachineName(),
     );
     $this->assertRenderedElement($element, '//details/div/div[contains(@class, :class) and contains(., :markup)]', array(
-      ':class' => 'form-type-item',
+      ':class' => 'js-form-type-item',
       ':markup' => $element['item']['#markup'],
     ));
   }

core/modules/system/templates/form-element.html.twig

@@ -48,7 +48,7 @@
 {%
   set classes = [
     'form-item',
-    'form-type-' ~ type|clean_class,
+    'js-form-type-' ~ type|clean_class,
     'form-item-' ~ name|clean_class,
     title_display not in ['after', 'before'] ? 'form-no-label',
     disabled == 'disabled' ? 'form-disabled',

core/modules/views_ui/js/views-admin.js

@@ -795,7 +795,7 @@
           });
         });
       // Uncheck the select all checkbox if any of the others are unchecked.
-      $('#views-ui-handler-form').find('div.form-type-checkbox').not($('.form-item-options-value-all'))
+      $('#views-ui-handler-form').find('div.js-form-type-checkbox').not($('.form-item-options-value-all'))
         .find('input[type=checkbox]')
         .on('click', function () {
           if ($(this).is('checked') === false) {

core/themes/classy/templates/form/form-element.html.twig

@@ -46,6 +46,7 @@
 {%
   set classes = [
     'form-item',
+    'js-form-type-' ~ type|clean_class,
     'form-type-' ~ type|clean_class,
     'form-item-' ~ name|clean_class,
     title_display not in ['after', 'before'] ? 'form-no-label',