Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2863597 by Lendude, Jo Fitzgerald, michielnugter, nlisgo, dawehner: Convert web tests to browser tests for toolbar module

8.4.x
Nathaniel Catchpole 2017-04-28 13:28:52 -04:00
parent 9e7f7cd4cb
commit 477fbfd292
3 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/modules/toolbar/src/Tests/ToolbarAdminMenuTest.php → core/modules/toolbar/tests/src/Functional/ToolbarAdminMenuTest.php
View File

@ -1,11 +1,12 @@
<?php
namespace Drupal\toolbar\Tests;
namespace Drupal\Tests\toolbar\Functional;
use Drupal\Core\EventSubscriber\MainContentViewSubscriber;
use Drupal\Core\Language\LanguageInterface;
use Drupal\Core\Url;
use Drupal\language\Entity\ConfigurableLanguage;
use Drupal\simpletest\WebTestBase;
use Drupal\Tests\BrowserTestBase;
use Drupal\user\RoleInterface;
/**
@ -25,7 +26,7 @@ use Drupal\user\RoleInterface;
*
* @group toolbar
*/
class ToolbarAdminMenuTest extends WebTestBase {
class ToolbarAdminMenuTest extends BrowserTestBase {
/**
* A user with permission to access the administrative toolbar.
@ -297,7 +298,7 @@ class ToolbarAdminMenuTest extends WebTestBase {
// Assume this is the only result.
// Translate the string to a random string.
$textarea = current($this->xpath('//textarea'));
$lid = (string) $textarea[0]['name'];
$lid = (string) $textarea->getAttribute('name');
$edit = [
$lid => $translation,
];
@ -330,8 +331,8 @@ class ToolbarAdminMenuTest extends WebTestBase {
// Request a new page to refresh the drupalSettings object.
$subtrees_hash = $this->getSubtreesHash();
$ajax_result = $this->drupalGetAjax('toolbar/subtrees/' . $subtrees_hash);
$this->assertResponse('200');
$this->drupalGet('toolbar/subtrees/' . $subtrees_hash, ['query' => [MainContentViewSubscriber::WRAPPER_FORMAT => 'drupal_ajax']], ['X-Requested-With: XMLHttpRequest']);
$ajax_result = json_decode($this->getSession()->getPage()->getContent(), TRUE);
$this->assertEqual($ajax_result[0]['command'], 'setToolbarSubtrees', 'Subtrees response uses the correct command.');
$this->assertEqual(array_keys($ajax_result[0]['subtrees']), ['system-admin_content', 'system-admin_structure', 'system-themes_page', 'system-modules_list', 'system-admin_config', 'entity-user-collection', 'front'], 'Correct subtrees returned.');
}

6
core/modules/toolbar/src/Tests/ToolbarCacheContextsTest.php → core/modules/toolbar/tests/src/Functional/ToolbarCacheContextsTest.php
View File

@ -1,11 +1,11 @@
<?php
namespace Drupal\toolbar\Tests;
namespace Drupal\Tests\toolbar\Functional;
use Drupal\Core\Cache\Cache;
use Drupal\Core\EventSubscriber\MainContentViewSubscriber;
use Drupal\simpletest\WebTestBase;
use Drupal\system\Tests\Cache\AssertPageCacheContextsAndTagsTrait;
use Drupal\Tests\BrowserTestBase;
/**
@ -13,7 +13,7 @@ use Drupal\system\Tests\Cache\AssertPageCacheContextsAndTagsTrait;
*
* @group toolbar
*/
class ToolbarCacheContextsTest extends WebTestBase {
class ToolbarCacheContextsTest extends BrowserTestBase {
use AssertPageCacheContextsAndTagsTrait;

8
core/modules/toolbar/src/Tests/ToolbarMenuTranslationTest.php → core/modules/toolbar/tests/src/Functional/ToolbarMenuTranslationTest.php
View File

@ -1,15 +1,15 @@
<?php
namespace Drupal\toolbar\Tests;
namespace Drupal\Tests\toolbar\Functional;
use Drupal\simpletest\WebTestBase;
use Drupal\Tests\BrowserTestBase;
/**
* Tests that the toolbar icon class remains for translated menu items.
*
* @group toolbar
*/
class ToolbarMenuTranslationTest extends WebTestBase {
class ToolbarMenuTranslationTest extends BrowserTestBase {
/**
* A user with permission to access the administrative toolbar.
@ -66,7 +66,7 @@ class ToolbarMenuTranslationTest extends WebTestBase {
// Translate the menu item.
$menu_item_translated = $this->randomMachineName();
$textarea = current($this->xpath('//textarea'));
$lid = (string) $textarea[0]['name'];
$lid = (string) $textarea->getAttribute('name');
$edit = [
$lid => $menu_item_translated,
];