Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #2041225 by swentel: Fixed FieldInstance::delete() doesn't clean up all form modes.

8.0.x
Alex Pott 2013-09-21 18:00:22 +02:00
parent 29dd37a213
commit 477cb6ee97
4 changed files with 88 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
core/modules/entity/lib/Drupal/entity/Tests/EntityDisplayTest.php
View File

@ -257,19 +257,32 @@ class EntityDisplayTest extends DrupalUnitTestBase {
));
$instance->save();
// Create an entity display.
// Create default and teaser entity display.
entity_create('entity_display', array(
'targetEntityType' => 'entity_test',
'bundle' => 'entity_test',
'viewMode' => 'default',
'mode' => 'default',
))->setComponent($field_name)->save();
entity_create('entity_display', array(
'targetEntityType' => 'entity_test',
'bundle' => 'entity_test',
'mode' => 'teaser',
))->setComponent($field_name)->save();
// Check the component exists.
$display = entity_get_display('entity_test', 'entity_test', 'default');
$this->assertTrue($display->getComponent($field_name));
$display = entity_get_display('entity_test', 'entity_test', 'teaser');
$this->assertTrue($display->getComponent($field_name));
// Delete the instance.
$instance->delete();
// Check that the component has been removed from the entity display.
// Check that the component has been removed from the entity displays.
$display = entity_get_display('entity_test', 'entity_test', 'default');
$this->assertFalse($display->getComponent($field_name));
$display = entity_get_display('entity_test', 'entity_test', 'teaser');
$this->assertFalse($display->getComponent($field_name));
}
}

49
core/modules/entity/lib/Drupal/entity/Tests/EntityFormDisplayTest.php
View File

@ -120,4 +120,53 @@ class EntityFormDisplayTest extends DrupalUnitTestBase {
$this->assertEqual($widget->getPluginId(), $default_widget);
}
/**
* Tests deleting field instance.
*/
public function testDeleteFieldInstance() {
$this->enableModules(array('field_sql_storage', 'field_test'));
$field_name = 'test_field';
// Create a field and an instance.
$field = entity_create('field_entity', array(
'name' => $field_name,
'entity_type' => 'entity_test',
'type' => 'test_field'
));
$field->save();
$instance = entity_create('field_instance', array(
'field_name' => $field_name,
'entity_type' => 'entity_test',
'bundle' => 'entity_test',
));
$instance->save();
// Create default and compact entity display.
entity_create('entity_form_display', array(
'targetEntityType' => 'entity_test',
'bundle' => 'entity_test',
'mode' => 'default',
))->setComponent($field_name)->save();
entity_create('entity_form_display', array(
'targetEntityType' => 'entity_test',
'bundle' => 'entity_test',
'mode' => 'compact',
))->setComponent($field_name)->save();
// Check the component exists.
$display = entity_get_form_display('entity_test', 'entity_test', 'default');
$this->assertTrue($display->getComponent($field_name));
$display = entity_get_form_display('entity_test', 'entity_test', 'compact');
$this->assertTrue($display->getComponent($field_name));
// Delete the instance.
$instance->delete();
// Check that the component has been removed from the entity displays.
$display = entity_get_form_display('entity_test', 'entity_test', 'default');
$this->assertFalse($display->getComponent($field_name));
$display = entity_get_form_display('entity_test', 'entity_test', 'compact');
$this->assertFalse($display->getComponent($field_name));
}
}

7
core/modules/field/lib/Drupal/field/Entity/FieldInstance.php
View File

@ -458,7 +458,12 @@ class FieldInstance extends ConfigEntityBase implements FieldInstanceInterface {
field_cache_clear();
// Remove the instance from the entity form displays.
if ($form_display = entity_load('entity_form_display', $this->entity_type . '.' . $this->bundle . '.default')) {
$ids = array();
$form_modes = array('default' => array()) + entity_get_form_modes($this->entity_type);
foreach (array_keys($form_modes) as $form_mode) {
$ids[] = $this->entity_type . '.' . $this->bundle . '.' . $form_mode;
}
foreach (entity_load_multiple('entity_form_display', $ids) as $form_display) {
$form_display->removeComponent($this->field->name)->save();
}

17
core/modules/system/tests/modules/entity_test/entity_test.module
View File

@ -158,6 +158,23 @@ function entity_test_entity_view_mode_info_alter(&$view_modes) {
}
}
/**
* Implements hook_entity_form_mode_info_alter().
*/
function entity_test_entity_form_mode_info_alter(&$form_modes) {
$entity_info = entity_get_info();
foreach ($entity_info as $entity_type => $info) {
if ($entity_info[$entity_type]['module'] == 'entity_test') {
$form_modes[$entity_type] = array(
'compact' => array(
'label' => t('Compact version'),
'status' => TRUE,
),
);
}
}
}
/**
* Implements hook_field_extra_fields().
*/