Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #1164682 by mgifford, thedavidmeister, good_man, mvc, clemens.tolboom, sxnc, lazysoundsystem: Fixed links with a known language need language identifier.

8.0.x
Nathaniel Catchpole 2013-08-12 03:51:23 +01:00
parent 772849f021
commit 4343ef88f2
2 changed files with 38 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/includes/common.inc
View File

@ -1315,6 +1315,12 @@ function l($text, $path, array $options = array()) {
'language' => NULL,
);
// Add a hreflang attribute if we know the language of this link's url and
// hreflang has not already been set.
if (!empty($variables['options']['language']) && !isset($variables['options']['attributes']['hreflang'])) {
$variables['options']['attributes']['hreflang'] = $variables['options']['language']->id;
}
// Because l() is called very often we statically cache values that require an
// extra function call.
static $drupal_static_fast;

43
core/modules/system/lib/Drupal/system/Tests/Common/UrlTest.php
View File

@ -7,6 +7,7 @@
namespace Drupal\system\Tests\Common;
use Drupal\Core\Language\Language;
use Drupal\simpletest\WebTestBase;
use Symfony\Component\HttpFoundation\Request;
@ -52,9 +53,33 @@ class UrlTest extends WebTestBase {
}
/**
* Tests for active class in links produced by l() and #type 'link'.
* Tests that default and custom attributes are handled correctly on links.
*/
function testLinkActiveClass() {
function testLinkAttributes() {
// Test that hreflang is added when a link has a known language.
$language = new Language(array('id' => 'fr', 'name' => 'French'));
$hreflang_link = array(
'#type' => 'link',
'#options' => array(
'language' => $language,
),
'#href' => 'http://drupal.org',
'#title' => 'bar',
);
$langcode = $language->id;
// Test that the default hreflang handling for links does not override a
// hreflang attribute explicitly set in the render array.
$hreflang_override_link = $hreflang_link;
$hreflang_override_link['#options']['attributes']['hreflang'] = 'foo';
$rendered = drupal_render($hreflang_link);
$this->assertTrue($this->hasAttribute('hreflang', $rendered, $langcode), format_string('hreflang attribute with value @langcode is present on a rendered link when langcode is provided in the render array.', array('@langcode' => $langcode)));
$rendered = drupal_render($hreflang_override_link);
$this->assertTrue($this->hasAttribute('hreflang', $rendered, 'foo'), format_string('hreflang attribute with value @hreflang is present on a rendered link when @hreflang is provided in the render array.', array('@hreflang' => 'foo')));
// Test the active class in links produced by l() and #type 'link'.
$options_no_query = array();
$options_query = array(
'query' => array(
@ -88,16 +113,12 @@ class UrlTest extends WebTestBase {
$links = $this->xpath('//a[@href = :href and not(contains(@class, :class))]', array(':href' => url($path, $options_no_query), ':class' => 'active'));
$this->assertTrue(isset($links[0]), 'A link generated by l() to the current page without a query string when the current page has a query string is not marked active.');
}
/**
* Tests for custom class in links produced by l() and #type 'link'.
*/
function testLinkCustomClass() {
// Test adding a custom class in links produced by l() and #type 'link'.
// Test l().
$class_l = $this->randomName();
$link_l = l($this->randomName(), current_path(), array('attributes' => array('class' => array($class_l))));
$this->assertTrue($this->hasClass($link_l, $class_l), format_string('Custom class @class is present on link when requested by l()', array('@class' => $class_l)));
$this->assertTrue($this->hasAttribute('class', $link_l, $class_l), format_string('Custom class @class is present on link when requested by l()', array('@class' => $class_l)));
// Test #type.
$class_theme = $this->randomName();
@ -112,7 +133,7 @@ class UrlTest extends WebTestBase {
),
);
$link_theme = drupal_render($type_link);
$this->assertTrue($this->hasClass($link_theme, $class_theme), format_string('Custom class @class is present on link when requested by #type', array('@class' => $class_theme)));
$this->assertTrue($this->hasAttribute('class', $link_theme, $class_theme), format_string('Custom class @class is present on link when requested by #type', array('@class' => $class_theme)));
}
/**
@ -157,8 +178,8 @@ class UrlTest extends WebTestBase {
* @return bool
* TRUE if the class is found, FALSE otherwise.
*/
private function hasClass($link, $class) {
return preg_match('|class="([^\"\s]+\s+)*' . $class . '|', $link);
private function hasAttribute($attribute, $link, $class) {
return preg_match('|' . $attribute . '="([^\"\s]+\s+)*' . $class . '|', $link);
}
/**