Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3398400 by pradhumanjain2311, joachim, smustgrave: Clean up repeated method calls in ValidReferenceConstraintValidator

merge-requests/5414/merge
xjm 2023-11-15 19:07:21 -06:00
parent 9ef77100bd
commit 42c2676d0e
No known key found for this signature in database
GPG Key ID: 206B0B8743BDF4C2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/lib/Drupal/Core/Entity/Plugin/Validation/Constraint/ValidReferenceConstraintValidator.php
View File

@ -123,7 +123,7 @@ class ValidReferenceConstraintValidator extends ConstraintValidator implements C
if ($target_ids) {
// Get a list of pre-existing references.
$previously_referenced_ids = [];
if ($value->getParent() && ($entity = $value->getEntity()) && !$entity->isNew()) {
if ($entity && !$entity->isNew()) {
$existing_entity = $this->entityTypeManager->getStorage($entity->getEntityTypeId())->loadUnchanged($entity->id());
foreach ($existing_entity->{$value->getFieldDefinition()->getName()}->getValue() as $item) {
$previously_referenced_ids[$item['target_id']] = $item['target_id'];