Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #3280343 by bnjmnm, pooja saraah, Wim Leers: Audit of CKEditor 5 @todo items 

(cherry picked from commit 3f094e0c29)
merge-requests/1762/head
Lauri Eskola 2022-09-07 10:09:29 +03:00
parent 15ebeed5fd
commit 402d7fc1e7
No known key found for this signature in database
GPG Key ID: 382FC0F5B0DF53F8
7 changed files with 10 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/modules/ckeditor5/ckeditor5.module
View File

@ -50,10 +50,8 @@ function ckeditor5_help($route_name, RouteMatchInterface $route_match) {
$output .= '<dt>' . t('Generating accessible content') . '</dt>';
$output .= '<dd>';
$output .= '<ul>';
// @todo Uncomment this in https://www.drupal.org/project/ckeditor5/issues/3230230
// $output .= '<li>' . t('HTML tables can be created with table headers and caption/summary elements.') . '</li>';
// @todo Uncomment this in https://www.drupal.org/project/ckeditor5/issues/3222757
// $output .= '<li>' . t('Alt text is required by default on images added through CKEditor (note that this can be overridden).') . '</li>';
$output .= '<li>' . t('HTML tables can be created with table headers and caption/summary elements.') . '</li>';
$output .= '<li>' . t('Alt text is required by default on images added through CKEditor (note that this can be overridden).') . '</li>';
$output .= '<li>' . t('Semantic HTML5 figure/figcaption are available to add captions to images.') . '</li>';
$output .= '<li>' . t('To support multilingual page content, CKEditor 5 can be configured to include a language button in the toolbar.') . '</li>';
$output .= '</ul>';

2
core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupallinkmedia/drupallinkmediaediting.js
View File

@ -160,7 +160,7 @@ function editingDowncastMediaLink() {
// element which makes caused re-render of the media preview, making
// the media preview flicker once when media is unlinked.
// @todo ensure that this doesn't cause flickering after
// https://www.drupal.org/i/3246380 has been addressed.
// https://www.drupal.org/i/3304834 has been addressed.
writer.move(
writer.createRangeIn(linkInMedia),
writer.createPositionAt(mediaContainer, 0),

2
core/modules/ckeditor5/src/SmartDefaultSettings.php
View File

@ -122,7 +122,7 @@ final class SmartDefaultSettings {
// Overwrite the Editor config entity object's $filterFormat property, to
// prevent calls to Editor::hasAssociatedFilterFormat() and
// Editor::getFilterFormat() from loading the FilterFormat from storage.
// @todo Remove in https://www.drupal.org/project/ckeditor5/issues/3218985.
// @todo Remove in https://www.drupal.org/project/ckeditor5/issues/3231347.
$reflector = new \ReflectionObject($text_editor);
$property = $reflector->getProperty('filterFormat');
$property->setAccessible(TRUE);

12
core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php
View File

@ -737,16 +737,14 @@ class MediaTest extends WebDriverTestBase {
// Test that setting alt value to two double quotes will signal to the
// MediaEmbed filter to unset the attribute on the media image field.
// We intentionally add a space space after the two double quotes to test
// the string is trimmed to two quotes.
// We intentionally add a space after the two double quotes to test that the
// string is trimmed to two quotes.
$alt_override_input->setValue('"" ');
$this->getBalloonButton('Save')->click();
// Verify that the two double quote empty alt indicator ('""') set in
// the dialog has successfully resulted in a media image field with the
// alt attribute present but without a value.
// @todo Uncomment this in https://www.drupal.org/project/ckeditor5/issues/3206522.
// @codingStandardsIgnoreLine
// $this->assertNotEmpty($assert_session->waitForElementVisible('css', 'drupal-media img[alt=""]'));
// the alt text form balloon has successfully resulted in a media image
// field with the alt attribute present but without a value.
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '[data-media-embed-test-view-mode] img[alt=""]'));
// Test that the downcast drupal-media element's alt attribute now has the
// empty string indicator.

2
core/modules/ckeditor5/tests/src/FunctionalJavascript/SourceEditingTest.php
View File

@ -320,7 +320,7 @@ JS;
],
// Edge case: `style`.
// @todo https://www.drupal.org/project/drupal/issues/3260857
// @todo https://www.drupal.org/project/drupal/issues/3304832
// Edge case: `type` attribute on lists.
// @todo Remove in https://www.drupal.org/project/drupal/issues/3274635.

2
core/modules/ckeditor5/tests/src/Kernel/SmartDefaultSettingsTest.php
View File

@ -74,8 +74,6 @@ class SmartDefaultSettingsTest extends KernelTestBase {
'media',
'media_library',
'views',
// @todo Remove in https://www.drupal.org/project/drupal/issues/3263384
'ckeditor5_plugin_conditions_test',
'dblog',
'help',
];

2
core/modules/ckeditor5/tests/src/Unit/HTMLRestrictionsTest.php
View File

@ -125,8 +125,6 @@ class HTMLRestrictionsTest extends UnitTestCase {
['*' => ['foo' => ['a' => TRUE, 'b' => TRUE]]],
NULL,
];
// @todo Nothing in Drupal core uses this ability, and no custom/contrib
// module is known to use this. Therefore this is left for the future.
yield 'VALID BUT NOT YET SUPPORTED: global attribute tag with attribute allowed, specific attribute values forbidden' => [
['*' => ['foo' => ['a' => FALSE, 'b' => FALSE]]],
'The "*" HTML tag has attribute restriction "foo", but it is not an array of key-value pairs, with HTML tag attribute values as keys and TRUE as values.',