From 3fff51c708f9de55702fd5204949561d965e4800 Mon Sep 17 00:00:00 2001 From: catch Date: Thu, 16 Jun 2022 13:08:34 +0100 Subject: [PATCH] Issue #3268244 by Spokje, xjm, Wim Leers: [random test failure] Un-skip and fix QuickEditIntegrationTest::testArticleNode() --- .../LayoutBuilderIntegrationTest.php | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/core/modules/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php b/core/modules/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php index 7bc4e2a4ef7..ab8f1f0a1b2 100644 --- a/core/modules/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php +++ b/core/modules/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php @@ -119,7 +119,6 @@ class LayoutBuilderIntegrationTest extends QuickEditJavascriptTestBase { * Tests if an article node can be in-place edited with Quick Edit. */ public function testArticleNode() { - $this->markTestSkipped(); $term = Term::create([ 'name' => 'foo', 'vid' => 'tags', @@ -138,6 +137,17 @@ class LayoutBuilderIntegrationTest extends QuickEditJavascriptTestBase { ], ]); + // Move "tags" field to the top of all fields, so its Quick Edit Toolbar + // won't overlap any Quick Edit-able fields, which causes (semi-)random test + // failures. + \Drupal::entityTypeManager() + ->getStorage('entity_view_display') + ->load('node.article.default') + ->setComponent('field_tags', [ + 'type' => 'entity_reference_label', + 'weight' => 0, + ])->save(); + $this->drupalGet('node/' . $node->id()); // Initial state.