Drupal
/
drupal
mirror of https://git.drupalcode.org/project/drupal.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Issue #1967728 by Wim Leers: Fixed In-place editing toolbars in DOM not removed after stopping in-place editing.

8.0.x
webchick 2013-04-12 00:08:19 -07:00
parent 1fb4c7e15d
commit 3c89188181
2 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/modules/edit/js/theme.js
View File

@ -66,7 +66,7 @@ Drupal.theme.editModal = function(settings) {
*/
Drupal.theme.editToolbarContainer = function(settings) {
var html = '';
html += '<div id="' + settings.id + '" class="edit-toolbar-container edit-animate-invisible edit-animate-only-visibility">';
html += '<div id="' + settings.id + '" class="edit-toolbar-container">';
html += ' <div class="edit-toolbar-heightfaker edit-animate-fast">';
html += ' <div class="edit-toolbar primary" />';
html += ' </div>';

25
core/modules/edit/js/views/toolbar-view.js
View File

@ -408,31 +408,6 @@ Drupal.edit.views.ToolbarView = Backbone.View.extend({
else {
this.$el.insertBefore(this.editor.element);
}
var that = this;
// Animate the toolbar into visibility.
setTimeout(function () {
that.$el.removeClass('edit-animate-invisible');
}, 0);
},
remove: function () {
if (!this.$el) {
return;
}
// Remove after animation.
var that = this;
var $el = this.$el;
this.$el
.addClass('edit-animate-invisible')
// Prevent this toolbar from being detected *while* it is being removed.
.removeAttr('id')
.find('.edit-toolbar .edit-toolgroup')
.addClass('edit-animate-invisible')
.on(Drupal.edit.util.constants.transitionEnd, function (e) {
$el.remove();
});
},
/**